Commit Graph
127612 Commits
Author SHA1 Message Date
Dipalee Bhalodia 9d0962cb03 [IMP] portal: always send creation / connection email to new portal users
Currently it is embedded in a strange condition about reactivating an
existing user or adding the portal group. Let us send the connection
email each time as it contains basic information on the account and is
useful for the newly created or activated user.

This commit is linked to task ID 1843361 (and 1868112) and to PR #25299
(and #25889).
2018-07-24 15:33:22 +02:00
Hetashree Chauhan d543733093 [REM] hr_recruitment: remove broadcast of new employees on hardcoded channel
This is specific and updating the content is not easy for non technical
people. As same result can be achieved with a server action based on
employee creation it has been decided to remove the broadcast, and therefore
the template and code linked to it.

This commit is linked to task ID 1843122 (and 1868112) and to PR #25295
(and #25889).
2018-07-24 15:33:22 +02:00
Hetashree Chauhan 323eb1861b [IMP] hr_recruitment: make templates more modern and updated with Odoo guidelines
In this commit we improve templates used in hr_recruitment. Purpose of this
commit is to have templates that embed or use standard Odoo email layouts to
make them look modern and have a common style across all emails.

Main guidelines

 * better use of div / p / br to try to lessen layout issues, especially
   when updating templates using the editor;
 * correctly sequence the templates fields definition;
 * correctly set templates values notably auto_delete and user_signature
   fields to avoid confusion;
 * correctly layout the email content using light notification email. It
   can either propagate the layout choice through various send mail methods
   or directly embed the styling in the templates for more technical or
   complex templates;
 * use email_formatted computed field when possible to avoid having hand-made
   from / to addresses;
 * fix various typos and improve subjects when necessary;

Content of emails is not necessarily updated as the purpose of this task is
about styling, not content itself.

This commit is linked to task ID 1843122 (and 1868112) and to PR #25295
(and #25889).
2018-07-24 15:33:22 +02:00
Dipalee Bhalodia 2ab0fc6bf3 [IMP] hr: make templates more modern and updated with Odoo guidelines
In this commit we improve templates used in hr. Purpose of this commit
is to have templates that embed or use standard Odoo email layouts to make
them look modern and have a common style across all emails.

Main guidelines

 * better use of div / p / br to try to lessen layout issues, especially
   when updating templates using the editor;
 * correctly sequence the templates fields definition;
 * correctly set templates values notably auto_delete and user_signature
   fields to avoid confusion;
 * correctly layout the email content using light notification email. It
   can either propagate the layout choice through various send mail methods
   or directly embed the styling in the templates for more technical or
   complex templates;
 * use email_formatted computed field when possible to avoid having hand-made
   from / to addresses;
 * fix various typos and improve subjects when necessary;

Content of emails is not necessarily updated as the purpose of this task is
about styling, not content itself.

This commit is linked to task ID 1843361 (and 1868112) and to PR #25299
(and #25889).
2018-07-24 15:33:22 +02:00
Mitali Patel b26679ce16 [IMP] delivery: make templates more modern and updated with Odoo guidelines
In this commit we improve templates used in delivery. Purpose of this commit
is to have templates that embed or use standard Odoo email layouts to make
them look modern and have a common style across all emails.

Main guidelines

 * better use of div / p / br to try to lessen layout issues, especially
   when updating templates using the editor;
 * correctly sequence the templates fields definition;
 * correctly set templates values notably auto_delete and user_signature
   fields to avoid confusion;
 * correctly layout the email content using light notification email. It
   can either propagate the layout choice through various send mail methods
   or directly embed the styling in the templates for more technical or
   complex templates;
 * use email_formatted computed field when possible to avoid having hand-made
   from / to addresses;
 * fix various typos and improve subjects when necessary;

Content of emails is not necessarily updated as the purpose of this task is
about styling, not content itself.

This commit is linked to task ID 1843376 (and 1868112) and closes PR #25349
(and #25889).
2018-07-24 15:33:22 +02:00
Pratima Gupta 8915223517 [IMP] calendar: make templates more modern and updated with Odoo guidelines
In this commit we improve templates used in calendar. Purpose of this commit
is to have templates that embed or use standard Odoo email layouts to make
them look modern and have a common style across all emails.

Main guidelines

 * better use of div / p / br to try to lessen layout issues, especially
   when updating templates using the editor;
 * correctly sequence the templates fields definition;
 * correctly set templates values notably auto_delete and user_signature
   fields to avoid confusion;
 * correctly layout the email content using light notification email. It
   can either propagate the layout choice through various send mail methods
   or directly embed the styling in the templates for more technical or
   complex templates;
 * use email_formatted computed field when possible to avoid having hand-made
   from / to addresses;
 * fix various typos and improve subjects when necessary;

Content of emails is not necessarily updated as the purpose of this task is
about styling, not content itself.

This commit is linked to task ID 1843136 (and 1868112) and to PR #25412
(and #25889).
2018-07-24 15:33:22 +02:00
Pratima Gupta b65329270f [IMP] calendar: update registration model description
This new name is much easier to understand and nicer on emails you receive
by Odoo.

This commit is linked to task ID 1843136 (and 1868112) and to PR #25412
(and #25889).
2018-07-24 15:33:22 +02:00
Pratima Gupta a35a7f5931 [MOV] calendar: move mail data in their own files
It lessen noise on other data when updating templates. As they are subject
to frequent changes it is better to have them located in a single file.
It is also easier to find when searching for mail templates. This allows
calendar to comply more with the guidelines.

By the way also remove a falsy comment in calendar data.

This commit is linked to task ID 1843136 (and 1868112) and to PR #25412
(and #25889).
2018-07-24 15:33:22 +02:00
Dipalee Bhalodia fa9382a33c [IMP] auth_signup: make templates more modern and updated with Odoo guidelines
In this commit we improve templates used in auth_signup. Purpose of this commit
is to have templates that embed or use standard Odoo email layouts to make
them look modern and have a common style across all emails.

Main guidelines

 * better use of div / p / br to try to lessen layout issues, especially
   when updating templates using the editor;
 * correctly sequence the templates fields definition;
 * correctly set templates values notably auto_delete and user_signature
   fields to avoid confusion;
 * correctly layout the email content using light notification email. It
   can either propagate the layout choice through various send mail methods
   or directly embed the styling in the templates for more technical or
   complex templates;
 * use email_formatted computed field when possible to avoid having hand-made
   from / to addresses;
 * fix various typos and improve subjects when necessary;

Content of emails is not necessarily updated as the purpose of this task is
about styling, not content itself.

This commit is linked to task ID 1843361 (and 1868112) and to PR #25299
(and #25889).
2018-07-24 15:33:22 +02:00
Pratima GuptaandMitali Patel 0d83edc9b0 [IMP] account, l10n_be_invoice: make templates more modern and updated with Odoo guidelines
In this commit we improve templates used in account and l10n_be. Purpose of this
commit is to have templates that embed or use standard Odoo email layouts to
make them look modern and have a common style across all emails.

Main guidelines

 * better use of div / p / br to try to lessen layout issues, especially
   when updating templates using the editor;
 * correctly sequence the templates fields definition;
 * correctly set templates values notably auto_delete and user_signature
   fields to avoid confusion;
 * correctly layout the email content using light notification email. It
   can either propagate the layout choice through various send mail methods
   or directly embed the styling in the templates for more technical or
   complex templates;
 * use email_formatted computed field when possible to avoid having hand-made
   from / to addresses;
 * fix various typos and improve subjects when necessary;

Content of emails is not necessarily updated as the purpose of this task is
about styling, not content itself.

This commit is linked to task ID 1843395 and 1843376 (and 1868112) and to
PR #25294 and #25349 (and #25889).

Co-Authored-By: Mitali Patel <mpa@odoo.com>
2018-07-24 15:33:22 +02:00
Mitali Patel 022a1660b4 [IMP] mail: clean record name displayed in notification email and update font size
Purpose is to avoid having '/' in record name. This is generally considered
as being an URL and leads to a specific display in most email readers. In
this commit we therefore remove '/' by '-'.

A use case is the name of payment receipts.

Font sizes in light notification template are also standardized to 13 and
11 px to better match the chatter layout. Emails are still bioutifoul.

This commit is linked to task ID 1843376 (and 1868112) and to PR #25349
(and #25889).
2018-07-24 15:33:22 +02:00
Thibault Delavallée 744261a2ef [IMP] mail: add optional encapsulation layout when sending template-based emails
This commit adds possibility to add a notification layout when sending
an email based on a template using the send_mail method. Purpose of this
task is to allow to send some technical template-based emails using the
default notification layouts defined in mail. It allows to avoid redefining
the whole layout in the template itself.

Target of this commit is some technical templates that are send only by
email. Customer email have currently no way of choosing this notification
layout.

This commit is linked to task ID 1868112 and to PR #25889.
2018-07-24 15:33:22 +02:00
Kirti Choudhary 298904f1d9 [REM] crm: remove unnecessary mail template data
This template was linked to an old automated rule used as a demo sending
an email to old opportunities. The demo automated rule has been removed
since. Moreover there is already a mail template used for mass mailing
in crm. No need to have unnecessary data especially it is not linked to
any business flow.

This commit is linked to task ID 1841503 (and 1868112) and to PR #25388
(and #25889).
2018-07-24 15:33:22 +02:00
Mitali Patel d8496aea2e [REM] mail: remove duplicated mass mailing action on partner
This action allowing to send a mass mailing with a default template on a
partner is defined twice in mail on same object, with same xml_id. See in
composer views for the other definition.

This commit is linked to task ID 1843361 (and 1868112) and to PR #25287
(and #25889).
2018-07-24 15:33:22 +02:00
Thibaud Ducasse c51488c2f4 [CLA] signature for tducasse
Closes #25895
2018-07-24 15:29:31 +02:00
Fabrice Henrion 2bb411a226 [FIX] website_event: wording typo
Closes #25933
2018-07-24 15:24:54 +02:00
Christophe Simonis 6c736a6874 [FIX] account: lint test file to please pylint check 2018-07-24 15:07:41 +02:00
Julien Machiels e9901d1422 [FIX] barcodes: barcodes working in button in dropdown
On mobile, some barcodes didn't trigger in the picking screens, notably
O-BTN.validate. This is due to the use of parent() to check if the
button is in a dropdown, as parent() only checks one DOM-level upwards.
The button being inside a <ul><li>, we need to check more levels than
one to pass the condition and trigger the button press.

By changing parent() to parents(), the entire chain will be checked, not
just one level, and the button press is correctly triggered.

opw-1860964
closes #25941
2018-07-24 14:45:57 +02:00
Kirti Choudhary 64231863d4 [FIX] mail: auto-focus input on open composer in Chatter (touch and non-mobile devices).
Before this commit, when opening the composer in chatter with "Send Message"
or "Log note" with a touch and non-moble device (e.g. laptop with touchscreen),
the focus was not set on the input automatically.

The intent behaviour is to auto-set the focus on non-mobile device, including
touch devices. This commit fixes this issue for touch and non-mobile devices.

Task-ID 1824035
2018-07-24 13:30:01 +02:00
Priyanka Kakadiya 66b44a5d8a [FIX] mail: auto-focus input on open thread in Discuss (touch and non-mobile devices).
Before this commit, when opening a discuss thread with a touch device that is
not mobile (e.g. laptop with a touchscreen), the focus was not set on the input
automatically.

The intent behaviour is to auto-set the focus on non-mobile device including
touch devices. This commit fixes this issue for touch and non-mobile devices.

Task-ID 1838244
2018-07-24 13:10:48 +02:00
Goffin Simon 41bea4125c [FIX] stock: Delivery slip with quantity = 0 until validation
Partial backport of https://github.com/odoo/odoo/commit/ccafe50500a803fe8c8345ab0318128a92bce3b5

Now the initial demand is used when the state is not done.

opw:1867906
2018-07-24 13:00:06 +02:00
Alexandre Kühn b67b89c315 [FIX] web: correctly align value/text in stat button
Before this commit, the style of the value and text in some stat buttons were
broken.

The design of the stat button is to have a single value and a single text which
are stacked as follow:

  [CSS]                       [Visually]           [Example]

  .o_stat_info                +---------+          +------------+
     .o_stat_value            |         |          |            |
     .o_stat_text             |  value  |          | 10         |
                              |  text   |          | Forecasted |
                              |         |          |            |
                              +---------+          +------------+

However, some stat buttons use multiple values or texts. For example:

  [CSS]                       [Visually]           [Example]

  .o_stat_info                +-------------+      +------------+
     .o_stat_value            |             |      |            |
        .o_stat_info          |  value text |      | 3 Hour(s)  |
          .o_stat_value       |  text       |      | Lost       |
          .o_stat_text        |             |      |            |
     .o_stat_text             +-------------+      +------------+

  [CSS]                       [Visually]           [Example]

  .o_stat_info                +---------------+    +---------------+
     .o_stat_text             |               |    |               |
     .o_stat_text             |  text  value  |    |  Min:  10.00  |
  .o_stat_info                |  text  value  |    |  Max:  20.00  |
     .o_stat_value            |               |    |               |
     .o_stat_value            +---------------+    +---------------+

The latter is works fine with block, which guarantees vertical alignment.
However, the former case has some alignment issues like this:

    [Visually]

    +------------+
    |            |
    | 3          |
    |   Hour(s)  |
    | Lost       |
    |            |
    +------------+

This is due to the use of `display:block` for any `.o_stat_text` and `.o_stat_text`.

This commit fixes this issue, without affecting the other cases.

Task-ID 1841523
2018-07-24 12:51:14 +02:00
Xavier Morel a56372a4ca [FIX] various broken JS docstrings
Resulting in sphinx warnings or ill-formatted doc all the way to the
doc not building at all.
2018-07-24 12:06:13 +02:00
Martin Trigaux a425695e92 [I18N] remove es_AR translations
Courtesy of Juan José Scarafía, ADHOC
The quality of the Spanish (Argentina) translations is very poor.
Remove them all and will start from scratch, translating only when needed.
2018-07-24 10:45:46 +02:00
Goffin Simon ca14f232e0 [FIX] base_vat_autocomplete: Create contact using VAT number
Let's install base_vat_autocomplete and  base_address_extended
When creating a contact with a VAT number, the street was not
formated by the autocomplete in a correct way because the function checkVat all the time
returns the street with the following format: '%(street_name)s, %(street_number)s/%(street_number2)s'
and this function doesn't take the street format of the country into account.

So the function _split_street tried to split the street into street_name, street_number, street_number2 with the
street_format of the partner but the street was  not well formated by checkVat.

opw:1867491
2018-07-24 09:54:29 +02:00
Hetashree Chauhan 26fbf93387 [IMP] repair: display product description on repair line and repair fee
PURPOSE
=======

All quotations should look the same, no matter if they are made in sales app or repair app to avoid to confuse the users.
From ticket : https://www.odoo.com/web#id=1833072&view_type=form&model=project.task&menu_id=

SPECIFICATIONS
==============

Minor refinement for repair quotations, show the product description, like in normal quotations, when printing the quotation from a repair order

This commit is related to task : 1834225
2018-07-23 18:37:28 +02:00
Jeremy Kersten f045186f23 [FIX] report: fix padding for ul in report pdf
Rendering in html was correct thanks to the webkit-padding-start 40px added
by the browser. But once printed with wkhtml, the padding was missing.

Now we force the padding manually.

This commit closes #7375
2018-07-23 17:02:09 +02:00
Raphael Collet 1748fa2aa0 [FIX] crm: fix access rights in test 2018-07-23 16:32:46 +02:00
Martin Trigaux 7fbf7e233c [IMP] base: do not load local file resources
The generation of the manifest should not be platform dependent, its content
should be the same whatever local files are present on the filesystem
2018-07-28 11:25:24 +02:00
Raphael Collet 629886434c [FIX] crm: fix access rights in test 2018-07-23 16:32:46 +02:00
Martin Trigaux 4c7e74f5e9 [IMP] base: do not load local file resources
The generation of the manifest should not be platform dependent, its content
should be the same whatever local files are present on the filesystem
2018-07-28 11:25:24 +02:00
Christophe Simonis 4e76173a43 [MERGE] forward port branch 11.0 up to 219d2296d6 2018-07-23 16:03:25 +02:00
Yannick Tivisse d00ff6187a [IMP] stock, product_expiry: Improve the traceability of the products
PURPOSE
=======

Improve the traceability of the products.

1. If you have an issue with a serial or lot number, you want to easily find from which supplier it's coming and to which customer it has been delivered, to contact them in case of problem.

2. We have the possibility to define expiration dates on products but the users are not informed when this date is reached. Now we can easily inform them with the next activities.

SPECIFICATIONS
==============

1. Locate precisely a SN/LN (find to which customer it has been delivered and from which supplier it's coming from)
Add fields "Purchase Orders" and "Sale Orders" (must be a many2many) and displays PO's and SO's related to this LN/SN.

2. Log a next activity for the product responsible when expiration date is reached for a product [OK]
- Check the alert_date on the stock.production.lot, if the date is in the past or today, log a next activity on the stock.production.lot
- Assigned to = the product responsible
- Due date = today
- Activity = Alert Date Reached
- Text = The alert date has been reached for this lot/serial number.
- Raise a next activity only for products that are still in stock = that are in a location of type internal.
- This cron checking the alert dates should be added in the existing scheduler cron
- The next activity is only create one time for the each lot. If a next activity has already be create for this lot previously, next activity will not be create again.
2018-07-23 15:58:12 +02:00
Nicolas Vannieuwerburgh edbf129372 [IMP] product_expiry: Schedule an activity on lots when expiration date is reached 2018-07-23 15:57:02 +02:00
Nicolas Vannieuwerburgh 86448be319 [IMP] purchase_stock: Compute the related purchase orders on production lots
Add a computed field on a stock.production.lot to retrieve all the purchase
orders coming from a done stock.move.line if the stock.move is also
done and if the destination usage is 'supplier'.
2018-07-23 15:57:02 +02:00
Nicolas Vannieuwerburgh cfd3e6b369 [IMP] sale_stock: Compute the related sales orders on production lots
Add a computed field on a stock.production.lot to retrieve all the sales
orders coming from a done stock.move.line if the stock.move is also
done and if the destination usage is 'customer'.
2018-07-23 15:57:02 +02:00
Christophe Simonis 219d2296d6 [MERGE] forward port branch saas-15 up to c4ee29345a 2018-07-23 15:45:08 +02:00
Christophe Simonis c4ee29345a [MERGE] forward port branch saas-14 up to 9ee882564f 2018-07-23 14:57:03 +02:00
qsm-odoo 946189eeff [FIX] base: onboarding assets should at least use backend helpers
See task-60668
2018-07-23 14:49:57 +02:00
Christophe Simonis 9ee882564f [MERGE] forward port branch 10.0 up to 6e71cf8a71 2018-07-23 14:21:06 +02:00
Priyanka Kakadiya 78a6124d5a [FIX] web: no traceback on button call action of type 'button'.
Before this commit, there was a traceback when clicking on a button
that generates a button call action with type `'button'`.

This is due to the handler of such an action that assumes only a small
set of button actions. Each of those cases correctly sets the local
variable `def` to a deferred, so that the post-processing is correct
(i.e. it handles this variable as a deferred). However, this is wrong
with a different button call action, so that this variable is `undefined`
instead of a deferred.

This commit fixes the issue by ensuring that the variable `def` is always
a deferred. As a result, the post-processing can make the correct assumption
that this variable is a deferred.

Steps to reproduce:

 - Install Google Drive Integration app
 - Go to General Settings
 - In the category "Google Drive", click on "Get Authorization Code"
   (displayed as "Get Author...")

Task-ID 1861630
2018-07-23 13:48:09 +02:00
Christophe Simonis 6e71cf8a71 [MERGE] forward port branch 9.0 up to af2e480e41 2018-07-23 13:41:04 +02:00
Kishan Gajjar 7fa1525921 [FIX] web: correctly render "font awesome" icons on buttons
Revision on https://github.com/odoo/odoo/commit/9de1bc0

From the commit above, the style of some field binary images are broken.
This is due to changes from `<span>` to `<button>`. The style has been
altered by the default browser's style, which does the following on
Google Chrome:

```
    border-color: white;
    border: 1px solid;
    padding: 1px 7px 2px;
```

Most browsers set a border and some padding on buttons. This commit fixes
the style specifically for "font awesome" icons on buttons, by removing
the border and by overwriting the padding.

Tested browsers:

  - Google Chrome 67
  - Mozilla Firefox 61
  - Safari 11

Task-ID 1864027

Closes #25691
2018-07-23 13:34:33 +02:00
Christophe Simonis af2e480e41 [FIX] http: refresh request environment after authentication
This allow the `/web/session/authenticate` route to return correct
partner and company.

Closes #25652
2018-07-23 13:25:42 +02:00
Ivan Yelizariev 1e1d3ed9e6 [FIX] base: suggested default ACL should be safer
When there is no ACL for a model, the system emits a log with a sample
ACL entry that developers should consider adding. This proposed ACL
should be safe: a default read-only access for internal users
seems appropriate.

Closes #25919
2018-07-23 13:18:04 +02:00
Laurent Smet 0a13dde432 [REF] account_reports, *: security enhancements in reports
* get_report_values() is now private
* account_reports: make private most of the methods to avoid any leak
* account_reports: ensure the options dict cannot be forged to leak any multi-company info
* [FIX] account_reports: prevent inconsistencies between options and context

Was task: 1823127
Was PR #2399
2018-07-23 12:34:09 +02:00
Laurent Smet 93cacd5e59 [FIX] account: improve security in reports and in account's query_get()
* privatize the get_report_values() method
* check read access rights and ir.rules in _query_get() from account module

Was task 36590
Was PR #25822
2018-07-23 12:21:06 +02:00
Florent de Labarre 3528e804de [FIX] stock: Error message don't contain the name of product
The message don't show the name of product.

Before the fix:

The message was: "It is not possible to reserve more products of than you have in stock."

After the fix:

The message is: "It is not possible to reserve more products of [0221] Product A than you have in stock."

opw:1868449
2018-07-23 12:09:12 +02:00
Laurent Smet 6ea300498f [REF] account, stock_landed_costs: use AssertRecordValues in tests
Was task: 1856976
Was PR #25893
2018-07-23 11:50:35 +02:00
Laurent Smet 45cde5ff38 [IMP] tests: added assertRecordValues() in BaseCase
This method will help to compare a recordset with their expected values, in the form of a list of dict

Was task: 1856976
Was PR #25129
2018-07-23 11:13:39 +02:00