Commit Graph
127612 Commits
Author SHA1 Message Date
David Beguin e7871625f6 [FIX] mail, mass_mailing: remove user error if remove unexisting record from blacklist
In unsubscribe page, if the user try to come back
(and be removed from the blacklist)
but his email have been deleted from the blacklist,
it was leading to an error.
Instead, and in order to keep a trace of what the user asked,
if the email is not found in the blacklist, the record will be
created but archived directly.
Also, it aligns the return of both methods _add/_remove
2018-08-30 09:45:58 +02:00
David Beguin a409dd3d31 [IMP] mail, mass_mailing : avoid edit blacklist entries
Edit blacklist records has the side effect of unblacklist the
contact that had the old blacklist email address.
If the user entered a wrong email address to create a balcklist record,
he now has to delete the record and start again.
2018-08-30 09:45:58 +02:00
David Beguin 39a628e586 [IMP] mass_mailing : review unsubscribe page + renaming blacklist creation date in form
Reviewing unsubscribe page style and button naming.
Rewritting the feedback controller to be easily readable.
Renaming blacklist creation date field in form to remove confusion.
2018-08-30 09:45:58 +02:00
Mitali Patel 5028da3873 [FIX] website_sale: removing compute_currency function from qweb template (#26606)
compute method called 2 times in t-esc case when monetary field has "from_currency ::
 1) value_to_html: compute method call when qweb monetary widget is return value as a html.
     see https://github.com/odoo/odoo/blob/10.0/odoo/addons/base/ir/ir_qweb/fields.py#L325
 2) compute_currency : compute_currency method is pass from controller into render engine and it is call the compute method.
So, we removed compute_currency method from qweb template in the t-esc with monetary widget.
2018-08-30 09:26:49 +02:00
Lucas Perais (lpe) e65c8826ef [FIX] sale_timesheet: timesheet cost with company on analytic account
FIXUP da2140b

The above commmit was half-right in the business logic, but overlooked that if a user is not
in the company of the project, it will crash.
This use case worked before that commit

While agreeing that a little more clear access right is needed
like for example be able to get the project_time_mode_id on the companies
that are in user.company_ids,
the aim of this present commit is to avoid regression

OPW 1878204
closes #26539
2018-08-30 09:21:02 +02:00
Lucas Perais (lpe) b8fe404eae [FIX] project: portal should see projects only when he has tasks
before this commit, on /my/tasks, in the filter dropdown, every project that had visibility = portal was displayed
regardless of whether the portal user was a follower or not

After this commit, we search project in a more clever manner

OPW 1878187
closes #26615
2018-08-30 09:17:23 +02:00
Goffin Simon 1962d17c4b [FIX] hr_attendance: White screen if employee is not set
When the user was not linked to an employee, the first screen of the Attendance app
(the check-in/out screen) stayed white.

opw:1880582
2018-08-30 09:12:34 +02:00
Nicolas Martinelli 93a586be7c [FIX] calendar: recurring events
Do not parse the rule with `rrulestr`, because converting back to string
will change the original rule.
2018-08-30 09:04:23 +02:00
Joren Van Onder a1802fa327 [FIX] point_of_sale: iface_print_auto doesn't require a POSBox
Auto-printing works with and without a POSBox. Skipping the print
screen only works with a POSBox.

Was possible in v10, small oversight of
80e89c7a11.

opw-1874390
2018-08-29 14:39:01 -07:00
Sébastien Theys 9441a1f5e1 [FIX] base: RNG validate text attribute for field (url)
The UrlWidget supports a text attribute to define the text of the <a> tag, but the text attribute wasn't supported in the RNG of the field.
Thus it wasn't possible to use it in tree views. However it already worked fine in form views because those are not RNG validated.

PR: none
Task: none
2018-08-29 23:22:33 +02:00
sed-odoo 9f9ba96013 [FIX] base: Fix traceback on draft invoice preview
Purpose
=======

- fix a traceback when preview a draft invoice while using SEPA QR code.

Specification
=============

- add a condition to not get the length of the communication if the field is not defined.
2018-08-29 17:41:51 +02:00
Sébastien Theys 4a3fd02af4 [FIX] various: clean up portal and reports (sales and invoices)
The goal of this commit is to fix the various views and reports of sales and invoices.

======
Portal
======

Fix breadcrumbs

Fix BS4 issues, alignment of various elements

Better auto resize of the invoice iframe

Fix invoice list for draft invoices

Fix previous/next document pagers

Remove unnecessary monetary widgets (not needed when using t-field if the field is Monetary)

Standardize invoice and sale routes:
- especially when related to displaying: html, pdf (print and download), text
- by using the get_portal_url() also for invoices

Add the total on the left column of sales order

================
Section and note
================

Improve general style:
- notes in italics
- sections: less padding, darker background, no borders

=========
Demo Data
=========

Fix sales order demo data to appear for the admin (instead of system)

PR: #25997
task-1869469
2018-08-29 17:16:06 +02:00
Christophe Monniez 984554f4ca [REF] web: move debug_managers in tools 2018-08-29 16:57:27 +02:00
Christophe Monniez 3f0ebca192 [IMP] web: New test to test Odoo menus
This commit adds a new js test in web that enters each app and click on
each view switcher, each menu and each search filter.

This test is tagged '-standard' and 'click_all' as it could last a long
time, that way it's not executed by default.

It could also be started from the browser console with
'clickEverywhere();'.
2018-08-29 16:57:27 +02:00
XavierDo 334b57fbf6 [FIX] base: remove error_context message from test log
Some error_context messages were logged during tests
causing some useless noise in log.
Corresponding mute logger are now fixed/added.
2018-08-29 16:51:42 +02:00
Christophe Simonis 0b8ef693a0 [MERGE] forward port branch saas-15 up to 0dc8588c5b 2018-08-29 16:45:36 +02:00
Goffin Simon 7b87212ea8 [FIX] account: Wrong quantity in Invoices analysis
Steps to reproduce:

Create a customer invoice with 2 product A and refund 1 product A.
Display account.invoice.report for this custumer.

Bug:

The quantity should be 1 not 3.

Fine tuning of this commit: e890682656

opw:1868116
2018-08-29 16:29:34 +02:00
Lucas Perais (lpe) 4ba87e073d [FIX] mail: right user_ids when calling /mail/follow
On a SO, write a note to a user
The mail the user receives contains a follow button
Click on it

Before this commit, the link did not add the user as follower of the SO
this was because the wrong uid was passed to the function

After this commit, user is added as follower

OPW 1869849
closes #26634
2018-08-29 15:58:10 +02:00
Jeremy Kersten 19cc218d03 [FIX] website: make field required once feature enable via checkbox
Now that this field is computed (true if value), once the user check a feature, it is required to fill in the field.

Before this commit, you can click on checkbox, and save without key in field, and a refresh checkbow was again unchecked.
2018-08-29 15:18:19 +02:00
Jeremy Kersten 2a9a514551 [FIX] website, website_theme_install: improve flow for new website creation 2018-08-29 15:18:19 +02:00
Jeremy Kersten e24fedb757 [FIX] website: create public user in sudo
If new user is not in the current company, once created you will not be able to read it and
a traceback is raised.
2018-08-29 15:18:13 +02:00
Christophe Simonis 0dc8588c5b [MERGE] forward port branch saas-14 up to 2a515bc7cb 2018-08-29 14:43:54 +02:00
Odoo Translation Bot f22e61dc74 [I18N] Update translation terms from Transifex 2018-08-29 14:19:27 +02:00
Toufik Benjaa b367625248 [FIX] sale_payment: create payment.token when needed
- Before this commit, a sale order that generate a subscription and paid
  by the form method do not create a payment.token.

  After this commit, we check if the sale order need a payment.token to
  be created, if so we set the correct transaction type.
2018-08-29 13:55:03 +02:00
Nicolas Martinelli b53b637745 [FIX] mrp: 'To Consume' in workorder
Hide the field since it is always set to zero.

opw-1869511
2018-08-29 13:38:51 +02:00
Christophe Simonis 2a515bc7cb [MERGE] forward port branch 10.0 up to 068f1cd302 2018-08-29 12:13:48 +02:00
David Beguin e5f490821b [FIX] mass_mailing: Feedback when multiple contacts with same email address 2018-08-29 12:13:29 +02:00
Christophe Simonis 068f1cd302 [MERGE] forward port branch 9.0 up to 5f25b902e5 2018-08-29 12:12:01 +02:00
Jeremy Kersten 2bc2ea0039 [FIX] website_sale_wishlist: allow the public user to delete product from the wishlist
Search 'id', 'in' instead to browse old record
Update session wishlist_ids when a product is deleted
Garbage old archived public wishlist, now we unlink theme directly, but for previous version
2018-08-29 11:56:27 +02:00
Jeremy Kersten f9b7104f7c [FIX] website_sale_comparison: bs4 fix, don't display compare box if nothing to compare 2018-08-29 11:56:27 +02:00
TWA 1b7cdbe925 [IMP] mrp: Correct demo data for traceability report
Purpose
=======

The traceability report is empty because the components have not been consumed in the mo
2018-08-29 11:38:52 +02:00
len-odoo 683ecab8dd [FIX] web: use an unused variable in mock server
Fine-tuning of commit:
https://github.com/odoo/odoo/commit/818c18e55d0718286ff5bf332186a10f4d7a58ef
which introduced a variable that it didn't use.

opw 1867049
2018-08-29 11:04:46 +02:00
Goffin Simon 6bc2be09f5 [FIX] stock: Description for receptions are not being shown in Delivery Slip
Steps to reproduce

- Create a product with a custom description for receptions

- Create a purchase order

- Open the resulting picking

Shown behavior

- Product name is shown, description for receptions isn't shown in the delivery slip report

PS: Same scenario with a sale order

opw:1879069
2018-08-29 10:07:53 +02:00
Pierre Paridans 118526e0a8 [FIX] web: restore access to minDate/maxDate functions on the DateWidget
Used in Enterprise (sale_subscription_dashboard).
Solve a traceback as reported on BS4 pad
2018-08-29 10:02:52 +02:00
Martin Trigaux a8469c4590 [FIX] tools: handle code in po
The previous code, as explained at b505ba9e0a, was to avoid creating duplicated
code entries for the same source (as only one is considered).

In case of a po comment like
 #. openerp-web
 #: model:ir.ui.view,arch_db:base.ir_access_view_search
 #: code:addons/web/static/src/js/chrome/search_inputs.js:716
 #: code:addons/web/static/src/xml/base.xml:1125
 #, python-format

the condition was not triggered (trans_type is model), creating two code entries

Necessary in #26614 to fix #26553
2018-08-28 18:10:03 +02:00
Martin Trigaux fe9cd11ab5 [FIX] base: generate translations in po format
Instead of csv, it allows to benefit from some features of POFile class like
handeling the duplicated terms correctly

In #26553, generating the missing terms was creating a new translation for
base.xml with no translation (value=src), making a previously translated term
no longer translated.

Closes #26614
Fixes #26553
2018-08-28 18:09:36 +02:00
Martin Trigaux 3e52413aa5 [FIX] base: correct typo in button label 2018-08-28 17:39:09 +02:00
Martin Trigaux fb14e4519f [FIX] gamification: allow employee to grant badge
If the user does not have the rights to write on the user profile, he will
trigger an access error.
Put it as a simple computed readonly field to avoid access errors

In 10.0, a workaround was developed at 0312c604f4 but it should be reverted
after this commit
2018-08-28 17:35:20 +02:00
Martin Trigaux 0312c604f4 [FIX] hr_gamification: allow employees to grant each other badges
When creating a new wizard, the related field user_id = employee_id.user_id
forces a write on employee model

Make sure we actually have the same value (to avoid using the wizard to modify
employees) and use sudo to grant the badge.

In master, the field should not be stored
2018-08-28 17:32:56 +02:00
David Beguin 03108f7237 [FIX] mass_mailing : fix unsubscribed page when contact doesn't exist anymore 2018-08-28 17:18:59 +02:00
Florent de Labarre 3b389348be [FIX] stock: move line: lot and product
In the detailed operations view and in an immediate transfer:
    - add a line
    - select a random lot_id
    - select a random product_id
    - validate

The system won't raise while the combination of product_id/lot_id may
not make sense. We add a constraint to solve this isse.

Closes #25766
opw-1868453
2018-08-28 16:34:55 +02:00
Martin Trigaux 9e6e0da06f [FIX] web: accept false value in comparison
momentjs `isSame` method considers undefined values but not false
our method _isSameValue does consider false

Correct the error when running web tests
    Deprecation warning: value provided is not in a recognized ISO format
2018-08-28 16:10:40 +02:00
Martin Trigaux c77789b590 [FIX] web: do not split 'Save & Close' translation
Fixes #26629
2018-08-28 16:06:53 +02:00
eco-odoo 282638653a [IMP] account: reorder bill and invoice form fields
This is an attempt to harmonize vendor bill and customer invoice form fields, specifically the `Other info` tab.
2018-08-28 15:42:05 +02:00
eco-odoo 683085ce06 [IMP] account: update config template to allow easier inheritance
Other modules can now add intrastat settings more easily.

Task: 1869419
2018-08-28 15:42:05 +02:00
eco-odoo f1b2d165fb [IMP] sale: creating an invoice from a sale order now triggers _onchange_partner_id
We need to trigger _onchange_partner_id manually in order to allow computations related to the partner change and to avoid creating bridge modules.
2018-08-28 15:42:05 +02:00
Hetashree Chauhan 6145a71da9 [IMP] stock: add class on validate button
Since it exists two action_validate button (one highlithed and the other
not) depending the situation. This commit add a class on the not
highlited button in order to allow an override.
2018-08-28 15:36:40 +02:00
Hetashree Chauhan 4d1d8d457e [IMP] purchase: create bill button
Before this commit the user add to click on vendor bill
button that redirect him to an empty list view where he has
to click on create. Now, vendor bill show a list view of existing
invoice and it exists a new button create bill that directly create
a new invoice with missing delivered product.

It also order button in order to put primary buttons first in the
header.

The tour is modify since the stat button is invisible if the PO does not
have an invoice linked. Instead it clicks on 'create bill' button.

This commit is related to task ID 1835441.
2018-08-28 15:36:34 +02:00
Darshil Trivedi 19e62fa7c3 [IMP] purchase: clean mail template
Usability change:
- Remove amount from RFQ template
- Remove origin from both templates
- Modify last sentence to a proper English
- Add partner reference in PO template

Technically remove the conidtion on object state in
order to guess if it's a RFQ or a PO since the check
is already made in python and it exists a template
for the RFQ and a template for PO.

This commit is related to task ID 1835441
2018-08-28 15:36:27 +02:00
Darshil Trivedi 6d6009c0e0 [IMP] purchase: settings link to roboto fonts
This commit is related to task ID 1835441
2018-08-28 15:36:20 +02:00