Commit Graph
127612 Commits
Author SHA1 Message Date
jem-odoo 0c28a6387f [FIX] sale_timesheet: too long sql name
The generated SQL constraints name is too long, and so, when raising, it
does not show the defined error message, since Postgresql truncated the
name. thus Odoo can not match the error with the error message.

Task #1883640
2018-09-13 11:43:45 +02:00
jem-odoo 708492b0a1 [FIX] sale_timesheet: add action name
Task #1883640
2018-09-13 11:43:31 +02:00
jem-odoo 11474ac3de [IMP] sale: add form view for sale line
Since in sale_timesheet (and elsewhere), the sale line is link to
some document, the user might click on this field to get more
information.
Unfortunately, he will get an odoo-generated form view, as no one
exists for this model.
This commit provides a basics and beautiful view for SOL, available
for all modules.

Task #1882245
2018-09-13 11:43:24 +02:00
Nicolas Martinelli ad584540d4 [FIX] account: tax account
Use the cash basis account for cash basis taxes.

Follow-up of 1b47575372

opw-1858492
2018-09-13 11:43:12 +02:00
Christophe Simonis a27a24c5ed [MERGE] forward port branch saas-14 up to 7322b7ee56 2018-09-13 11:33:56 +02:00
Christophe Simonis 7322b7ee56 [MERGE] forward port branch 10.0 up to dd20539ffe 2018-09-13 11:32:43 +02:00
Christophe Simonis dd20539ffe [MERGE] forward port branch 9.0 up to cbdb7383e9 2018-09-13 11:07:53 +02:00
Richard Mathot cbdb7383e9 [REV] account: revert 8781286f1c
Causes a traceback "Expected singleton" when opening the Reconciliation
from the accounting dashboard
2018-09-13 11:00:15 +02:00
Christophe Simonis a651e8eed8 [MERGE] forward port branch saas-14 up to 72b2bab8c8 2018-09-13 10:58:54 +02:00
Christophe Simonis 72b2bab8c8 [MERGE] forward port branch 10.0 up to e6ca846c65 2018-09-13 10:54:06 +02:00
qsm-odoo fd8d6cb393 [FIX] website: make theme customization modal multi-faster
Since the recent fixes on multi website, the customization modal
is restored but is a lot slower the first time we use it (around 20sec
to save an option on my machine). This was because when we change an
option, all the others options are sent to the server to be (re-)saved
and, on the first time, the multi-website system has to duplicate them
all to make them website-specific.

Now, we only enable/disable views which are modified by the user.
2018-09-13 10:35:42 +02:00
qsm-odoo 6113a20fa7 [FIX] website: multi-solve multi-website's multi-write
The write method did not work properly for views anymore as soon as it
was called on a multi-records recordset which contains at least one
view which is not website specific. In that case, it used the cow
system for that view (and thus created a specific copy)... but forgot
to continue the write method for the other views, leading to strange
results.
2018-09-13 10:35:42 +02:00
qsm-odoo c8a37b4678 [FIX] website: adapt customize modal to multi-website
The code used the xml_id field instead of the key field at some point,
so the modal was not fetching the proper views.

This commit also removes the useless code in there.
2018-09-13 10:35:42 +02:00
Goffin Simon daa6cea439 [FIX] mrp: Upating the quantity of a MO
Steps to reproduce the bug:

- Create three stockable products P1, P2, P3
- Create a BOM for P1 with P2 and P3 as components
- Create a MO with 5 P1
- Check the availability and plan it
- Go on the WO and process only 3 P1
- Go to the MO and update the quantity to 3

Bug:

From this point, it was impossible to pass the MO to the state= 'done'

With this fix, you can now, click on "Post inventory" and the button
"Mark as Done" will appear.

opw:1874227
2018-09-13 10:03:57 +02:00
Géry Debongnie cd62900878 [IMP] web: add fail fast feature to qunit test suite
With this commit, we introduce a new 'fail fast' feature to our qunit
test suite: when it is activated, the qunit test suite will immediately
stop after the first failed test.

It is accessible as a flag in the url (failfast), or by clicking the
checkbox in the UI. It is currently not activated by default.

Note that this commit also change the url for the runbot phantomjs test
in order to activate this feature.  This allows us to increase the global
timeout for the js test suite without fear!

Backport of 611c836a46
2018-09-13 08:56:08 +02:00
Jeremy Kersten f8dc09f0f2 [FIX] website_sale: fix express checkout flow with extra_step
Before this commit, extra_info was never considered enabled since it was
checking the original view and not the current website view.

By default disabled, when you enable the view, multiwebsite duplicate this
view to enable it for the current website.

+ fix redirect to kanban adress after editing the billing address instead of
the step 'choose your shipping address'

task-1878245
2018-09-13 08:17:09 +02:00
Jeremy Kersten f1e1b6aa8f [IMP] website(_*): typo, margin, missing href, font sizing, ...
Misc fix/imp according FGI request/test

task-1878245
2018-09-13 08:17:09 +02:00
Jeremy Kersten 32a2bca9eb [FIX] website_crm: remove useless thanks message
Informations are duplicate of the right column

task-1878245
2018-09-13 08:17:09 +02:00
Jeremy Kersten 9ea4e85e69 [FIX] website: add welcome message on new bootstrapped homepage.
Before this commit, when you create a new website, the home page was empty

task-1878245
2018-09-13 08:17:09 +02:00
Jeremy Kersten 57decbbed6 [FIX] web_editor: fix and improve AltDialog
Ref label
Add tooltip
Fix title from modal -> before this commit, modal title was wrongly replaced by title of image :/

task-1878245
2018-09-13 08:17:09 +02:00
Jeremy Kersten 4abfa435ea [FIX] portal, website: label in bold by default similary to bootstrap 3
In bootstrap 3, label was in bold by default. And we use label-optional to make label normal.
Update sass to have same behaviour:

required field in bold
other fields in normal

task-1878245
2018-09-13 08:17:09 +02:00
Joren Van Onder c8371261dc [FIX] l10n_co: commercial_partner_country_id no longer exists
Removed by b341b5ca73. This function
copied the check_vat constrains decorator before that commit. Instead
replace with country_id because the l10n_co check_vat function still
uses that field.
2018-09-12 20:14:56 -07:00
Christophe Simonis 5e4fdaf731 [FIX] mail: correct SyntaxError
Oversight of previous forward-port
2018-09-12 20:04:41 +02:00
len-odoo 83292e522a [FIX] doc: add documentation for widget formatter support in pivot view
Commit:
https://github.com/odoo/odoo/commit/8c1204954ef571e51e94ddf4070043ec2d5de3c6
put back support in v11 for formatter widgets in pivot views.
We document this feature.

opw 1876445
2018-09-12 19:46:40 +02:00
Christophe Simonis b1999a0e87 [MERGE] forward port branch 11.0 up to db0e84f3e3 2018-09-12 19:37:17 +02:00
Christophe Simonis d76cd50f0e [FIX] base: avoid generating invalid user group view
When no `base.module_category_user_type` Application is found, the group
view was generated with the domain `[('', '!=', <int>)]`, which is will
fail view validation.

This situation happen during database migration or if the module category
is deleted.
2018-09-12 19:05:29 +02:00
qsm-odoo 4a7623fec1 [FIX] portal, website: allow to use wide brand logo
When the user chose a very wide logo for the website navbar, it
overflew over the menu items (making the "+" feature look broken).
This in fact occurs since commit https://github.com/odoo/odoo/commit/4bc79da943c71e762e1f6dedbe3a641042bfef3f.
Its goal was to avoid top menu flickering due to that "+" button
feature. To do that, menu items were hidden with an height of 0 during
loading, then, once the correct number of items needed for the "+"
feature was computed, they were made visible to the user. Another
problem was due to the logo image loading. When it is not loaded yet, we
cannot properly compute the number of items which is needed. To solve
that problem, we fixed the size of the image container instead of
setting the height of the image itself.

But fixing the size of the image container only created a new bug: very
wide logos overflow this container. This commit solves all the problems:

1) The height of the image is set to be equal to the navbar links.
2) The height of the navbar is not forced, meaning that if the user
   decides to change the height of its logo to go against (1),
   everything will be adapted accordingly.
3) During loading, the menu items are still 0px tall, hidden and made
   visible once the "+" feature is enabled.
4) The "+" feature is only enabled once all the navbar images have been
   successfully loaded.

task-1878245
2018-09-12 17:54:42 +02:00
Nicolas Lempereur db0e84f3e3 [FIX] web: revert ignore default_* on group creation
This reverts commit 4cb585ab4f.

When creating from the kanban view:
- crm.stage
- hr.recruitment.stage
- project.task.type
- helpdesk.type
- mrp.eco.stage

We go from a dashboard of eg. "GroupRecord" named "group_id" in the
record. And when a stage is created, "default_group_id" is used. With
the change the stage was not linked to the current "grouping".

We could probably use "search_default_group_id" instead but the behavior
may be present in existing customization.

opw-1884217
closes #26943
2018-09-12 17:43:39 +02:00
Jeremy Kersten e6ca846c65 [FIX] base_geolocalize, website_crm_partner_assign: API keys are now required
Google Important Updated: API keys are now required
We began enforcing the use of API keys, effective June 11th 2018.
Keyless usage will result in a degraded experience, or an error.

https://developers.google.com/maps/billing/important-updates
2018-09-12 17:07:23 +02:00
Mathieu Duckerts-Antoine 4cbc9b8d61 [FIX] account: translate default overdue_msg
opw-1880132

Closes #26852
2018-09-12 16:52:29 +02:00
Frederik Kramer 60c9742dfb [CLA] backport signature for initos
This is a backport of 5a53e5b8e9 as requested at #26638
Added Florian Kantelberg to our team of contributors
2018-09-12 16:25:04 +02:00
Christophe Simonis 87b3ca13bf [FIX] stock: correct tests to create pickings without using new() 2018-09-12 16:15:04 +02:00
GabbasovDinar e82a9ae0e1 [IMP] point_of_sale: better merge detection
If sells
1. product A
2. product B
3. product A

the lines of product A were not merged

Closes #25540

closes odoo/odoo#26602
2018-09-12 13:52:55 +00:00
GabbasovDinar 9e0906b3ed [IMP] point_of_sale: display pricelist button only if enabled
If the option use_pricelist is disabled, no need to display the button

Closes #25540
2018-09-12 13:55:50 +00:00
Robot Odoo 993860e465 [pos] master fixes
Trying a two commits PR to challenge a bit @robodoo

closes odoo/odoo#26915
2018-09-13 13:18:55 +02:00
Martin Trigaux 6dacb3269d [IMP] point_of_sale: check constraint at session creation
The constraints could be bypassed if a user set a jourmal/account/location to
the pos.config and, then, modifies the location configuration.

Checking the value of current_session_id makes sure the constraints is triggered
also when the session is created.

Prevents workarounds such as explained at #26641
2018-09-13 09:49:35 +00:00
Martin Trigaux 6caeed1fd7 [REF] point_of_sale: clean dead code 2018-09-13 07:28:12 +00:00
Raphael Collet cd6e9ab4fb [FIX] mail: _compute_need_moderation() 2018-09-12 15:15:10 +02:00
Wolfgang Taferner 8e15dc87a4 [IMP] account: extract_payment_vals + explicit communication hand-over 2018-09-12 15:12:42 +02:00
Alexandre Kühn 611b42409e [FIX] mail: filter messages in thread (Discuss)
Revision on https://github.com/odoo/odoo/commit/ec8c505bc1c9ec21939e9ffef53a9cc6f63f30c7

The commit above changes the way threads are rendered: the template
now uses a thread object, instead of a list of messages.

However, it was not handling messages that have been filtered from
the searchview. As a result, it was not possible to filter messages
at all.

This commit re-adds the possibility to filter messages, by providing
information on the domain of the thread in the template.

Task-ID 1877502
2018-09-12 15:02:22 +02:00
Alexandre Kühn 3b76886f9a [FIX] mail: toggle show/hide search options in discuss
Before this commit, the search option buttons were not
hidden when clicking on the zoom-in/zoom-out button next
to the searchview.

This is due to updating the control panel with the list
of buttons as the searchview buttons, instead of the
container. Since the visibility of the searchview buttons
is defined on the container, the toggler button and the
search view options lost synchronization.

This commit fixes the issue by providing the container
that is shared between search option buttons.

Task-ID 1877502
2018-09-12 15:02:22 +02:00
Alexandre Kühn 4ee7a009f7 [FIX] im_livechat, mail: any thread window has an ID
Before this commit, only thread windows in the backend had the
method `getID`. However, it should also be the case for the thread
windows in the frontend (website livechat), as the template of any
thread window makes use of this method.
2018-09-12 15:02:22 +02:00
Alexandre Kühn 5b4aebb441 [FIX] im_livechat: correctly display livechat statistics
Layout broke from bootstrap 4 migration.

Task-ID 1878249
2018-09-12 15:02:22 +02:00
Alexandre Kühn 6a9a20d025 [REF] mail, im_livechat: clean typos 2018-09-12 15:02:22 +02:00
Alexandre Kühn d52864569d [IMP] mail: bigger emoji size in the composer selection
The emojis were too small, thus hard to read.

Task-ID 1882595
2018-09-12 15:02:22 +02:00
Aaron Bohy 18bd4fa749 [FIX] web: remove race condition at webclient startup
Before this rev., there was a race condition making some tours
randomly fail on runbot, when the following steps occurred in that
order:
  - load webclient
  - as soon as the menu is ready and visible, click on a root menu
    which thus leads to a doAction
  - in the meantime, an RPC is done by the webclient to retrieve
    the (optional) default action of the user (if there is no
    state in the url, which is the case for tours in general)
  - when that RPC returns, this action (if any), or the action of
    the first menu is executed, thus leading to a second doAction
  - the ActionManager using a DropPrevious, the first doAction is
    dropped and thus the action linked to the clicked menu is
    never shown, making the tour fail

This rev. uses the state of the ActionManager's DropPrevious to
prevent the default action from being executed if another action
is already being executed, thus removing that race condition.

Note that this fix is temporary, as the community webclient is
currently being refactored.
2018-09-12 13:30:24 +02:00
Nicolas Lempereur 8e77632e58 [FIX] *mail_thread: don't modify modified help
The 'help' of window action is often fiddled with, adding thing before,
after or arround it.

For example in CRM leads, we add at the beginning "Click to add a new
opportunity" with an arrow towards the button, and after if there is a
mail alias: "All email incoming to * will automatically create new...".

But for crm.lead, hr.expense, sale.order this would not take into
account that the fiddled "help" can be edited, so if we edit 2 times
help in studio or backend action editing, we would get:

  Click to add a new opportunity
  Click to add a new opportunity
  Click to add a new opportunity
  [Original help content]
  All email incoming to * will automatically create new...
  All email incoming to * will automatically create new...
  All email incoming to * will automatically create new...

And see several "arrows" towards the button (in enterprise the
additional ones are on same color background).

With this commit we do what is done in "mail.thread" by default which is
not fiddling with the `help` if has been fiddled before (if it contains
"oe_view_nocontent_create" class).

note: this is the 11.0 version of #26912

opw-1877663
closes #26911
2018-09-12 13:18:35 +02:00
svs-odoo f339ed6ff6 [FIX] web: avoid annoying xdg-open prompt
Due to the route beginning with 'test: ', it was interpreted like a
protocol and on some OS (ubuntu for example), a xdg-open prompt pops up.
So, the window looses focus and some tests will fail because of that.
2018-09-12 13:17:54 +02:00
Nicolas Lempereur 72d7dd8994 [FIX] *mail_thread: don't modify modified help
The 'help' of window action is often fiddled with, adding thing before,
after or arround it.

For example in CRM leads, we add at the beginning "Click to add a new
opportunity" with an arrow towards the button, and after if there is a
mail alias: "All email incoming to * will automatically create new...".

But for crm.lead, hr.expense, sale.order this would not take into
account that the fiddled "help" can be edited, so if we edit 2 times
help in studio or backend action editing, we would get:

  Click to add a new opportunity
  Click to add a new opportunity
  Click to add a new opportunity
  [Original help content]
  All email incoming to * will automatically create new...
  All email incoming to * will automatically create new...
  All email incoming to * will automatically create new...

And see several "arrows" towards the button (in enterprise the
additional ones are on same color background).

With this commit we do what is done in "mail.thread" by default which is
not fiddling with the `help` if has been fiddled before (if it contains
"oe_view_nocontent_create" class).

note: for 10.0 up to not including 11.0 which is fixed by #26911

opw-1877663
closes #26912
2018-09-12 13:11:21 +02:00
Antony Lesuisse 0abae675e8 [FIX] base: improve rtlcss warning message with instructions 2018-09-12 13:04:21 +02:00