Commit Graph
127612 Commits
Author SHA1 Message Date
Robot Odoo 3219171bab [IMP] doc: improve delegation docs example
The model inheritance concept was explained with abstract example which is
often confusing.

Change to a real world example that will be better understood.

closes odoo/odoo#27396
2018-10-30 17:58:38 +01:00
Yenthe V.G 64c47cdbd6 [IMP] lunch: add sheet and group names to form views
closes odoo/odoo#27343
2018-10-30 16:13:48 +00:00
Bruno Paulino 9e7d6a3e7e [IMP] doc: add a more meaningful example
update Model Inheritance Delegation docs with a more meaningful example
2018-10-30 16:09:21 +00:00
Bruno Paulino 72cc07aae2 [CLA] signature for Bruno Paulino 2018-10-30 16:09:21 +00:00
Raphael Collet 650074e8b2 [IMP] fields: faster x2many fields
Perform all operations in batch, except for updates (command (1, id, vals)).

closes odoo/odoo#28029
2018-10-30 15:08:02 +00:00
jem-odoo 3e3d6c3ce0 [REF] purchase_*: change received qty api
The received quantity on Purchase Order line can be compared
to the delivered qty on Sales Order line. It is now time for
both to share the same mecanism (introduced in
3bf8a62e0d).

This commit sets `qty_received` as a computed field, depending
of a method (`qty_received_method` field) to compute it. The
value can be computed based on
 - manual value; for services (all the time), and consummable
 products (when stock is not installed).
 - stock moves; for stockable and consummable products (when
 stock is installed)

This is now easier to extend the way the received quantity
need to be computed (like in sale).

Task #1850689

closes odoo/odoo#27663
2018-10-30 12:43:53 +00:00
Yenthe V.G 7c1ae0cf49 [IMP] hr_recruitment: add missing sheet to form views
closes odoo/odoo#27341
2018-10-30 13:20:55 +00:00
Yenthe V.G dfbc85cae0 [IMP] account_analytic_default: add sheet to analytic defaults form view
closes odoo/odoo#27349
2018-10-30 11:08:18 +00:00
Yenthe V.G 2f4ca47c43 [IMP] account: add missing sheet to account group form view
closes odoo/odoo#27346
2018-10-30 10:54:08 +00:00
eLBati 95cda104e6 [FIX] digest: resolve unmet dependency on resource module
This commit fixes the following bug:
* On a new DB, install account
* Settings > Technical > Email > Digest emails
* Open Weekly Digest, set Next Send Date to current day
* Settings > Technical > Scheduled Actions > Digest Emails
* Run manually

AttributeError: 'res.company' object has no attribute
'resource_calendar_id'

The field resource_calendar_id is provided by the module resource

closes odoo/odoo#28239
2018-10-29 14:33:17 +00:00
Yannick Tivisseandblaggacao 49fa9973b0 [IMP] hr_holidays: Add leave code for payslips
Purpose
=======

Before this commit, it was not straightforward to use leave records in salary
rules programatically.

This commit implements the standard and python-code compatible way of defining
leave codes which then can be used in the salary rules in the used way.

This way, the naming of leaves will not be restricted to python-attribute
compatible naming, when one wants to use this feature.

Leave names (translatable) are an unreliable identification in python code salary rules.
A language switch would break python salary rules that use a leave type as input

TaskID: 1903964
Closes #28240

Co-authored-by: blaggacao <david@elaleman.co>
2018-10-29 10:52:41 +00:00
Robot Odoo 45c2c3761d [MERGE] utm, link_tracker, mass_mailing: improve views usability and lint module
Purpose of this merge is to clean a bit link_tracker and utm as well as their
use in mass mailing. Main things done in this merge are

  * reorganize link_tracker and utm according to guidelines. Purpose is
    to ease code understanding and prepare future improvements in those
    modules;
  * clean views, add missing fields in views;
  * better integration of link menus and views in mass mailing;

This commit is related to task ID 1896681.

closes odoo/odoo#27975
2018-10-29 13:09:17 +01:00
Robot Odoo d9c1cd4256 [IMP] hr_payroll: Refactor methods and improve performances
Purpose
=======

Some parts of the code are quite old-api-style and could be modified to use recordsets and thus improve performances.

closes odoo/odoo#28182
2018-10-29 12:08:19 +01:00
Thibault Delavallée a758d517d8 [IMP] mass_mailing: better link tracker action redirection for mass mailing
Purpose is to ease use of mass mailing by improving the action linking to
statistics. Form / graph view is added as well as informations related
to mass mailing and campaign.

This commit is linked to task ID 1896681 and PR #27975.
2018-10-29 10:19:53 +00:00
Yannick Tivisse f37a40d74e [IMP] hr_payroll: Modify _get_payslip_lines to use recordsets 2018-10-29 10:09:59 +00:00
Yannick Tivisse e52c407b6e [IMP] hr_payroll: Refactor structures methods to use recordsets 2018-10-29 09:29:52 +00:00
Yannick Tivisse 225708a58f [IMP] hr_payroll: Move the BrowsableObject classes into a separated file
Purpose
=======

These classes are utils classes for the payslip computation.

It's better for the code readability to isolate them into a single file,
and keep the business logic into the payslip model code.
2018-10-29 09:29:52 +00:00
Yannick Tivisse 4d3db78d7f [IMP] hr_payroll: Remove useless method 2018-10-29 09:29:52 +00:00
Yannick Tivisse b1449d24a3 [IMP] hr_payroll: Move get_contract method to hr_contract module
Purpose
=======

This method has nothing to do on the payslip model.

Specification
=============

Move the method on the hr_contract module, on the hr.employee model.

Rename the method and return and recordset instead of a list of ids.
2018-10-29 09:29:52 +00:00
qsm-odoo 1f37ec3b0b [REF] account, hr_org_chart: use correct sub-assets
Some variables were placed at the beginning of the backend helper.
While it was working, the normal convention is to place them at the
end of the variables helper.

closes odoo/odoo#28203
2018-10-26 14:13:41 +00:00
Thibault Delavallée 510bad0df3 [REF] link_tracker: clean module views
Purpose is
 * to clean a bit views;
 * to improve link.tracker form view to have information better displayed;
 * to remove unused views;

This commit is linked to task ID 1896681 and PR #27975.
2018-10-26 12:42:49 +00:00
Thibault Delavallée 37fcb1e6ff [REF] link_tracker: reorganize python according to guidelines
This was not correctly done when splitting the module at fd5361c0f7.
Future commits will clean a bit the code in order to better understand how
this module works.

This commit is linked to task ID 1896681 and PR #27975. No functional change
should occur with this commit as it contains only renaming / move.
2018-10-26 12:42:49 +00:00
Thibault Delavallée ae2866a11e [MOV] link_tracker: organize module structure according to guidelines
This module still holds old code and deserves some love. This commit cleans a
bit the init and manifest files as well as renaming view file according to
guidelines.

This commit is linked to task ID 1896681 and PR #27975. No functional change
should occur with this commit as it contains only renaming / move.
2018-10-26 12:42:49 +00:00
Thibault Delavallée 89d50fc3b1 [REF] utm: clean and lint views
Purpose is to give a quick polish to this module code concerning views.
Some ids are updated, indentation is fixed.

This commit is linked to task ID 1896681 and PR #27975.
2018-10-26 12:42:49 +00:00
Thibault Delavallée 65f9840fd2 [MOV] utm: organize module structure according to guidelines
This module holds old code and is still not updated according to guidelines.
Let us update a bit the naming in this module to have readable code.

This commit is linked to task ID 1896681 and PR #27975. No functional change
should occur with this commit as it contains only renaming / move.
2018-10-26 12:42:49 +00:00
Cas Vissers ca52c6c3a0 [FIX] base_vat_autocomplete: add missing attrs
VAT number should be readonly when parent_id is set
This is already what is done in base.view_partner_form and
base.view_partner_short_form
2018-10-26 12:09:12 +00:00
Cas Vissers cff3ed4ae3 [CLA] signature for Brahoo
Backport to 11.0 of #28161
2018-10-26 12:07:11 +00:00
qsm-odoo cd580dd605 [FIX] web_editor: fix forward-port
Forward-port of https://github.com/odoo/odoo/commit/227fc6408ddc998529bb1c38222ddba50f40868b
made with https://github.com/odoo/odoo/commit/717f4583949219c346c87c390fbc336b4f31571c
introduced a JS error.

closes odoo/odoo#28187
2018-10-26 09:44:13 +00:00
Olivier Colson ac08e2ba53 [FIX] mail: display both tracking values and body of the messages in mail thread
Before that, the body of the message was never displayed if the message had tracking values. This was annoying for account_asset module, were we prompt the user for some justification when she modifies the depreciation data of an asset, and then call message_post with this text as body, and tracking values reflecting the change that was made.
2018-10-26 11:37:52 +02:00
Julien (juc) Castiaux c5dc0b2f39 [FIX] mail: spam the send button create multiple messages
Spamming the "send" button on the chatter send multiple times the
same message. This PR simply disable the send button to fordib the
spam.

opw-1895511

closes #27233

closes odoo/odoo#28078
2018-10-26 09:29:57 +00:00
Goffin Simon bb939ffac0 (FIX] account: Impossible to make a partial credit note
Steps to reproduce the bug:

- Create a credit note for an amount of 100$
- Validate it and register a payment
- Let's pay an amount of 90$ and mark this credit note as fully paid

Bug:

An error message was raised saying: Wrong credit or debit value in accounting entry !

The field residual_company_signed must be positive for out_invoice and in_refund and
negative for in_invoice and out_refund. In this way, the correct writeoff amount
can be computed in function _create_payment_entry.

PS: In function _compute_payment_amount, the field residual_signed and residual_company_signed
are already signed, that's why it was wrong to multiply a second time on it with MAP_INVOICE_TYPE_PAYMENT_SIGN

opw:1893570

closes odoo/odoo#28148
2018-10-29 07:09:15 +00:00
Odoo Translation Bot 19d8adbce1 [I18N] Update translation terms from Transifex 2018-10-28 03:21:03 +01:00
qsm-odoo 8c756a32a0 [REF] website: review theme dialog engine
Refactor the code to remove useless parts, simplify behaviors and allow
more customizations in future tasks.

closes odoo/odoo#28167
2018-10-26 09:29:53 +00:00
Christophe Monniez 07b855fccf [FIX] tests: remove chrome sandboxing
It appears that chrome headless with sandboxing is failing when running
containerized because it tries to use Linux namespaces.

With this commit, the no-sanbox optional arg is used to avoid this
issue.

Closes #26456
Closes #28053
2018-10-26 11:26:18 +02:00
Yannick Vaucher e968d1de7e [FIX] web: typo in docstring
The parameter would not be correctly detected by doc extractors

closes odoo/odoo#28169
2018-10-26 07:56:50 +00:00
David Arnold 1bf58d282f [IMP] db: set default user tz through country code
Given a country code is specified and the country only has one timezone, it is
safe to assume that the admin user is operating from that timezone.

Set the default timezone to simplify the onboarding in such particular case.

If a country has more than one timezone, we can not make safe assumptions and
don't provide a default tz.

closes odoo/odoo#26365
2018-10-26 07:21:47 +00:00
Robot Odoo 653b4289c6 [MERGE][FIX] purchase: include refunds in invoice count
If a supplier had a refund, it was not included in the supplier invoice count
nor in the results in the statbutton

On the customer side, fields like total_invoiced works on both the out_invoice
and out_refund

closes odoo/odoo#28161
2018-10-26 09:21:05 +02:00
Olivier Colson e6228402e7 [FIX] purchase: fix anglosaxon valuation
Before that, when receiving, then invoicing with price diff, the value in interim account corresponded to the price on the invoice instead of the original valuation one.

Scenario to reproduce the issue:

* create PO with 1 product, FIFO valuation, price=10
* receive PO: the entry in stock interim account has debit=credit=10
* create invoice, with price=15 instead of 10
* the invoice entry should be: payable: C=15 ; price diff: D=5 ; interim account: D=10
  ==> Instead, we had payable: C=20 ; price diff: D=5 ; interim account: D=15 => this was wrong

Also added a test case for the same scenario, verifying the amounts written in the different accounts (and refactored a bit ValuationReconciliationTestCase for easiness)

Closes #27394
2018-10-25 18:03:27 +02:00
Christophe Simonis 78d5941d50 [MERGE] forward port branch 11.0 up to aace8470b8e 2018-10-25 17:44:56 +02:00
Christophe Monniez f9ee8cff14 [FIX] tests: avoid remaining requests
From times to times, warning are seen on the runbot during HttpCase
tests with the chrome headless browser.

Those warning are about Odoo trying to join remaining requests threads.
In the dumpstack, the thread seems blocked in the werkzeug
handle_one_request method, when trying to read the HTTP request line.

One explanation could be that Chrome opens a pre-connect socket for
a future use. When the HttpTest cleans the browser, the page stops
loading but (probably) keeps the socket open for a while.

That could explain the problem.

With this commit, a timeout is set on the request handler,
in the hope that it closes the pre-connect socket too.
2018-10-25 17:16:34 +02:00
Cas Vissers 43edf08b26 [FIX] purchase: include refunds in invoice count
If a supplier had a refund, it was not included in the supplier invoice count
nor in the results in the statbutton

On the customer side, fields like total_invoiced works on both the out_invoice
and out_refund
2018-10-25 14:41:14 +00:00
Cas Vissers 3f6deb24ee [CLA] Brahoo signs Odoo CCLA 2018-10-25 14:39:21 +00:00
Josse Colpaert 9647620a91 [FIX] mrp: workorders of sub-BOMs
- Create the following BOM structure:
```
  Prod 1 (Manufacture)
  |
  --- Prod 2
      Prod 3 (Kit)
      |
      --- Prod 4
	  Prod 5
```
- The BOMs for Prod 1 & 3 must have a routing set, to generate
  workorders
- Create a MO for 1 unit of Prod 1, process to the end

2 units of Prod 1 are created instead of 1.

This is due to the WO for Prod 3 not having a `next_work_order_id`.
Therefore, `record_production` adds an extra quantity at:
```
production_move.quantity_done += self.qty_producing
```

To prevent this, we set as `next_work_order_id` of the BOM of Prod 3 the
WO of Prod 1.

Closes #19527
opw-1817398
opw-1883693
2018-10-25 14:58:43 +02:00
Nicolas Martinelli 7718811809 [FIX] mrp: unbuild of tracked products
- Create 2 Products A and B, tracked by serial number
- Create a BOM for A:
  1 Unit of B
- Create a MO for 2 Units of A
- Validate:
  Product with S/N A1 consumes B1
  Product with S/N A2 consumes B2
- Unbuild A2

If A1 was created before A2, B1 will used as a component of A2 at
unbuild.

When going through the stock move lines, we don't verify that the lot
produced matches the lot we unbuild.

opw-1889002

closes odoo/odoo#28154
2018-10-25 12:25:45 +00:00
Christophe Simonis cc8e8237bf [MERGE] forward port branch 11.0 up to 84500c27b1 2018-10-25 13:59:45 +02:00
Gert Pellin 299c6dd3b4 [FIX] point_of_sale: alignment note textarea
before fix:
in firefox the textarea of note modal has a overflow
textarea can be expanded outside borders modal in all browsers

closes #25199
closes #25215

issue 1895298
2018-10-25 13:22:02 +02:00
Martin Trigaux bfbaa09268 [FIX] hr_attendance: allow multiple attendances
If the search returns more than one result, the rendering of the message would
crash (SingletonError when accessing check_in field value).

Use the same order and limit as both search before and after

Courtesy of David Tran

Closes odoo/odoo#28055
2018-10-25 11:49:15 +02:00
Gert Pellin 8e63bcb47c [FIX] point_of_sale: IoT https in pos
before this fix it was not possible to connect to the pos/iot-box using
https on the pos. By checking if the pos is http or https this is now
possible after accepting the certificate.
if https scanning for proxy is disabled, the user should always give a
    ip in the configuration
2018-10-25 11:33:32 +02:00
jem-odoo 3baf8c41e9 [FIX] website_sale: change invoice_policy of a demo data
Otherwise, the product is a service based on delivered
quantity which is not a covered case by the service_policy
field on product form view (the selection will be empty).

Asked in Task-1859308

closes odoo/odoo#28162
2018-10-25 09:28:51 +00:00
xmo-odoo 84500c27b1 [P3] payment_stripe: Exception.message removed
Apparently missed in 07ab8b6cd2

In Python 3, there is no Exception.message attribute anymore, this would
lead to cascading exceptions in the stripe_s2s_create handler.

closes odoo/odoo#28141
2018-10-25 09:13:17 +00:00