Commit Graph
127612 Commits
Author SHA1 Message Date
Yenthe V.G 201bd9101d [IMP] base: Add sheet of several basic form views
Add <sheet> tag on the form view for the following models:
- res.bank
- res.country
- res.country.group
- res.country.state
- res.partner.title
- res.partner.category
- res.partner.industry

[IMP] base: add sheet to countries form and add group names for clean xpaths

[IMP] base: add sheet to contact tags form

[IMP] base: add sheet to parter title form

[IMP] base: add sheet in sectors of activity form

[IMP] base: add sheet to federal states form

[IMP] base: add sheet to country group form

[IMP] base: add sheet to bank view and add group names for cleaner xpaths

closes odoo/odoo#27324
2018-11-22 10:47:08 +00:00
Yenthe666 78182af799 [IMP] resource: allow easy xpath on forms
closes odoo/odoo#29817
2018-12-31 14:17:34 +00:00
Andrea 59289eda05 [FIX] link_tracker: _sql_constraints not applied
The unicity was not applied

closes odoo/odoo#29793
2018-12-31 09:16:39 +00:00
Yenthe666 7ca17c402f [FIX] website_forum: fix typos in goal definitions
closes odoo/odoo#29819
2018-12-29 19:26:02 +00:00
Yenthe666 1341877ec9 [FIX] account_test: fix typo in report
closes odoo/odoo#29795
2018-12-28 15:05:37 +00:00
David Tran 784d3cbbcf [IMP] point_of_sale: more convenient in refund extending and inheritance
When creating refund order, Odoo copies the original order and put
some default copy data. All these things were put in the same method
which causes problems for extensions.

This commit split the refund method into multiple dedicated methods so
that others can modify/inject more data easily

closes odoo/odoo#29792
2018-12-28 14:47:01 +00:00
Yenthe V.G 123a77c160 [IMP] analytic: add sheet to form view
For a better rendering

closes odoo/odoo#27345
2018-12-28 15:20:58 +00:00
lul-odoo 68ba96760f [IMP] hr_recruitment: Add application history for same applicant
Purpose
=======

HR users wants to know if an applicant applied to multiple jobs
or if he applied in the past.

Specification
=============

Keep an history of applications based on email.
Add a stat button on the applicant form to display
other applications with the same email.

closes odoo/odoo#29613
2018-12-28 13:21:22 +00:00
Yenthe V.G d4e3b57c76 [IMP] mail: add group names for clean xpath expressions
closes odoo/odoo#27342
2018-12-28 13:03:53 +00:00
sed-odoo ea5c10a11c [IMP] base: Add a new 'Approvals' module category
Will be used in a new module in the enterprise repository

closes odoo/odoo#29384
2018-12-28 10:58:50 +00:00
sed-odoo fd1c610839 [IMP] mail: Pass the session uid on activity renderer
Purpose
=======

We could want to retrieve the session user id when rendering the next
activities on the chatter (For example in the new approvals module on the
enterprise repository).

At the same time, we used 'web.session' to retrieve this valued instead
of 'self.getSession().uid' which is deprecated.
2018-12-28 10:58:50 +00:00
sed-odoo df43defe84 [IMP] mail: Modify activity templates to ease inheritance
These templates are supposed to be modified by a new approvals application
in the enterprise repository.
2018-12-28 10:58:50 +00:00
Cas Vissers e502423f2b [FIX] resource: Rename 'Evening' into 'Afternoon' in default attendances
Evening is not the common way to describe the second shift of the day.

Closes #28253

Co-authored-by: Cas Vissers <c.vissers@brahoo.nl>

closes odoo/odoo#28950
2018-12-27 13:21:36 +00:00
qsm-odoo 52ec536cef [REF] *: make stronger bootstrap assets
* portal, theme_bootswatch, web, web_editor, website

With less2sass and bs3tobs4 tasks, the assets structure was reviewed to
handle the specificities of both framework and to prepare for our next
odoo tasks. In particular, the assets_helpers and bootstrap overrides
were basically split into 4 parts: utils, primary variables, secondary
variables and bootstrap variables.
(see https://github.com/odoo/odoo/commit/6e4db7d13a926845bf82f5b035afede42d6d5a89)

Using the !default system for the bootstrap variables parts seems now
a good improvement. This is part of what this commit does: adding the
default flag for all bootstrap variables overrides and inverting the
order of the files in the _assets_backend_helpers and
_assets_frontend_helpers templates. This allows to avoid code like this:

portal:
```
$body-bg: white;
```

website:
```
@​if $var != null {
    $body-bg: $var;
}
```

This code makes the body white with portal or equal to $var with website
if $var has a value. The same behavior in the new file order is achieved
with:

website:
```
$body-bg: $var !default;
```

portal:
```
$body-bg: white !default;
```

This order is now also followed for the _assets_secondary_variables
templates (there are only a few).

This commit also make better assets hierarchy by making website inherit
from portal assets (instead of web) and portal inherit from web_editor
assets (instead of web) (thus relying on strong dependencies instead of
installation order which is not always right for migrated databases).

closes odoo/odoo#29757
2018-12-26 17:25:23 +00:00
Denis Ledoux ec48392e39 [TODO] service/server: note to remove override that will become useless
The method override `_handle_request_noblock`
is there to solve a bug in Python socketserver library
which has been solved in
- Python 3.6: python/cpython@8b1f52b5a9,
- Python 3.7: python/cpython@9080824513,

through PR python/cpython#9952.

These revisions will be included in Python releases 3.6.8 and 3.7.2,
and the override will then become useless.
We therefore can remove the `_handle_request_noblock` override
as soon as the Python 3 releases installed on operating systems
supported by Odoo are above
- 3.6.8 for Python 3.6
- 3.7.2 for Python 3.7

closes odoo/odoo#29706
2018-12-21 11:27:44 +00:00
Florent de Labarre e0d1fd7ec7 [IMP] base: allow to group modules by state
To easily identify the one installed or in error state

closes odoo/odoo#28938
2018-12-20 15:11:10 +00:00
Yannick Tivisse 89b12e9857 [IMP] hr_payroll_account: Remove unused field
This field seems to be never used.

closes odoo/odoo#28737
2018-11-15 15:20:19 +00:00
Aaron Bohy 4df0a1e31a [FIX] web: wrong tests
This commit fixes two tests that became meaningless after tweaks
in production code:

 - form_tests: use two char fields, as integer fields can't be
   unset since rev. c62a4edcb
 - pivot_tests: the button is disabled since rev. 4f4f111, but
   simulating a click with jQuery bypasses the disabled attribute

This commit also removes unecessary overrides of mockRPC. Those
overrides existed  because the attachments part of the sidebar
used to make a search_read RPC, but this has been removed at rev.
1dbb555.

closes odoo/odoo#28650
2018-11-13 19:56:55 +00:00
Lucas Perais (lpe) 7525455534 [WIP] looking good babe 2018-11-13 16:40:30 +00:00
Wolfgang Taferner 0246887f7b [FIX] account: wrong default journal based on type available in vals
As the journal is mostly set in the Odoo world the _default_journal
method is not needed during create, but in case you only have
partner_id, account_id and type in vals you will have retrieved a wrong
journal in case you have an incoming invoice.

closes odoo/odoo#28635
2018-11-13 16:20:42 +00:00
Florent de Labarre 4e37ce8855 [FIX] project: remove unused field
If `description` contains an image, the loading time of the kanban view
can be rather long. Since the field is not even used in the view, it can
be removed.

opw-1915193

closes odoo/odoo#29034
2018-12-05 08:33:36 +00:00
Goffin Simon 3c8b57dc53 [FIX] sale_stock, stock: Wrong dependency
The field sale_id on model stock.picking is not defined in stock module.
So the rule was wrong when sale_stock was uninstalled.

opw:1912564

closes odoo/odoo#29145
2018-12-04 14:07:56 +00:00
qdp-odoo 069c2f2304 [FIX] account: fix invoice access rights
removed the access right that was granting the read access on invoices to any internal user, because there's no reason to do so.

Fixes #28486
2018-11-13 17:18:43 +01:00
Arnold Moyaux a172166a8b [FIX] purchase_stock: merge po by default
Usecase to reproduce:
- Create a product with a vendor and mto/buy route checked.
- Create 2 SO and confirm them

The system generated 2 RDF instead of a single with 2po lines (same than
v11). It happens because the propagation option of buy rules is
leave empty in v11 and Propagate in v12. It was unintentionally removed
by commit 1e160dffd3

This commit set leave empty as default value for buy rules.

opw-1904165

closes odoo/odoo#28637
2018-11-13 14:22:51 +00:00
Nathan de Pryck 3af06bf47c [FIX] stock_account: view priority
In some case, this view was used to perform a search of product.product.
Before, this modificiation all the search view had the same priority
which means that depending on some situation, the wrong search view was
loaded.

opw-1903611

closes odoo/odoo#28634
2018-11-14 09:35:26 +00:00
len-odoo 93c6d22e01 [FIX] sale_timesheet: fix incoherent demo data
The uom unit of a product on a sale order line was not with the product uom.
As a result, an error would be triggered when trying to edit the SO, without the
possibility to fix it (as the field is not in the view).
Odoo takes a stand against incorrect demo data.

opw 1906315

closes odoo/odoo#28641
2018-11-13 15:11:40 +00:00
Goffin Simon 51982f9199 [FIX] website: Impossible to link an analytic account
Steps to reproduce the bug:

- Go to Website > Dashboard > Analytics and click on "Link my analytics account"
- Enter some data and save

Bug:

A traceback was raised: TypeError: website_set_ga_data() missing 1 required
positional argument: 'website_id'

opw:1905874

closes odoo/odoo#28636
2018-11-13 16:12:47 +00:00
Lucas Perais (lpe) c70bdd0e4e [FIX] account: do not check for company logo when printing reports
Have a company that do not have a logo.

Try to print a "PDF report" from the accounting module

Before this commit, the simple company form popped up
with the purpose of force setting a company logo

After this commit, we assume it is not necessary to have a company logo on the reports

Note, because of 733ce266ef, we cannot do a save and print

OPW 1904764

closes odoo/odoo#28617
2018-11-13 11:15:24 +00:00
Sanjay Jamod 8f99013d01 [FIX] website: method should be called with action not with self
to avoid 'Expected singleton error'

OPW: 1909205

closes odoo/odoo#28648
2018-11-14 06:32:40 +00:00
lul-odoo 21976ca838 [FIX] base: Fix rng for 'templates' tag in calendar view
The following commit https://github.com/odoo/odoo/commit/76e6a0e3560db8257ab0d183463a894ace1e3a7e
renamed in the js calendar view file the template tag from 'template' to 'templates' but forgot
to rename it in the rng file. Since that commit templates in calendar views are not working.
This commit fixes this issue.

closes odoo/odoo#28601
2018-11-13 14:10:36 +00:00
Lucas Perais (lpe) 526bfca3af [FIX] base_address_city: correct view_get with address fields
Have a partner with children exceeding the limit of the kanban.
Edit,
Add a contact > save and quit
Save the partner

Before this commit, there was a traceback, because a check on parent_id was done to compute
the modifier readonly of the city fields in subviews

However, python onchange gets rid of parent_id because child_ids and parent_id are two faces of the same coin
And if that check were not done, we would end up in an infinite recursion

After this commit, there is no traceback, as we stop checking on parent_id in the case of paged subviews
(list and kanban) because we literally know there is one

OPW 1886320

closes odoo/odoo#27114
2018-11-14 08:33:23 +00:00
Goffin Simon 6123cc912c [FIX]purchase_requisition: Creating requistions from OP
Steps to reproduce the bug:

- Create a product : stockable + purchase : propose a call for tenders + reordering rule (qty min 0, max 0, multiple 1)
- Create a SO for that product.
- Run the scheduler once : a requistion is generated (Purchases > Purchase > Purchase Agreements), which is normal behavior
- Run the scheduler a second time

Bug:

A new requistion was generated for the same product, by the same reordering rule

opw:1892950

closes odoo/odoo#28611
2018-11-13 15:08:20 +00:00
Nicolas Martinelli da2d415b79 [FIX] sale: date on Sales Analysis
Use a consistent date between both views of the Sales Analysis report,
otherwise switching from one view to another shows a different
information.

opw-1903091

closes odoo/odoo#28625
2018-11-13 12:56:57 +00:00
Julien (juc) Castiaux 1767f2186d [FIX] delivery: useless conversion to company currency when no company
After removing the company from a delivery method, every checkout done
in website fails due to odoo trying to convert the price to the
company currency.

This PR fix the bug by doing the conversion only when there is a
company set on the delivery method.

opw-1905466

closes odoo/odoo#28626
2018-11-13 12:57:52 +00:00
Christophe Simonis 4a26aa22e5 [FIX] stock: duplicated xmlid
Half-Cherry-Pick of e9fc0e2b5a

closes odoo/odoo#28629
2018-11-13 13:12:22 +00:00
GabbasovDinar 127c6d1f0d [FIX] check mp_dirty to avoid repeated rendering
The patch fixes the issue related to repeated orderline rerendering. It means
that if products of the order were printed before, those will not be rendered
again when new updates of order is sent to the kitchen.

Closes #28577
2018-11-13 11:29:31 +01:00
RomainLibert 1009a0a850 [IMP] fleet: set reminder to 30 days instead of 15
closes odoo/odoo#28643
2018-11-13 10:27:55 +00:00
Arnaud Baes 55d460b5d5 [REF] stock, sale_stock, purchase_stock: stock.uom_propagate config parameter refactor
Avoid duplicate code and instead use a new private function

closes odoo/odoo#29266
2018-12-19 13:57:16 +00:00
Arnaud Baes efb255246b [REF] mrp, purchase_mrp: find bom depending on its type
This commit refactors the method '_bom_find' in order to search bom based on their type.
This allows to handle the cases where a Kit has the route 'Manufacture' set.

TaskID: 1863856
2018-12-19 10:50:29 +00:00
Arnaud Baes 45e53ff7a5 [IMP] mrp, stock: route applied on kit's components
With this commit, the routes of the components of a kit are applied instead of the routes on the kit itself.
To do this, a refactor of '_adjust_procure_method' was made in order to use it on stock.moves

The method '_adjust_procure_method' was moved to the stock module in order to be used in a future task concerning repair orders ( TaskID: 1887961).

TaskID: 1863856
2018-12-19 10:50:29 +00:00
Xavier Morel 52645a7b43 [IMP] calendar: convert mail cron to lastcall feature
Avoids querying and updating an ir.config_parameter which (according to
rco) blows the caches (of all workers) every time it happens, which is
inconvenient.

closes odoo/odoo#29066
2018-12-18 12:07:54 +00:00
Xavier Morel 2c4b9b5c06 [ADD] base: lastcall field to cron, provided to jobs
While many crons will process some sort of queue and can either delete
or mark items as processed, others are more concerned with time ranges
and may not want (or be able to) write on the objects to mark them as
processed. In that case, crons maintaining a processed date range is
useful.

Task 1912648
2018-11-27 12:49:08 +00:00
Haresh Shyara 7997f3b00f [IMP] mrp: replace _get_bom_reference by an xpath
In the BoM structure and cost report the purpose of _get_bom_reference
was to add content with an override in order to display it directly in
the column BoM. It could be improved by using the classic display name
and add a name to column in order to use an xpath in another module.
The function _get_bom and _get_bom_line can also be used in order to
introduce extra content directly in the column added with an xpath.

Task ID : 1875677

closes odoo/odoo#26493
2018-12-11 16:21:05 +00:00
Aurélien Warnon 8b54088cd2 [REF] mass_mailing: clean JS views overrides
Task #1909424

The mass_mailing module used a lot of JS "include" to override
the behavior of the kanban view and the html_frame widget.

This commit cleans the overrides by using proper inheritance with "extend"
instead of "include".

It also slightly changes the current behavior of the mass_mailing kanban view
to disable the drag and drop feature only when the view is grouped by "state" or "email_from".
(Before this commit, the drag and drop feature was disabled for ALL fields).

closes odoo/odoo#29452
2018-12-19 09:10:34 +00:00
Aurélien Warnon e3246845c3 [FIX] web: fix KanbanRenderer state management for date/datetime fields
In the KanbanRenderer, the _setState method extracts the groupBy field name and tries
to get the field information from that string.

When the field is a date/datetime grouped by day/week/month/..., the field name becomes "my_date:month".
This prevents the gathering of state information since those information are stored in a dictionary with a 'my_date' key.

This commit will detect if the field has additional grouping info (:month, :week, ...) and clean the name
with a substring before accessing the state dictionary.
2018-12-19 09:10:34 +00:00
Aurélien Warnon 06c05983e3 [FIX] web: fix KanbanRecord config in KanbanRenderer
The KanbanRecord config was not correctly taken into account when
initializing the columnOptions (for the KanbanColumn).

This completely prevented overriding the KanbanRecord in the kanban view if the KanbanColumn
was used for rendering (= when the view was grouped by a field).
2018-12-12 07:39:40 +00:00
RomainLibert a03faab03f [IMP] event, website_event: Make ics file generation available in event
Ics file generation should be possible even when only event is
installed as it is a basic feature of events.

Moreover we need to be able to generate such files in order to replace
the old outlook api used in the event templates, api which is not
supported anymore.

We decided to use ics files because it is supported by most calendar
schedulers hence working with outlook.

Linked to task #1853063

closes odoo/odoo#28477
2018-12-17 11:46:48 +00:00
jbm-odoo 496920a8f5 [IMP] base: Allow js-class attribute for graph/pivot/calendar views
Add in the RNG file the attribute "js-class" for the calendar, graph and pivot view.

closes odoo/odoo#29609
2018-12-18 16:35:55 +00:00
XavierDo 4682c8a759 [IMP] mail: improve activity done message template
Feedback should be the first part of the message without title
to make it more concise.

If the activity has a note, the note should be displayed
but after the feedback.

We can also remove the field feedback that was not so useful
since it was only written just before unlink. Feedback is now
passed as another parameter to the template.

Task: 1918392

closes odoo/odoo#29605
2018-12-18 15:02:42 +00:00
Yannick Tivisse fd23d93be2 [IMP] hr_payroll_account: Don't erase journal_id if already set
If the journal_id is already set on the payslip and if there are
no journal_id on the contract, don't erase the value on the onchange
method

closes odoo/odoo#29616
2018-12-18 15:04:22 +00:00