Commit Graph
194 Commits
Author SHA1 Message Date
Olivier Dony 005e24fada [FIX] mail.thread: correct matching when finding author + test
The previous matching rules were too fuzzy and allowed random
prefix-match or tail-match of other user's emails.
For example when looking up a partner matching 'foo@bar.com'
the system would sometimes find 'dom.foo@bar.com' instead,
or 'foo@bar.com.tw'.

Fixed by only allowing direct case-insensitive email match
of an addr-spec, or substring match of the addr-spec enclosed
in angle brackets, within a name-addr pair.
See also RFC5322, section 3.4

Also adapted related message_find_partner_from_emails() method
to factor out the partner email resolution mechanism to avoid
the same problem.

Adds corresponding regression test.
2015-01-07 17:50:42 +01:00
Martin Trigaux bd52298073 [IMP] mail: parsing emails with several html parts
If an email contains several text/html parts inside a multipart email, the previous code was only keeping the last content part.
The Content-Type: multipart/mixed allows several independent part (RFC1341 7.2.2), so two html is technically valid.
With this patch, the two parts are concatenated. (opw 614755)

Modify append_content_to_html regex to make sure the regex keeps the content of the html instead of removing it.
e.g.: "123 <html> 456 </html> 789" used to be stripped to "123  789" while we expect "123 456 789"
2014-10-09 13:53:23 +02:00
Denis Ledoux 245bb4ebdf [FIX] mail: to/from/reply-to addresses formated according to RFC2822
Use formataddr method from email.utils lib, which do the job correctly
2014-08-12 13:40:45 +02:00
Olivier Dony 9861b5cada [FIX] mail.thread: avoid overwriting thread_id/model with foreign values when reply-to hostname does not match + fix tests
This improve previous commit by making sure we
never consider the thread_id/model values in the
In-Reply-To/References header if the host name
did not match.
Also fixes the tests that were using the
6.1 compatibility mode to post in a mail group
thread instead of specifying the right
message-id.

bzr revid: odo@openerp.com-20140411142429-y0rpkzqbrsabxqsg
2014-04-11 16:24:29 +02:00
Thibault Delavallée e09f5cd264 [FIX] mail: fixed tests, no more assertionerror, but valueerror
bzr revid: tde@openerp.com-20140212153141-ajwmd26of69tfoer
2014-02-12 16:31:41 +01:00
Thibault Delavallée d874d9980d [FIX] mail: fixed wrong parsing of multipart/mixed emails.
alternative mode is computed when browsing the parts, not from
the message content type.

Added tests.

Also added some notification_email_send to none to avoid sending
emails in demo/data/update.

bzr revid: tde@openerp.com-20130823120611-0n4ull3c8gvwug2u
2013-08-23 14:06:11 +02:00
Thibault Delavallée ea0316e3f1 [FIX] [FIX] mail: fixed subscription of an already subscribed follower erasing already existing subtypes + added tests
bzr revid: tde@openerp.com-20130508102304-p52bq0qux9s7rses
2013-05-08 12:23:04 +02:00
Thibault Delavallée f994529725 [IMP] mail: finding partner based on email: improved code for suggested partners, added somme comments and tests.
bzr revid: tde@openerp.com-20130411101720-mumz152dsxvv1xbj
2013-04-11 12:17:20 +02:00
Thibault Delavallée 37bec9643d [FIX] mail: fixed recipients of private discussion, that were not correct. Author could be notified of their own reply independently of the specified recipients. Added tests for private discussions.
bzr revid: tde@openerp.com-20130403121307-4rixx7ct6y86spoz
2013-04-03 14:13:07 +02:00
Thibault Delavallée d300e2b0ce [FIX] mail: notifications: email_to now contains reference to 'Followers of Doc Name' when having a related document.
bzr revid: tde@openerp.com-20130403121022-lijarue6r2t7mh3w
2013-04-03 14:10:22 +02:00
Thibault Delavallée 4ebbf0e58d [IMP] mail: cleaned some tests, assertTrue on the length of a list replaced by assertEqual.
bzr revid: tde@openerp.com-20130322141022-j26c1hiwfoduky2j
2013-03-22 15:10:22 +01:00
Thibault Delavallée 6cfb01d7c9 [FIX] mail: message_process: do not process incoming emails with a message_id already existing in database.
Before trying to find possible routes, check that the incoming email's
message_id is not already present in mail.message table.
If it is the case, return False.

Parsing of the message has been moved before routing, to avoid looking
for routes for emails we will discard.

Tests have been added and updated.

bzr revid: tde@openerp.com-20130322124809-ven2p5kxpqfjqxb5
2013-03-22 13:48:09 +01:00
Thibault Delavallée 817727ce1c [MERGE] Sync with 7.0
bzr revid: tde@openerp.com-20130321105157-xhj04tgt0in0x9o3
2013-03-21 11:51:57 +01:00
Thibault Delavallée e5aeefadce [FIX] mail: rpely_to of sent emails is sanitized.
bzr revid: tde@openerp.com-20130321092332-8cp59mu3idrpbnke
2013-03-21 10:23:32 +01:00
Thibault Delavallée 0eac6bbad6 [FIX] Forgotten to uncomment commented tests.
bzr revid: tde@openerp.com-20130320161830-0nyfuzyq4s4xa8hk
2013-03-20 17:18:30 +01:00
Thibault Delavallée 30a1d99d07 [MERGE] Sync with trunk + fixed the fix and tests.
bzr revid: tde@openerp.com-20130320161045-41bpe36b09tgcxpo
2013-03-20 17:10:45 +01:00
Olivier Dony 232840179c [FIX] mail.alias: default alias generation now properly handles dots and emails; added tests
lp bug: https://launchpad.net/bugs/1117810 fixed

bzr revid: odo@openerp.com-20130320161023-yalb9ud12k7kuy3o
2013-03-20 17:10:23 +01:00
Thibault Delavallée 23efb82b6d [TEST] mail: updated tests (those that helped raising the previous errors).
bzr revid: tde@openerp.com-20130320135152-qiz3moczldjbmyt7
2013-03-20 14:51:52 +01:00
Thibault Delavallée 6039b80e3f [IMP] [CLEAN] mail: cleaned and improved message_post tests, about email_to, reply_to and attachments.
bzr revid: tde@openerp.com-20130320121614-a862m35peexhw64q
2013-03-20 13:16:14 +01:00
Thibault Delavallée 5df59a9a4b [REF] mail: refactored tests. mailgateway tests are put into a separate file; message_post tests have been a bit cleaned and improved. Also removed an unnecessary mockup.
bzr revid: tde@openerp.com-20130320114111-m1unow90005vwxee
2013-03-20 12:41:11 +01:00
Thibault Delavallée 2c497fab50 [FIX] mail: mass mailing now does not push to followers; only to specific recipients. Improved tests for this update.
bzr revid: tde@openerp.com-20130320084040-pcgzy068z0oph298
2013-03-20 09:40:40 +01:00
Thibault Delavallée c0b4bf55d8 [IMP] [CLEAN] mail: incoming emails have an email_from even if an author is found (do not loose data); fixed author subscription, delegated after message creation (otherwise allows to by-pass most of the access rules); code and comments cleaning.
bzr revid: tde@openerp.com-20130221150849-cydhns582qwrqznz
2013-02-21 16:08:49 +01:00
Thibault Delavallée 64fd407f34 [FIX] mail: fixed mail_post_auto_follow; updated tests accordingly.
bzr revid: tde@openerp.com-20130221142417-hnhqrw9q2uf4agos
2013-02-21 15:24:17 +01:00
Thibault Delavallée e7c630a18f [MERGE] Merged branch holding a first cleaning of message_post and message_post_user_api. Cleaning of auto follow will follow. Hahaha.
bzr revid: tde@openerp.com-20130221130153-k8q1u15mh6e4iwzt
2013-02-21 14:01:53 +01:00
Thibault Delavallée cd13bb9cf9 [CLEAN] mail: stop doing ugly things with partner_ids values before passing values to mail_message.create().
bzr revid: tde@openerp.com-20130221095906-5rbwnc83mjvpkyhh
2013-02-21 10:59:06 +01:00
Thibault Delavallée c3b6408715 [IMP] Chatter: refactoring of 'include new emails/partners' in Chatter compose. It does not create partner everytime; discarding the creation popup discards the creation and addition as recipient.
bzr revid: tde@openerp.com-20130220124923-w3e9hxomniphadj7
2013-02-20 13:49:23 +01:00
Thibault Delavallée a395638dfa [IMP] mail: better heuristic to find the author of an incoming email: in document's followers, or partner that is an user, or partner.
bzr revid: tde@openerp.com-20130214140701-y2nrnc163szni202
2013-02-14 15:07:01 +01:00
Thibault Delavallée d7f63a10fd [FIX] mail: notification emails: subject is now Re: <document_name>.
bzr revid: tde@openerp.com-20130214123925-2ymglkqph90ntebg
2013-02-14 13:39:25 +01:00
Thibault Delavallée 89ba499556 [IMP] Partners do not follow themselves by default now.
bzr revid: tde@openerp.com-20130109104513-3vlyw4knqp4d6to2
2013-01-09 11:45:13 +01:00
Thibault Delavallée 9b2406948e [IMP] mail, email_template: updated tests to match the new html sanitizer, that produces slighty different results (encoded symbols, encapsulated html).
bzr revid: tde@openerp.com-20121226162610-y2y5bmy8bux8smkp
2012-12-26 17:26:10 +01:00
Thibault Delavallée da4dc767c4 [MERGE] Various fixes and improvements in mail.
IMP:
- mail.compose.message: added a context key 'mail_post_autofollow' that automatically subscribe the message recipients to the document followers, if any
- sale, purchase, invoice: recipients of 'Send by email' action are now automatically added as followers, using the above key
- mail: the Chatter widget on documents now sets the displayed messages as read
- mail: for incoming emails going through message_process that have an author, the author is added in the related document followers, if any
FIX:
- mail: attachments added in Chatter/Mailboxes were not added to the notifications emails send to followers/recipients
- portal: fixed various mail_mail created without specifying the type field, that could crash if a conflicting 'default_type' key was present in context (i.e. in opportunities)

bzr revid: tde@openerp.com-20121221131108-jx9jkeukjamnd3yh
2012-12-21 14:11:08 +01:00
Thibault Delavallée e6a63fea3a [FIX] mail: tests: fixed mock of gateway.
bzr revid: tde@openerp.com-20121221111755-63q6w4pkvkx0lvcf
2012-12-21 12:17:55 +01:00
Thibault Delavallée f49f43958d [MERGE] Sync with trunk.
bzr revid: tde@openerp.com-20121221100609-2x59amtxj4sjedcu
2012-12-21 11:06:09 +01:00
Thibault Delavallée de64985e8c [IMP] mail_message: set_message_read and set_message_starred now have an argument to control the automatic notification creation. Chatter now calls set_message_read on received messages (on documents), to set them as read. This is therefore done independently of the message_read, to avoid writing in a read-based method. Added a mutex on the call on set_message_read, because of a recurrent concurrent accesses issue.
bzr revid: tde@openerp.com-20121220205328-gws2j32dsitofu89
2012-12-20 21:53:28 +01:00
Thibault Delavallée a8540c5b7e [REF] [FIX] mail: refactored auto-set read when viewing chatter widget. Added some tests. Also fixed a bug about message order with anybody else than admin.
bzr revid: tde@openerp.com-20121220142852-6sjk03791x829ys3
2012-12-20 15:28:52 +01:00
Thibault Delavallée 8dbf13a1e4 [MERGE] Merged branch holding the automatic set of notifications as read when viewing chatter.
bzr revid: tde@openerp.com-20121220133839-je1jt9ff4a0mfpxh
2012-12-20 14:38:39 +01:00
Thibault Delavallée e3c31cab9e [IMP] track_visibility atribute: moved onto explicit strings.
bzr revid: tde@openerp.com-20121220114730-nip8qaaajr5mqw6s
2012-12-20 12:47:30 +01:00
Thibault Delavallée 86200b4d9c [DOC] [IMP] mail_thread: updated documented the few magic context keys, mail_notify_noemail, mail_create_nosubscribe and mail_create_nolog.
bzr revid: tde@openerp.com-20121219171501-5ndw7aawi8kvttql
2012-12-19 18:15:01 +01:00
Thibault Delavallée 91af1e1e59 [FIX] mail: fixed message_track (subtype not found, style, var_name; updated tests with new implementation.
bzr revid: tde@openerp.com-20121219110502-j43pilfijv91td2q
2012-12-19 12:05:02 +01:00
Thibault Delavallée f8b3788fde [IMP] mail: refactored mechanism for auto subscription, based on a parent. Mapping of subtypes is done using parent_id and parent_field on child subtypes. For example, project subtypes are linked to task subtypes, using parent_id and parent_field project_id, to browse task.project_id.
bzr revid: tde@openerp.com-20121218153457-uh50bjedvxaawdqj
2012-12-18 16:34:57 +01:00
Thibault Delavallée bfea9dad64 [REF] mail: refactored tracked feature. It is now based on a dict defined at model level, giving which subtypes are triggere when modifying some given fields. Cleaned code.
bzr revid: tde@openerp.com-20121218122558-mnrtlwouwai65gq6
2012-12-18 13:25:58 +01:00
Thibault Delavallée 2dbe4a696e [MERGE] Sync wirth trunk.
bzr revid: tde@openerp.com-20121218093241-y0id5g1r1k6yok42
2012-12-18 10:32:41 +01:00
Cecile Tonglet 15fe515601 [MERGE] From trunk
bzr revid: cto@openerp.com-20121217144306-tkodwpox30cuvb28
2012-12-17 15:43:06 +01:00
Sanjay Gohel (Open ERP) de45fd4fc1 [MERGE]with trunk
bzr revid: sgo@tinyerp.com-20121217050659-q5w6zwefizgjv4fd
2012-12-17 10:36:59 +05:30
Thibault Delavallée f1ee7f1ad9 [IMP] mail_message: added the right to reply to a message wes received even if we cannot see the related document.
bzr revid: tde@openerp.com-20121212160634-umbiq2erwijm2d20
2012-12-12 17:06:34 +01:00
Thibault Delavallée 090123436b [IMP] mail: updated lambda user, now having less permissive access rights on mail_mail.
bzr revid: tde@openerp.com-20121212114905-5kgnoix0puxo30ns
2012-12-12 12:49:05 +01:00
Thibault Delavallée 0be4d969af [IMP] mail: updated and improved tests.
bzr revid: tde@openerp.com-20121212104220-d6l7wjghv9oo9dy1
2012-12-12 11:42:20 +01:00
Thibault Delavallée b541e7ce64 [MERGE] Sync with trunk. Cleaned a bit things lastly added in trunk/mail/tests.
bzr revid: tde@openerp.com-20121211161458-d7wv4lnkvs9s7srj
2012-12-11 17:14:58 +01:00
Christophe Matthieu c70f05cc77 [MERGE] catch and display error when there are an error in an attachment upload. Add mail/download_attachment controllers
bzr revid: chm@openerp.com-20121211152219-2hlw1npfq2jfzx88
2012-12-11 16:22:19 +01:00
Thibault Delavallée 3a1e0059a2 [MERGE] Merged branch holding fix of access rights when deleting a document, and the removal of inherits between mail.group and ir.ui.menu.
bzr revid: tde@openerp.com-20121211145536-a02i45isg30l9940
2012-12-11 15:55:36 +01:00