From ffeb855bc717a1a51cdb49e90a6448abb6f337e7 Mon Sep 17 00:00:00 2001 From: shreya thakrar Date: Wed, 12 Jun 2019 09:19:40 +0000 Subject: [PATCH] [FIX] sale_timesheet: remove the down payment line in project overview MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Before this commit, in project overview, there was an advance payment line under 'Timesheets' section which was unnecessary for the timesheet. After this commit, down payment line will not considered in project overview. task-1957272 closes odoo/odoo#34062 Signed-off-by: Jérome Maes (jem) --- addons/sale_timesheet/controllers/main.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/sale_timesheet/controllers/main.py b/addons/sale_timesheet/controllers/main.py index 4330d9d3f73..95b8928ca57 100644 --- a/addons/sale_timesheet/controllers/main.py +++ b/addons/sale_timesheet/controllers/main.py @@ -328,7 +328,7 @@ class SaleTimesheetController(http.Controller): def _table_get_empty_so_lines(self, projects): """ get the Sale Order Lines having no timesheet but having generated a task or a project """ - so_lines = projects.sudo().mapped('sale_line_id.order_id.order_line').filtered(lambda sol: sol.is_service and not sol.is_expense) + so_lines = projects.sudo().mapped('sale_line_id.order_id.order_line').filtered(lambda sol: sol.is_service and not sol.is_expense and not sol.is_downpayment) return set(so_lines.ids), set(so_lines.mapped('order_id').ids) # --------------------------------------------------