From ffbee8882e6b1a4145630253432dccd675233d10 Mon Sep 17 00:00:00 2001 From: RomainLibert Date: Mon, 22 Jan 2018 11:57:18 +0100 Subject: [PATCH] [FIX] rating: Fix minor bug in write method It shouldn't happen, but if we change the name of multiple rating_mixin inheriting models, we can run into an error, because write doesn't support multiple values. --- addons/rating/models/rating.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/addons/rating/models/rating.py b/addons/rating/models/rating.py index ca87b54793c..8995504a6dc 100644 --- a/addons/rating/models/rating.py +++ b/addons/rating/models/rating.py @@ -163,8 +163,9 @@ class RatingMixin(models.AbstractModel): def write(self, values): """ If the rated ressource name is modified, we should update the rating res_name too. """ result = super(RatingMixin, self).write(values) - if self._rec_name in values: - self.rating_ids._compute_res_name() + for r in self: + if r._rec_name in values: + r.rating_ids._compute_res_name() return result def unlink(self):