From ff9be5930953ebf05bf2aa6fc5d2e3a23977cce9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lucas=20Lef=C3=A8vre?= <lul@odoo.com>
Date: Fri, 15 Feb 2019 10:44:33 +0000
Subject: [PATCH] [FIX] hr_payroll: Use jquery API to build benefit buttons

Use the proper jquery API instead of handcrafting dom elements.
+ fix traduction

closes odoo/odoo#31137
---
 addons/hr_payroll/static/src/js/benefit.js | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/addons/hr_payroll/static/src/js/benefit.js b/addons/hr_payroll/static/src/js/benefit.js
index 6ba72ff3f4f..f403e718a64 100644
--- a/addons/hr_payroll/static/src/js/benefit.js
+++ b/addons/hr_payroll/static/src/js/benefit.js
@@ -25,9 +25,9 @@ odoo.define('hr_payroll.benefit.view_custo', function(require) {
         },
 
         _renderBenefitButton: function (text, event_class) {
-            this.$buttons.find('.o_calendar_button_month').after(
-                $('<button class="btn btn-primary btn-benefit ' + event_class + '" type="button">'+ _t(text) +'</button>')
-            );
+            var $button = $('<button class="btn btn-primary btn-benefit" type="button" />');
+            $button.text(text).addClass(event_class);
+            this.$buttons.find('.o_calendar_button_month').after($button);
         },
 
         _renderBenefitButtons: function () {
@@ -41,13 +41,13 @@ odoo.define('hr_payroll.benefit.view_custo', function(require) {
             var is_validated = this._checkValidation(this.events);
             this.$buttons.find('.btn-benefit').remove();
             if (this.events.length === 0) {
-                this._renderBenefitButton("Generate Benefits", 'btn-benefit-generate');
+                this._renderBenefitButton(_t("Generate Benefits"), 'btn-benefit-generate');
             }
             if (is_validated && this.events.length !== 0) {
-                this._renderBenefitButton("Generate Payslips", 'btn-payslip-generate');
+                this._renderBenefitButton(_t("Generate Payslips"), 'btn-payslip-generate');
             }
             else if (!is_validated) {
-                this._renderBenefitButton("Validate Benefits", 'btn-benefit-validate');
+                this._renderBenefitButton(_t("Validate Benefits"), 'btn-benefit-validate');
             }
         },