From ff8d86558334c7ecba1a3fdb18a0d46705d91371 Mon Sep 17 00:00:00 2001 From: "Levi Siuzdak (sile)" Date: Wed, 15 Nov 2023 16:44:55 +0100 Subject: [PATCH] [FIX] website_sale_loyalty: prevent `TypeError` The try-except ensures `reward_id` is either an `int` or `None`, calling `int` on it again doesn't do anything but risk throwing a `TypeError` if `reward_id` was set to `None`. closes odoo/odoo#143256 X-original-commit: fed6c4499b1a32aaeb8e7aeb1d89b3a27a8f8c73 Signed-off-by: Antoine Vandevenne (anv) Signed-off-by: Levi Siuzdak --- addons/website_sale_loyalty/controllers/main.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/website_sale_loyalty/controllers/main.py b/addons/website_sale_loyalty/controllers/main.py index dc7eecec978..a507e8deb38 100644 --- a/addons/website_sale_loyalty/controllers/main.py +++ b/addons/website_sale_loyalty/controllers/main.py @@ -81,7 +81,7 @@ class WebsiteSale(main.WebsiteSale): except ValueError: reward_id = None - reward_sudo = request.env['loyalty.reward'].sudo().browse(int(reward_id)).exists() + reward_sudo = request.env['loyalty.reward'].sudo().browse(reward_id).exists() if not reward_sudo or reward_sudo.multi_product: return request.redirect(redirect)