From ff63f5d0a37a502df420b48656c8d0beb19cb00a Mon Sep 17 00:00:00 2001
From: Yannick Tivisse <yti@odoo.com>
Date: Tue, 23 Aug 2016 09:28:07 +0200
Subject: [PATCH] [IMP] base_setup: Allow the admin to modify the default user
 acess rights

Add a link in the general settings to access easily the default_user form view in order to modify the default access rights

The default_user manager rights declarations in all the applications have been move in a noupdate="1" definition to avoid the manual configuration overwrittings
---
 addons/account/security/account_security.xml    |  7 ++++---
 addons/base_setup/models/res_config.py          |  8 ++++++++
 addons/base_setup/views/res_config_views.xml    |  4 ++++
 addons/event/security/event_security.xml        |  6 +++---
 addons/fleet/security/fleet_security.xml        |  4 ++--
 addons/hr/security/hr_security.xml              |  6 +++---
 .../security/im_livechat_channel_security.xml   |  4 ++--
 addons/lunch/security/lunch_security.xml        |  9 ++++++---
 .../security/marketing_campaign_security.xml    |  8 +++++---
 .../security/mass_mailing_security.xml          |  9 ++++++---
 addons/mrp/security/mrp_security.xml            |  6 +++---
 .../security/point_of_sale_security.xml         | 17 ++++++++++-------
 addons/project/security/project_security.xml    |  7 +++----
 addons/purchase/security/purchase_security.xml  |  7 +++----
 .../sales_team/security/sales_team_security.xml |  9 +++++----
 addons/stock/security/stock_security.xml        |  9 ++++-----
 16 files changed, 71 insertions(+), 49 deletions(-)

diff --git a/addons/account/security/account_security.xml b/addons/account/security/account_security.xml
index 574435c1c00..6d379560a0b 100644
--- a/addons/account/security/account_security.xml
+++ b/addons/account/security/account_security.xml
@@ -21,9 +21,6 @@
         <field name="implied_ids" eval="[(4, ref('group_account_user'))]"/>
     </record>
 
-    <record id="base.default_user" model="res.users">
-        <field name="groups_id" eval="[(4,ref('account.group_account_manager'))]"/>
-    </record>
 
     <record id="group_proforma_invoices" model="res.groups">
         <field name="name">Pro-forma Invoices</field>
@@ -38,6 +35,10 @@
 </data>
 
 <data noupdate="1">
+    <record id="base.default_user" model="res.users">
+        <field name="groups_id" eval="[(4,ref('account.group_account_manager'))]"/>
+    </record>
+
     <record id="account_move_comp_rule" model="ir.rule">
         <field name="name">Account Entry</field>
         <field name="model_id" ref="model_account_move"/>
diff --git a/addons/base_setup/models/res_config.py b/addons/base_setup/models/res_config.py
index 246900e0e75..d30a2771a5d 100644
--- a/addons/base_setup/models/res_config.py
+++ b/addons/base_setup/models/res_config.py
@@ -44,6 +44,14 @@ class BaseConfigSettings(models.TransientModel):
             'target': 'current',
         }
 
+    @api.multi
+    def open_default_user(self):
+        action = self.env.ref('base.action_res_users').read()[0]
+        action['context'] = self.env.context
+        action['res_id'] = self.env.ref('base.default_user').id
+        action['views'] = [[self.env.ref('base.view_users_form').id, 'form']]
+        return action
+
     @api.model
     def get_default_company_share_partner(self, fields):
         return {
diff --git a/addons/base_setup/views/res_config_views.xml b/addons/base_setup/views/res_config_views.xml
index e2ccf15c788..1996530b637 100644
--- a/addons/base_setup/views/res_config_views.xml
+++ b/addons/base_setup/views/res_config_views.xml
@@ -82,6 +82,10 @@
                     <group string="Shared resources" name="company_share_resources" attrs="{'invisible': [('group_multi_company','=',False)]}">
                         <field name="company_share_partner" class="oe_inline" />
                     </group>
+                    <div>
+                        <label string="New users access rights"/>
+                        <button type="object" name="open_default_user" string="Edit default access rights for new users" class="oe_inline oe_link" icon="fa-cogs"/>
+                    </div>
                     <group string="Google Integration" name="google">
                         <label for="id" string="Google Drive"/>
                         <div name="google_drive">
diff --git a/addons/event/security/event_security.xml b/addons/event/security/event_security.xml
index cf034f15bce..e529880a456 100644
--- a/addons/event/security/event_security.xml
+++ b/addons/event/security/event_security.xml
@@ -15,13 +15,13 @@
             <field name="users" eval="[(4, ref('base.user_root'))]"/>
         </record>
 
-        <record id="base.default_user" model="res.users">
-            <field name="groups_id" eval="[(4,ref('event.group_event_manager'))]"/>
-        </record>
 
     </data>
 
     <data noupdate="1">
+        <record id="base.default_user" model="res.users">
+            <field name="groups_id" eval="[(4,ref('event.group_event_manager'))]"/>
+        </record>
 
         <!-- Multi - Company Rules -->
         <record model="ir.rule" id="event_event_company_rule">
diff --git a/addons/fleet/security/fleet_security.xml b/addons/fleet/security/fleet_security.xml
index 3b3ea7f5b3f..0faf7b9303b 100644
--- a/addons/fleet/security/fleet_security.xml
+++ b/addons/fleet/security/fleet_security.xml
@@ -14,11 +14,11 @@
             <field name="category_id" ref="module_fleet_category"/>
             <field name="users" eval="[(4, ref('base.user_root'))]"/>
         </record>
+
+    <data noupdate="1">
         <record id="base.default_user" model="res.users">
             <field name="groups_id" eval="[(4,ref('fleet.fleet_group_manager'))]"/>
         </record>
-
-    <data noupdate="1">
         <record id="fleet_rule_contract_visibility_user" model="ir.rule">
             <field name="name">User can only see his/her contracts</field>
             <field name="model_id" ref="model_fleet_vehicle_log_contract"/>
diff --git a/addons/hr/security/hr_security.xml b/addons/hr/security/hr_security.xml
index 320ca081325..bf90d5031fc 100644
--- a/addons/hr/security/hr_security.xml
+++ b/addons/hr/security/hr_security.xml
@@ -20,9 +20,6 @@
         <field name="users" eval="[(4, ref('base.user_root'))]"/>
     </record>
 
-    <record id="base.default_user" model="res.users">
-        <field name="groups_id" eval="[(4,ref('base.group_hr_manager'))]"/>
-    </record>
 
     <record id="base.group_hr_attendance" model="res.groups">
         <field name="name">Attendances</field>
@@ -30,6 +27,9 @@
     </record>
 
 <data noupdate="1">
+    <record id="base.default_user" model="res.users">
+        <field name="groups_id" eval="[(4,ref('base.group_hr_manager'))]"/>
+    </record>
 
     <record id="hr_dept_comp_rule" model="ir.rule">
         <field name="name">Department multi company rule</field>
diff --git a/addons/im_livechat/security/im_livechat_channel_security.xml b/addons/im_livechat/security/im_livechat_channel_security.xml
index 5b0266fc28a..cab82a18e4d 100644
--- a/addons/im_livechat/security/im_livechat_channel_security.xml
+++ b/addons/im_livechat/security/im_livechat_channel_security.xml
@@ -1,6 +1,5 @@
 <?xml version="1.0"?>
 <odoo>
-    <data>
 
         <record id="module_category_im_livechat" model="ir.module.category">
             <field name="name">Live Support</field>
@@ -21,9 +20,10 @@
             <field name="users" eval="[(4, ref('base.user_root'))]"/>
         </record>
 
+
+    <data noupdate="1">
         <record id="base.default_user" model="res.users">
             <field name="groups_id" eval="[(4,ref('im_livechat.im_livechat_group_manager'))]"/>
         </record>
-
     </data>
 </odoo>
diff --git a/addons/lunch/security/lunch_security.xml b/addons/lunch/security/lunch_security.xml
index 40d7dc17268..f42b9333f79 100644
--- a/addons/lunch/security/lunch_security.xml
+++ b/addons/lunch/security/lunch_security.xml
@@ -16,9 +16,6 @@
             <field name="users" eval="[(4, ref('base.user_root'))]"/>
         </record>
 
-        <record id="base.default_user" model="res.users">
-            <field name="groups_id" eval="[(4,ref('lunch.group_lunch_manager'))]"/>
-        </record>
 
         <record id="lunch_mind_your_own_food_money" model="ir.rule">
             <field name="name">lunch.cashmove: do not see other people's cashmove</field>
@@ -42,4 +39,10 @@
             <field name="perm_unlink" eval="1" />
             <field name="groups" eval="[(4,ref('lunch.group_lunch_user'))]"/>
         </record>
+
+    <data noupdate="1">
+        <record id="base.default_user" model="res.users">
+            <field name="groups_id" eval="[(4,ref('lunch.group_lunch_manager'))]"/>
+        </record>
+    </data>
 </odoo>
diff --git a/addons/marketing_campaign/security/marketing_campaign_security.xml b/addons/marketing_campaign/security/marketing_campaign_security.xml
index 7178ba0905f..1ce1c8ad1aa 100644
--- a/addons/marketing_campaign/security/marketing_campaign_security.xml
+++ b/addons/marketing_campaign/security/marketing_campaign_security.xml
@@ -12,7 +12,9 @@
         <field name="users" eval="[(4, ref('base.user_root'))]"/>
     </record>
 
-    <record id="base.default_user" model="res.users">
-        <field name="groups_id" eval="[(4,ref('marketing_campaign.group_lead_automation_manager'))]"/>
-    </record>
+    <data noupdate="1">
+        <record id="base.default_user" model="res.users">
+            <field name="groups_id" eval="[(4,ref('marketing_campaign.group_lead_automation_manager'))]"/>
+        </record>
+    </data>
 </odoo>
diff --git a/addons/mass_mailing/security/mass_mailing_security.xml b/addons/mass_mailing/security/mass_mailing_security.xml
index d1a10cda344..03b56240312 100644
--- a/addons/mass_mailing/security/mass_mailing_security.xml
+++ b/addons/mass_mailing/security/mass_mailing_security.xml
@@ -7,9 +7,6 @@
         <field name="implied_ids" eval="[(4, ref('base.group_user'))]"/>
     </record>
     
-    <record id="base.default_user" model="res.users">
-        <field name="groups_id" eval="[(4,ref('mass_mailing.group_mass_mailing_user'))]"/>
-    </record>
 
     <record id="group_website_popup_on_exit" model="res.groups">
         <field name="name">Use subscription pop up on the website</field>
@@ -21,4 +18,10 @@
         <field name="name">Manage Mass Mailing Campaigns</field>
         <field name="category_id" ref="base.module_category_hidden"/>
     </record>
+
+    <data noupdate="1">
+        <record id="base.default_user" model="res.users">
+            <field name="groups_id" eval="[(4,ref('mass_mailing.group_mass_mailing_user'))]"/>
+        </record>
+    </data>
 </odoo>
diff --git a/addons/mrp/security/mrp_security.xml b/addons/mrp/security/mrp_security.xml
index b75a3f0014a..35d843b9aeb 100644
--- a/addons/mrp/security/mrp_security.xml
+++ b/addons/mrp/security/mrp_security.xml
@@ -14,9 +14,6 @@
         <field name="users" eval="[(4, ref('base.user_root'))]"/>
     </record>
 
-    <record id="base.default_user" model="res.users">
-        <field name="groups_id" eval="[(4,ref('mrp.group_mrp_manager'))]"/>
-    </record>
 
     <record id="group_mrp_routings" model="res.groups">
         <field name="name">Manage Work Order Operations</field>
@@ -25,6 +22,9 @@
 
 </data>
 <data noupdate="1">
+    <record id="base.default_user" model="res.users">
+        <field name="groups_id" eval="[(4,ref('mrp.group_mrp_manager'))]"/>
+    </record>
 <!-- Multi -->
     <record model="ir.rule" id="mrp_production_rule">
         <field name="name">mrp_production multi-company</field>
diff --git a/addons/point_of_sale/security/point_of_sale_security.xml b/addons/point_of_sale/security/point_of_sale_security.xml
index d5928cf5332..649d9df8e57 100644
--- a/addons/point_of_sale/security/point_of_sale_security.xml
+++ b/addons/point_of_sale/security/point_of_sale_security.xml
@@ -11,14 +11,11 @@
         <field name="users" eval="[(4, ref('base.user_root'))]"/>
     </record>
 
-    <record id="base.default_user" model="res.users">
-        <field name="groups_id" eval="[(4,ref('point_of_sale.group_pos_manager'))]"/>
-    </record>
 
     <record id="rule_pos_bank_statement_user" model="ir.rule">
         <field name="name">Point Of Sale Bank Statement POS User</field>
         <field name="model_id" ref="account.model_account_bank_statement" />
-	    <field name="groups" eval="[(4, ref('group_pos_user'))]"/>
+        <field name="groups" eval="[(4, ref('group_pos_user'))]"/>
         <field name="domain_force">[('pos_session_id', '!=', False)]</field>
     </record>
     <record id="rule_pos_bank_statement_account_user" model="ir.rule">
@@ -30,7 +27,7 @@
     <record id="rule_pos_bank_statement_line_user" model="ir.rule">
         <field name="name">Point Of Sale Bank Statement Line POS User</field>
         <field name="model_id" ref="account.model_account_bank_statement_line" />
-	    <field name="groups" eval="[(4, ref('group_pos_user'))]"/>
+        <field name="groups" eval="[(4, ref('group_pos_user'))]"/>
         <field name="domain_force">[('statement_id.pos_session_id', '!=', False)]</field>
     </record>
     <record id="rule_pos_bank_statement_line_account_user" model="ir.rule">
@@ -42,13 +39,13 @@
     <record id="rule_pos_cashbox_line_user" model="ir.rule">
         <field name="name">Point Of Sale Cashbox Line POS User</field>
         <field name="model_id" ref="account.model_account_cashbox_line" />
-	    <field name="groups" eval="[(4, ref('group_pos_user'))]"/>
+        <field name="groups" eval="[(4, ref('group_pos_user'))]"/>
         <field name="domain_force">[('bank_statement_id.pos_session_id', '!=', False)]</field>
     </record>
     <record id="rule_pos_cashbox_line_accountant" model="ir.rule">
         <field name="name">Point Of Sale Cashbox Line Accountant</field>
         <field name="model_id" ref="account.model_account_cashbox_line" />
-	    <field name="groups" eval="[(4, ref('account.group_account_user'))]"/>
+        <field name="groups" eval="[(4, ref('account.group_account_user'))]"/>
         <field name="domain_force">[(1, '=', 1)]</field>
     </record>
     <record id="rule_pos_multi_company" model="ir.rule">
@@ -75,4 +72,10 @@
         <field name="global" eval="True"/>
         <field name="domain_force">['|',('company_id','=',False),('company_id','child_of',[user.company_id.id])]</field>
     </record>
+
+    <data noupdate="1">
+        <record id="base.default_user" model="res.users">
+            <field name="groups_id" eval="[(4,ref('point_of_sale.group_pos_manager'))]"/>
+        </record>
+    </data>
 </odoo>
diff --git a/addons/project/security/project_security.xml b/addons/project/security/project_security.xml
index 7f06484836c..eea59a61459 100644
--- a/addons/project/security/project_security.xml
+++ b/addons/project/security/project_security.xml
@@ -14,16 +14,15 @@
         <field name="users" eval="[(4, ref('base.user_root'))]"/>
     </record>
 
-    <record id="base.default_user" model="res.users">
-        <field name="groups_id" eval="[(4,ref('project.group_project_manager'))]"/>
-    </record>
-
     <record id="group_time_work_estimation_tasks" model="res.groups">
         <field name="name">Time Estimation on Tasks</field>
         <field name="category_id" ref="base.module_category_hidden"/>
     </record>
 
 <data noupdate="1">
+    <record id="base.default_user" model="res.users">
+        <field name="groups_id" eval="[(4,ref('project.group_project_manager'))]"/>
+    </record>
 
     <record model="ir.rule" id="project_comp_rule">
         <field name="name">Project: multi-company</field>
diff --git a/addons/purchase/security/purchase_security.xml b/addons/purchase/security/purchase_security.xml
index 0544735c381..1416745a8bb 100644
--- a/addons/purchase/security/purchase_security.xml
+++ b/addons/purchase/security/purchase_security.xml
@@ -15,10 +15,6 @@
         <field name="users" eval="[(4, ref('base.user_root'))]"/>
     </record>
 
-    <record id="base.default_user" model="res.users">
-        <field name="groups_id" eval="[(4,ref('purchase.group_purchase_manager'))]"/>
-    </record>
-
     <record id="group_analytic_accounting" model="res.groups">
         <field name="name">Analytic Accounting for Purchases</field>
         <field name="category_id" ref="base.module_category_hidden"/>
@@ -37,6 +33,9 @@
 
 </data>
 <data noupdate="1">
+    <record id="base.default_user" model="res.users">
+        <field name="groups_id" eval="[(4,ref('purchase.group_purchase_manager'))]"/>
+    </record>
 
     <record model="ir.rule" id="purchase_order_comp_rule">
         <field name="name">Purchase Order multi-company</field>
diff --git a/addons/sales_team/security/sales_team_security.xml b/addons/sales_team/security/sales_team_security.xml
index 2aac8743593..ce8756e5f36 100644
--- a/addons/sales_team/security/sales_team_security.xml
+++ b/addons/sales_team/security/sales_team_security.xml
@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <odoo>
-    <data noupdate="0">
         <record id="group_sale_salesman" model="res.groups">
             <field name="name">User: Own Documents Only</field>
             <field name="category_id" ref="base.module_category_sales_management"/>
@@ -23,9 +22,6 @@
             <field name="users" eval="[(4, ref('base.user_root'))]"/>
         </record>
 
-        <record id="base.default_user" model="res.users">
-            <field name="groups_id" eval="[(4,ref('sales_team.group_sale_manager'))]"/>
-        </record>
 
         <record id="crm_rule_own_salesteam" model="ir.rule">
             <field name="name">Own Salesteam</field>
@@ -56,5 +52,10 @@
             <field name="name">Contacts</field>
             <field eval="[(6,0,[ref('base.group_system'), ref('base.group_partner_manager')])]" name="groups_id"/>
         </record>
+
+    <data noupdate="1">
+        <record id="base.default_user" model="res.users">
+            <field name="groups_id" eval="[(4,ref('sales_team.group_sale_manager'))]"/>
+        </record>
     </data>
 </odoo>
diff --git a/addons/stock/security/stock_security.xml b/addons/stock/security/stock_security.xml
index 90e5383d859..027afe43ae8 100644
--- a/addons/stock/security/stock_security.xml
+++ b/addons/stock/security/stock_security.xml
@@ -24,10 +24,6 @@
         <field name="users" eval="[(4, ref('base.user_root'))]"/>
     </record>
 
-    <record id="base.default_user" model="res.users">
-        <field name="groups_id" eval="[(4,ref('stock.group_stock_manager'))]"/>
-    </record>
-
     <record id="group_production_lot" model="res.groups">
         <field name="name">Manage Lots / Serial Numbers</field>
         <field name="category_id" ref="base.module_category_hidden"/>
@@ -54,8 +50,11 @@
     </record>
 </data>
 <data noupdate="1">
-<!-- multi -->
+    <record id="base.default_user" model="res.users">
+        <field name="groups_id" eval="[(4,ref('stock.group_stock_manager'))]"/>
+    </record>
 
+<!-- multi -->
     <record model="ir.rule" id="stock_picking_rule">
         <field name="name">stock_picking multi-company</field>
         <field name="model_id" search="[('model','=','stock.picking')]" model="ir.model"/>