From ff613d8763655c57e0b179df4059bf5fe9490886 Mon Sep 17 00:00:00 2001 From: Aaron Bohy Date: Thu, 26 Jan 2017 09:44:57 +0100 Subject: [PATCH] [FIX] hr: correctly format mention partner suggestions Rev. 36f6f26 changed the format of the returned list of employees. Javascript is expecting an array containing the array of employees, each employee being a dict with keys id, name, email. But from rev. 36f6f26, it returned an array of employees, themselves represented by an array containing their id, name and email. As the format changed, the Javascript mention mechanism never used the prefetched employees, and always fallbacked on an RPC to fetch suggestions amongs all partners. --- addons/hr/res_partner.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/addons/hr/res_partner.py b/addons/hr/res_partner.py index 5f85ce66186..aa9aa516b66 100644 --- a/addons/hr/res_partner.py +++ b/addons/hr/res_partner.py @@ -14,8 +14,9 @@ class Partner(models.Model): try: employee_group = self.env.ref('base.group_user') - for user in employee_group.users: - suggestions.append((user.partner_id.id, user.name, user.email)) + hr_suggestions = [{'id': user.partner_id.id, 'name': user.name, 'email': user.email} + for user in employee_group.users] + suggestions.append(hr_suggestions) return suggestions except AccessError: return suggestions