From ff47130bc438197d0f1bde912a8ee6f702b8b3ed Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thibault=20Delavall=C3=A9e?= Date: Wed, 26 Jul 2017 15:16:00 +0200 Subject: [PATCH] [IMP] sale: sudo ir.config_parameter only once in settings --- addons/sale/models/sale_config_settings.py | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/addons/sale/models/sale_config_settings.py b/addons/sale/models/sale_config_settings.py index e7c3f6eac54..e38d93d5227 100644 --- a/addons/sale/models/sale_config_settings.py +++ b/addons/sale/models/sale_config_settings.py @@ -133,12 +133,13 @@ class SaleConfigSettings(models.TransientModel): @api.model def get_values(self): res = super(SaleConfigSettings, self).get_values() - sale_pricelist_setting = self.env['ir.config_parameter'].sudo().get_param('sale.sale_pricelist_setting') + ICPSudo = self.env['ir.config_parameter'].sudo() + sale_pricelist_setting = ICPSudo.get_param('sale.sale_pricelist_setting') res.update( - use_sale_note=self.env['ir.config_parameter'].sudo().get_param('sale.use_sale_note', default=False), - auto_done_setting=self.env['ir.config_parameter'].sudo().get_param('sale.auto_done_setting'), - default_deposit_product_id=self.env['ir.config_parameter'].sudo().get_param('sale.default_deposit_product_id'), - sale_show_tax=self.env['ir.config_parameter'].sudo().get_param('sale.sale_show_tax', default='subtotal'), + use_sale_note=ICPSudo.get_param('sale.use_sale_note', default=False), + auto_done_setting=ICPSudo.get_param('sale.auto_done_setting'), + default_deposit_product_id=ICPSudo.get_param('sale.default_deposit_product_id'), + sale_show_tax=ICPSudo.get_param('sale.sale_show_tax', default='subtotal'), multi_sales_price=sale_pricelist_setting in ['percentage', 'formula'], multi_sales_price_method=sale_pricelist_setting in ['percentage', 'formula'] and sale_pricelist_setting or False, sale_pricelist_setting=sale_pricelist_setting, @@ -148,8 +149,9 @@ class SaleConfigSettings(models.TransientModel): @api.multi def set_values(self): super(SaleConfigSettings, self).set_values() - self.env['ir.config_parameter'].sudo().set_param("sale.use_sale_note", self.use_sale_note) - self.env['ir.config_parameter'].sudo().set_param("sale.auto_done_setting", self.auto_done_setting) - self.env['ir.config_parameter'].sudo().set_param("sale.default_deposit_product_id", self.default_deposit_product_id.id) - self.env['ir.config_parameter'].sudo().set_param('sale.sale_pricelist_setting', self.sale_pricelist_setting) - self.env['ir.config_parameter'].sudo().set_param('sale.sale_show_tax', self.sale_show_tax) + ICPSudo = self.env['ir.config_parameter'].sudo() + ICPSudo.set_param("sale.use_sale_note", self.use_sale_note) + ICPSudo.set_param("sale.auto_done_setting", self.auto_done_setting) + ICPSudo.set_param("sale.default_deposit_product_id", self.default_deposit_product_id.id) + ICPSudo.set_param('sale.sale_pricelist_setting', self.sale_pricelist_setting) + ICPSudo.set_param('sale.sale_show_tax', self.sale_show_tax)