From ff422df49201be6ed7baa11ef3deb5b9a41042a7 Mon Sep 17 00:00:00 2001 From: Antoine Guenet Date: Thu, 7 Apr 2022 10:30:25 +0000 Subject: [PATCH] [FIX] mass_mailing: prevent use of unsupported image transform option The image transform option uses the `transform` CSS property, which is very poorly supported in email clients. This hides that option so as to avoid bad surprises. task-2802705 closes odoo/odoo#88052 X-original-commit: 611c9a2aa65f3c6f9e1c0780cb9177bc1e67513d Signed-off-by: David Monjoie (dmo) --- .../static/src/js/mass_mailing_snippets.js | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/addons/mass_mailing/static/src/js/mass_mailing_snippets.js b/addons/mass_mailing/static/src/js/mass_mailing_snippets.js index de34cd73cb6..c93f74861f3 100644 --- a/addons/mass_mailing/static/src/js/mass_mailing_snippets.js +++ b/addons/mass_mailing/static/src/js/mass_mailing_snippets.js @@ -197,6 +197,23 @@ options.registry.BackgroundImage = options.registry.BackgroundImage.extend({ options.registry.ImageTools.include({ + //-------------------------------------------------------------------------- + // Public + //-------------------------------------------------------------------------- + + /** + * @override + */ + async updateUIVisibility() { + await this._super(...arguments); + + // Transform is _very_ badly supported in mail clients. Hide the option. + const transformEl = this.el.querySelector('[data-transform="true"]'); + if (transformEl) { + transformEl.classList.toggle('d-none', true); + } + }, + //-------------------------------------------------------------------------- // Private //--------------------------------------------------------------------------