From bbce92b43692e594ab1f16f8ed42d673c14e7528 Mon Sep 17 00:00:00 2001
From: Victor Feyens <vfe@odoo.com>
Date: Wed, 12 Feb 2020 15:00:36 +0000
Subject: [PATCH 1/3] [REF] base, various: remove unused views

PURPOSE

Remove dead views to clean dead records

SPECIFICATIONS

Find unused views and remove them, notably specific views that are not used
anymore because generic one is always taken. Notably

  * view_partner_short_form: a short form view on partner that is not used
    anywhere anymore. Indeed it has a priority of 2 whereas default form view
    has a priority of 1 (lower better). It is not referenced in actions
    anymore. It is therefore dead.

LINKS

Task ID 2196317 (Social/Marketing specific)
---
 addons/account/views/partner_view.xml         | 15 -----
 addons/base_vat/views/res_partner_views.xml   | 11 ----
 addons/mail/__manifest__.py                   |  1 -
 .../mail/views/mail_channel_partner_views.xml | 22 -------
 .../views/res_partner_views.xml               | 18 ------
 odoo/addons/base/views/ir_ui_menu_views.xml   | 13 +---
 odoo/addons/base/views/res_partner_views.xml  | 63 -------------------
 7 files changed, 1 insertion(+), 142 deletions(-)
 delete mode 100644 addons/mail/views/mail_channel_partner_views.xml

diff --git a/addons/account/views/partner_view.xml b/addons/account/views/partner_view.xml
index 1a706e80aa3..84319c68130 100644
--- a/addons/account/views/partner_view.xml
+++ b/addons/account/views/partner_view.xml
@@ -93,21 +93,6 @@
             </field>
         </record>
 
-        <record model="ir.ui.view" id="partner_view_short_extra">
-            <field name="name">partner.short.view.account</field>
-            <field name="model">res.partner</field>
-            <field name="inherit_id" ref="base.view_partner_short_form" />
-            <field name="priority" eval="20"/>
-            <field name="arch" type="xml">
-                <field name="email" position="after">
-                    <field name="company_id" invisible="1"/>
-                    <field name="property_payment_term_id" widget="selection"/>
-                    <field name="property_account_position_id" options="{'no_create': True, 'no_open': True}"/>
-                </field>
-            </field>
-        </record>
-
-
         <record model="ir.ui.view" id="partner_view_buttons">
             <field name="name">partner.view.buttons</field>
             <field name="model">res.partner</field>
diff --git a/addons/base_vat/views/res_partner_views.xml b/addons/base_vat/views/res_partner_views.xml
index f97975c3c14..31374587957 100644
--- a/addons/base_vat/views/res_partner_views.xml
+++ b/addons/base_vat/views/res_partner_views.xml
@@ -13,15 +13,4 @@
                 </xpath>
             </field>
         </record>
-
-        <record id="view_partner_short_form" model="ir.ui.view">
-            <field name="name">res.partner.short.vat.inherit</field>
-            <field name="model">res.partner</field>
-            <field name="inherit_id" ref="base.view_partner_short_form"/>
-            <field name="arch" type="xml">
-                <xpath expr="//field[@name='vat']" position="attributes">
-                    <attribute name="string">VAT</attribute>
-                </xpath>
-            </field>
-        </record>
 </odoo>
diff --git a/addons/mail/__manifest__.py b/addons/mail/__manifest__.py
index ebc01ee719a..de396abcdd2 100644
--- a/addons/mail/__manifest__.py
+++ b/addons/mail/__manifest__.py
@@ -40,7 +40,6 @@
         'views/ir_model_views.xml',
         'views/res_partner_views.xml',
         'views/mail_blacklist_views.xml',
-        'views/mail_channel_partner_views.xml',
     ],
     'demo': [
         'data/mail_channel_demo.xml',
diff --git a/addons/mail/views/mail_channel_partner_views.xml b/addons/mail/views/mail_channel_partner_views.xml
deleted file mode 100644
index 89ff3645487..00000000000
--- a/addons/mail/views/mail_channel_partner_views.xml
+++ /dev/null
@@ -1,22 +0,0 @@
-<?xml version="1.0"?>
-<odoo>
-    <data>
-        <record model="ir.ui.view" id="res_partner_view_form_short">
-            <field name="name">res.partner.view.form.short.inherit.mail</field>
-            <field name="model">res.partner</field>
-            <field name="inherit_id" ref="base.view_partner_short_form" />
-            <field name="priority" eval="20"/>
-            <field name="arch" type="xml">
-                 <xpath expr="//field[@name='email']" position="replace">
-                    <field name="is_blacklisted" invisible="1"/>
-                    <label for="email" class="oe_inline"/>
-                    <div class="o_row o_row_readonly">
-                        <i class="fa fa-ban" style="color: red;" role="img" title="This email is blacklisted for mass mailing"
-                            aria-label="Blacklisted" attrs="{'invisible': [('is_blacklisted', '=', False)]}" groups="base.group_user"></i>
-                        <field name="email" widget="email"/>
-                    </div>
-                </xpath>
-            </field>
-        </record>
-    </data>
-</odoo>
diff --git a/addons/partner_autocomplete/views/res_partner_views.xml b/addons/partner_autocomplete/views/res_partner_views.xml
index 380e2246fa7..ad8190142be 100644
--- a/addons/partner_autocomplete/views/res_partner_views.xml
+++ b/addons/partner_autocomplete/views/res_partner_views.xml
@@ -18,24 +18,6 @@
         </field>
     </record>
 
-    <record id="view_res_partner_short_form_inherit_partner_autocomplete" model="ir.ui.view">
-        <field name="name">res.partner.short.form.inherit.partner.autocomplete</field>
-        <field name="model">res.partner</field>
-        <field name="inherit_id" ref="base.view_partner_short_form"/>
-        <field name="arch" type="xml">
-            <xpath expr="//div[hasclass('oe_title')]/h1/field[@name='name']" position="attributes">
-                <attribute name="widget">field_partner_autocomplete</attribute>
-            </xpath>
-            <xpath expr="//field[@name='vat']" position="attributes">
-                <attribute name="widget">field_partner_autocomplete</attribute>
-            </xpath>
-            <xpath expr="//field[last()]" position="after">
-                <field name="partner_gid" invisible="True"/>
-                <field name="additional_info" invisible="True"/>
-            </xpath>
-        </field>
-    </record>
-
     <record id="view_partner_simple_form_inherit_partner_autocomplete" model="ir.ui.view">
         <field name="name">res.partner.simplified.form.inherit.partner.autocomplete</field>
         <field name="model">res.partner</field>
diff --git a/odoo/addons/base/views/ir_ui_menu_views.xml b/odoo/addons/base/views/ir_ui_menu_views.xml
index bbf08744e14..90f10929637 100644
--- a/odoo/addons/base/views/ir_ui_menu_views.xml
+++ b/odoo/addons/base/views/ir_ui_menu_views.xml
@@ -1,16 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <odoo>
-        <record id="view_menu" model="ir.ui.view">
-            <field name="name">ir.ui.menu.tree</field>
-            <field name="model">ir.ui.menu</field>
-            <field name="arch" type="xml">
-                <tree string="Menu">
-                    <field icon="icon" name="name"/>
-                </tree>
-            </field>
-            <field name="field_parent">child_id</field>
-        </record>
-
         <record id="edit_menu_access" model="ir.ui.view">
             <field name="model">ir.ui.menu</field>
             <field name="arch" type="xml">
@@ -52,7 +41,7 @@
 
         <record id="edit_menu" model="ir.ui.view">
             <field name="model">ir.ui.menu</field>
-            <field eval="8" name="priority"/>
+            <field name="priority" eval="8"/>
             <field name="arch" type="xml">
                 <tree string="Menu">
                     <field name="sequence" widget='handle'/>
diff --git a/odoo/addons/base/views/res_partner_views.xml b/odoo/addons/base/views/res_partner_views.xml
index 58771f5a819..1c346cbc60d 100644
--- a/odoo/addons/base/views/res_partner_views.xml
+++ b/odoo/addons/base/views/res_partner_views.xml
@@ -130,69 +130,6 @@
             </field>
         </record>
 
-        <record id="view_partner_short_form" model="ir.ui.view">
-            <field name="name">res.partner.form</field>
-            <field name="model">res.partner</field>
-            <field name="priority" eval="2"/>
-            <field name="arch" type="xml">
-                <form string="Partners">
-                <sheet>
-                    <field name="image_1920" widget='image' class="oe_avatar" options='{"preview_image": "image_128"}'/>
-                    <div class="oe_title">
-                        <field name="is_company" invisible="1"/>
-                        <field name="commercial_partner_id" invisible="1"/>
-                        <field name="company_type" widget="radio"
-                            class="oe_edit_only"
-                            options="{'horizontal': true}"/>
-                        <h1>
-                            <field name="name" default_focus="1" placeholder="Name" attrs="{'required' : [('type', '=', 'contact')]}"/>
-                        </h1>
-                        <div class="o_row">
-                            <field name="parent_id"
-                                widget="res_partner_many2one"
-                                placeholder="Company"
-                                domain="[('is_company', '=', True)]" context="{'default_is_company': True, 'show_vat': True}"
-                                attrs="{'invisible': ['|', '&amp;', ('is_company','=', True),('parent_id', '=', False),('company_name', '!=', False),('company_name', '!=', '')]}"/>
-                                <field name="company_name" attrs="{'invisible': ['|', '|', ('company_name', '=', False), ('company_name', '=', ''), ('is_company', '=', True)]}"/>
-                                <button name="create_company" type="object" icon="fa fa-plus-square"
-                                    class="oe_edit_only btn-link" string="Create company"
-                                    attrs="{'invisible': ['|', '|', ('is_company','=', True), ('company_name', '=', ''), ('company_name', '=', False)]}"/>
-                        </div>
-                    </div>
-                    <group>
-                        <group>
-                            <field name="type" attrs="{'invisible': [('parent_id','=', False)]}" groups="base.group_no_one"/>
-                            <label for="street" string="Address"/>
-                            <div class="o_address_format">
-                                <div attrs="{'invisible': ['|', ('parent_id', '=', False), ('type', '!=', 'contact')]}" class="oe_edit_only"><b>Company Address:</b></div>
-                                <field name="street" placeholder="Street..." class="o_address_street"
-                                    attrs="{'readonly': [('type', '=', 'contact'),('parent_id', '!=', False)]}"/>
-                                <field name="street2" placeholder="Street 2..." class="o_address_street"
-                                    attrs="{'readonly': [('type', '=', 'contact'),('parent_id', '!=', False)]}"/>
-                                <field name="city" placeholder="City" class="o_address_city"
-                                    attrs="{'readonly': [('type', '=', 'contact'),('parent_id', '!=', False)]}"/>
-                                <field name="state_id" class="o_address_state" placeholder="State" options="{'no_open': True, 'no_quick_create': True}"
-                                    attrs="{'readonly': [('type', '=', 'contact'),('parent_id', '!=', False)]}" context="{'country_id': country_id, 'default_country_id': country_id, 'zip': zip}"/>
-                                <field name="zip" placeholder="ZIP" class="o_address_zip"
-                                    attrs="{'readonly': [('type', '=', 'contact'),('parent_id', '!=', False)]}"/>
-                                <field name="country_id" placeholder="Country" class="o_address_country" options='{"no_open": True, "no_create": True}'
-                                    attrs="{'readonly': [('type', '=', 'contact'),('parent_id', '!=', False)]}"/>
-                            </div>
-                            <field name="vat" placeholder="e.g. BE0477472701" attrs="{'readonly': [('parent_id','!=',False)]}"/>
-                        </group>
-                        <group>
-                            <field name="function" placeholder="e.g. Sales Director"
-                                attrs="{'invisible': [('is_company','=', True)]}"/>
-                            <field name="phone" widget="phone" options="{'enable_sms': false}"/>
-                            <field name="mobile" widget="phone" options="{'enable_sms': false}"/>
-                            <field name="email" widget="email" context="{'gravatar_image': True}"/>
-                        </group>
-                    </group>
-                </sheet>
-                </form>
-            </field>
-        </record>
-
         <record id="view_partner_form" model="ir.ui.view">
             <field name="name">res.partner.form</field>
             <field name="model">res.partner</field>

From bd748c10bebfbdf85fc021624fe589feb5d7c930 Mon Sep 17 00:00:00 2001
From: Victor Feyens <vfe@odoo.com>
Date: Wed, 12 Feb 2020 14:58:34 +0000
Subject: [PATCH 2/3] [REF] crm: remove unused views

PURPOSE

Remove dead views to clean dead records

SPECIFICATIONS

Find unused views and remove them, notably specific views that are not used
anymore because generic one is always taken.

LINKS

Task ID 2196317 (Social/Marketing specific)
---
 addons/crm/views/crm_lead_views.xml | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/addons/crm/views/crm_lead_views.xml b/addons/crm/views/crm_lead_views.xml
index 456547a43ce..8fcb9d30be1 100644
--- a/addons/crm/views/crm_lead_views.xml
+++ b/addons/crm/views/crm_lead_views.xml
@@ -646,23 +646,6 @@
             </field>
         </record>
 
-        <record id="crm_lead_view_tree_activity" model="ir.ui.view">
-            <field name="name">crm.lead.tree.opportunity.next.activity</field>
-            <field name="model">crm.lead</field>
-            <field name="arch" type="xml">
-                <tree string="Next Activities" decoration-danger="activity_date_deadline and (activity_date_deadline &lt; current_date)">
-                    <field name="name"/>
-                    <field name="partner_id"/>
-                    <field name="activity_date_deadline"/>
-                    <field name="activity_type_id"/>
-                    <field name="activity_summary"/>
-                    <field name="stage_id" required="1"/>
-                    <field name="planned_revenue"/>
-                    <field name="date_deadline"/>
-                </tree>
-            </field>
-        </record>
-
         <record id="view_crm_case_opportunities_filter" model="ir.ui.view">
             <field name="name">crm.lead.search.opportunity</field>
             <field name="model">crm.lead</field>

From 067034453b1e5c5b19013a952dbf5339f801e3e5 Mon Sep 17 00:00:00 2001
From: Victor Feyens <vfe@odoo.com>
Date: Wed, 12 Feb 2020 14:59:18 +0000
Subject: [PATCH 3/3] [REF] mass_mailing_sms: remove unused views

PURPOSE

Remove dead views to clean dead records

SPECIFICATIONS

Find unused views and remove them, notably specific views that are not used
anymore because generic one is always taken.

LINKS

Task ID 2196317 (Social/Marketing specific)
---
 .../report/mailing_trace_report_views.xml     | 50 -------------------
 1 file changed, 50 deletions(-)

diff --git a/addons/mass_mailing_sms/report/mailing_trace_report_views.xml b/addons/mass_mailing_sms/report/mailing_trace_report_views.xml
index 565ccfc79e0..a3a56aa25e2 100644
--- a/addons/mass_mailing_sms/report/mailing_trace_report_views.xml
+++ b/addons/mass_mailing_sms/report/mailing_trace_report_views.xml
@@ -1,55 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <odoo>
-    <record id="mailing_trace_report_view_pivot" model="ir.ui.view">
-        <field name="name">mailing.trace.report.view.pivot</field>
-        <field name="model">mailing.trace.report</field>
-        <field name="arch" type="xml">
-            <pivot string="Mass Mailing Statistics" disable_linking="True">
-                <field name="campaign" type="row"/>
-                <field name="sent" type="measure"/>
-                <field name="delivered" type="measure"/>
-                <field name="opened" type="measure"/>
-                <field name="bounced" type="measure"/>
-                <field name="replied" type="measure"/>
-                <field name="clicked" type="measure"/>
-            </pivot>
-        </field>
-    </record>
-
-    <record id="mailing_trace_report_view_graph" model="ir.ui.view">
-        <field name="name">mailing.trace.report.view.graph</field>
-        <field name="model">mailing.trace.report</field>
-        <field name="arch" type="xml">
-            <graph string="Mass Mailing Statistics">
-                <field name="campaign"/>
-                <field name="sent" type="measure"/>
-            </graph>
-        </field>
-    </record>
-
-    <record id="mailing_trace_report_view_search" model="ir.ui.view">
-        <field name="name">mailing.trace.report.view.search</field>
-        <field name="model">mailing.trace.report</field>
-        <field name="arch" type="xml">
-            <search string="Mass Mailing Statistics">
-                <group expand="0" string="Extended Filters...">
-                    <field name="scheduled_date"/>
-                </group>
-                <group expand="1" string="Group By...">
-                    <filter string="Mass Mailing Campaign" name="mass_mailing_campaign"
-                        domain="[]" context="{'group_by':'campaign'}"/>
-                    <filter string="State" domain="[]" name="state"
-                        context="{'group_by':'state'}"/>
-                    <filter string="Sent By" domain="[]" name="sent_by"
-                        context="{'group_by':'email_from'}"/>
-                    <separator/>
-                    <filter string="Scheduled Period" name="scheduled_date"
-                        domain="[]" context="{'group_by':'scheduled_date'}"/>
-                </group>
-            </search>
-        </field>
-    </record>
-
     <!-- Actions and Menuitems -->
     <record id="mailing_trace_report_action_sms" model="ir.actions.act_window">
         <field name="name">SMS Marketing Analysis</field>