From fe5c8602b0da26c3f14b55cb49f1885d454ccacd Mon Sep 17 00:00:00 2001 From: Sanjay Jamod Date: Thu, 8 Feb 2018 17:20:27 +0530 Subject: [PATCH] [IMP] base: protect ir_mail_server credentials by `base.group_system` group Purpose of this commit is to prevent unauthenticated access on user name and password of the mail server. Indeed as mass mailing users notably gain access to mail servers let us protect its credentials. This commit is related to task ID 31737 --- odoo/addons/base/models/ir_mail_server.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/odoo/addons/base/models/ir_mail_server.py b/odoo/addons/base/models/ir_mail_server.py index 6898de4ef4d..d010d486f41 100644 --- a/odoo/addons/base/models/ir_mail_server.py +++ b/odoo/addons/base/models/ir_mail_server.py @@ -133,8 +133,8 @@ class IrMailServer(models.Model): name = fields.Char(string='Description', required=True, index=True) smtp_host = fields.Char(string='SMTP Server', required=True, help="Hostname or IP of SMTP server") smtp_port = fields.Integer(string='SMTP Port', size=5, required=True, default=25, help="SMTP Port. Usually 465 for SSL, and 25 or 587 for other cases.") - smtp_user = fields.Char(string='Username', help="Optional username for SMTP authentication") - smtp_pass = fields.Char(string='Password', help="Optional password for SMTP authentication") + smtp_user = fields.Char(string='Username', help="Optional username for SMTP authentication", groups='base.group_system') + smtp_pass = fields.Char(string='Password', help="Optional password for SMTP authentication", groups='base.group_system') smtp_encryption = fields.Selection([('none', 'None'), ('starttls', 'TLS (STARTTLS)'), ('ssl', 'SSL/TLS')],