From fd513bd25bae236cfab96c3a49f04a7227f8ce9b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thibault=20Delavall=C3=A9e?= Date: Tue, 24 Jan 2023 15:11:39 +0000 Subject: [PATCH] [FIX] account: make sending of invoice send emails deterministic Using a set for langs means ordering is not deterministic. Having deterministic processes is better for debug and testing. Use a sorted to ensure ordering of langs iterable. Task-2088884 (Mail: Use editable computed stored fields in composer) Task-3149286 (Account: cleanup account.invoice.send wizard) X-original-commit: odoo/odoo@d903424 Part-of: odoo/odoo#110919 --- addons/account/wizard/account_invoice_send.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/account/wizard/account_invoice_send.py b/addons/account/wizard/account_invoice_send.py index dc26934f055..ccf4863cdcb 100644 --- a/addons/account/wizard/account_invoice_send.py +++ b/addons/account/wizard/account_invoice_send.py @@ -144,7 +144,7 @@ class AccountInvoiceSend(models.TransientModel): active_records = self.env[self.model].browse(active_ids) langs = active_records.mapped('partner_id.lang') default_lang = get_lang(self.env) - for lang in (set(langs) or [default_lang]): + for lang in sorted((set(langs)) or [default_lang]): active_ids_lang = active_records.filtered(lambda r: r.partner_id.lang == lang).ids self_lang = self.with_context( composer_force_res_ids=active_ids_lang,