From fd23d93be2fadc2ac4495b4db746f13cb65b4d94 Mon Sep 17 00:00:00 2001 From: Yannick Tivisse Date: Tue, 18 Dec 2018 15:03:33 +0000 Subject: [PATCH] [IMP] hr_payroll_account: Don't erase journal_id if already set If the journal_id is already set on the payslip and if there are no journal_id on the contract, don't erase the value on the onchange method closes odoo/odoo#29616 --- addons/hr_payroll_account/models/hr_payroll_account.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/hr_payroll_account/models/hr_payroll_account.py b/addons/hr_payroll_account/models/hr_payroll_account.py index 1e21ae1a83a..25188a4dc40 100644 --- a/addons/hr_payroll_account/models/hr_payroll_account.py +++ b/addons/hr_payroll_account/models/hr_payroll_account.py @@ -42,7 +42,7 @@ class HrPayslip(models.Model): @api.onchange('contract_id') def onchange_contract(self): super(HrPayslip, self).onchange_contract() - self.journal_id = self.contract_id.journal_id.id or (not self.contract_id and self.default_get(['journal_id'])['journal_id']) + self.journal_id = self.contract_id.journal_id.id or self.default_get(['journal_id'])['journal_id'] @api.multi def action_payslip_cancel(self):