From fd1dfe57bfe47b908b8b1ef080c57abcb50c5834 Mon Sep 17 00:00:00 2001
From: Denis Ledoux <dle@odoo.com>
Date: Fri, 29 Jul 2022 13:01:48 +0000
Subject: [PATCH] [IMP] stock: remove groups_id of
 product_template_form_view_procurement_button

Part-of: odoo/odoo#98551
---
 addons/stock/views/product_views.xml | 165 ++++++++++++++-------------
 1 file changed, 83 insertions(+), 82 deletions(-)

diff --git a/addons/stock/views/product_views.xml b/addons/stock/views/product_views.xml
index 182d3a06ac4..3f4cd347f6b 100644
--- a/addons/stock/views/product_views.xml
+++ b/addons/stock/views/product_views.xml
@@ -343,7 +343,6 @@
         <record model="ir.ui.view" id="product_template_form_view_procurement_button">
             <field name="name">product.template_procurement</field>
             <field name="model">product.template</field>
-            <field name="groups_id" eval="[(4, ref('stock.group_stock_user'))]"/>
             <field name="inherit_id" ref="product.product_template_only_form_view"/>
             <field name="priority" eval="15"/>
             <field name="arch" type="xml">
@@ -360,90 +359,92 @@
                             attrs="{'invisible': [('type', 'not in', ['consu', 'product'])]}"/>
                     </header>
                     <div name="button_box" position="inside">
-                        <field name="tracking" invisible="1"/>
-                        <field name="show_on_hand_qty_status_button" invisible="1"/>
-                        <field name="show_forecasted_qty_status_button" invisible="1"/>
-                        <button type="object"
-                            name="action_open_quants"
-                            attrs="{'invisible':[('show_on_hand_qty_status_button', '=', False)]}"
-                            class="oe_stat_button" icon="fa-cubes">
-                            <div class="o_field_widget o_stat_info">
-                                <span class="o_stat_value" widget="statinfo">
-                                    <field name="qty_available" widget="statinfo" nolabel="1" class="mr4"/>
-                                    <field name="uom_name"/>
-                                </span>
-                                <span class="o_stat_text">On Hand</span>
-                            </div>
-                        </button>
-                        <button type="object"
-                            name="action_product_tmpl_forecast_report"
-                            attrs="{'invisible':[('show_forecasted_qty_status_button', '=', False)]}"
-                            context="{'default_product_tmpl_id': id}"
-                            class="oe_stat_button" icon="fa-cubes">
-                            <div class="o_field_widget o_stat_info">
-                                <span class="o_stat_value">
-                                    <field name="virtual_available" widget="statinfo" nolabel="1" class="mr4"/>
-                                    <field name="uom_name"/>
-                                </span>
-                                <span class="o_stat_text">Forecasted</span>
-                            </div>
-                        </button>
-                        <button type="object"
-                            name= "action_view_stock_move_lines"
-                            attrs="{'invisible':[('type', 'not in', ['product', 'consu'])]}"
-                            class="oe_stat_button" icon="fa-exchange"
-                            groups="stock.group_stock_user">
-                            <div class="o_field_widget o_stat_info mr4">
-                                <span class="o_stat_text">In:</span>
-                                <span class="o_stat_text">Out:</span>
-                            </div>
-                            <div class="o_field_widget o_stat_info">
-                                <span class="o_stat_value"><field name="nbr_moves_in"/></span>
-                                <span class="o_stat_value"><field name="nbr_moves_out"/></span>
-                            </div>
-                        </button>
-                        <button type="object"
-                            name="action_view_orderpoints"
-                            attrs="{'invisible':['|',('type', '!=', 'product'),('nbr_reordering_rules', '!=', 1)]}"
-                            class="oe_stat_button" icon="fa-refresh">
-                            <div class="o_field_widget o_stat_info mr4">
-                                <span class="o_stat_text">Min:</span>
-                                <span class="o_stat_text">Max:</span>
-                            </div>
-                            <div class="o_field_widget o_stat_info">
-                                <span class="o_stat_value"><field name="reordering_min_qty"/></span>
-                                <span class="o_stat_value"><field name="reordering_max_qty"/></span>
-                            </div>
-                        </button>
-                        <button type="object"
-                            name="action_view_orderpoints"
-                            attrs="{'invisible':['|',('type', '!=', 'product'),('nbr_reordering_rules', '==', 1)]}"
-                            class="oe_stat_button"
-                            icon="fa-refresh">
-                            <field name="nbr_reordering_rules" widget="statinfo"/>
-                         </button>
-                        <button string="Lot/Serial Numbers" type="object"
-                            name="action_open_product_lot"
-                            attrs="{'invisible': [('tracking', '=', 'none')]}"
-                            class="oe_stat_button" icon="fa-bars" groups="stock.group_production_lot"/>
-                        <button string="Putaway Rules" type="object"
-                            name="action_view_related_putaway_rules"
-                            class="oe_stat_button" icon="fa-random" groups="stock.group_stock_multi_locations"
-                            attrs="{'invisible': [('type', '=', 'service')]}"
-                            context="{
-                                'invisible_handle': True,
-                                'single_product': product_variant_count == 1,
-                            }"/>
-                        <button type="object" string="Storage Capacities"
-                            name="action_view_storage_category_capacity"
-                            groups="stock.group_stock_storage_categories"
-                            attrs="{'invisible':[('type', '=', 'service')]}"
-                            class="oe_stat_button"
-                            icon="fa-cubes"/>
+                        <t groups="stock.group_stock_user">
+                            <field name="tracking" invisible="1"/>
+                            <field name="show_on_hand_qty_status_button" invisible="1"/>
+                            <field name="show_forecasted_qty_status_button" invisible="1"/>
+                            <button type="object"
+                                name="action_open_quants"
+                                attrs="{'invisible':[('show_on_hand_qty_status_button', '=', False)]}"
+                                class="oe_stat_button" icon="fa-cubes">
+                                <div class="o_field_widget o_stat_info">
+                                    <span class="o_stat_value" widget="statinfo">
+                                        <field name="qty_available" widget="statinfo" nolabel="1" class="mr4"/>
+                                        <field name="uom_name"/>
+                                    </span>
+                                    <span class="o_stat_text">On Hand</span>
+                                </div>
+                            </button>
+                            <button type="object"
+                                name="action_product_tmpl_forecast_report"
+                                attrs="{'invisible':[('show_forecasted_qty_status_button', '=', False)]}"
+                                context="{'default_product_tmpl_id': id}"
+                                class="oe_stat_button" icon="fa-cubes">
+                                <div class="o_field_widget o_stat_info">
+                                    <span class="o_stat_value">
+                                        <field name="virtual_available" widget="statinfo" nolabel="1" class="mr4"/>
+                                        <field name="uom_name"/>
+                                    </span>
+                                    <span class="o_stat_text">Forecasted</span>
+                                </div>
+                            </button>
+                            <button type="object"
+                                name= "action_view_stock_move_lines"
+                                attrs="{'invisible':[('type', 'not in', ['product', 'consu'])]}"
+                                class="oe_stat_button" icon="fa-exchange"
+                                groups="stock.group_stock_user">
+                                <div class="o_field_widget o_stat_info mr4">
+                                    <span class="o_stat_text">In:</span>
+                                    <span class="o_stat_text">Out:</span>
+                                </div>
+                                <div class="o_field_widget o_stat_info">
+                                    <span class="o_stat_value"><field name="nbr_moves_in"/></span>
+                                    <span class="o_stat_value"><field name="nbr_moves_out"/></span>
+                                </div>
+                            </button>
+                            <button type="object"
+                                name="action_view_orderpoints"
+                                attrs="{'invisible':['|',('type', '!=', 'product'),('nbr_reordering_rules', '!=', 1)]}"
+                                class="oe_stat_button" icon="fa-refresh">
+                                <div class="o_field_widget o_stat_info mr4">
+                                    <span class="o_stat_text">Min:</span>
+                                    <span class="o_stat_text">Max:</span>
+                                </div>
+                                <div class="o_field_widget o_stat_info">
+                                    <span class="o_stat_value"><field name="reordering_min_qty"/></span>
+                                    <span class="o_stat_value"><field name="reordering_max_qty"/></span>
+                                </div>
+                            </button>
+                            <button type="object"
+                                name="action_view_orderpoints"
+                                attrs="{'invisible':['|',('type', '!=', 'product'),('nbr_reordering_rules', '==', 1)]}"
+                                class="oe_stat_button"
+                                icon="fa-refresh">
+                                <field name="nbr_reordering_rules" widget="statinfo"/>
+                            </button>
+                            <button string="Lot/Serial Numbers" type="object"
+                                name="action_open_product_lot"
+                                attrs="{'invisible': [('tracking', '=', 'none')]}"
+                                class="oe_stat_button" icon="fa-bars" groups="stock.group_production_lot"/>
+                            <button string="Putaway Rules" type="object"
+                                name="action_view_related_putaway_rules"
+                                class="oe_stat_button" icon="fa-random" groups="stock.group_stock_multi_locations"
+                                attrs="{'invisible': [('type', '=', 'service')]}"
+                                context="{
+                                    'invisible_handle': True,
+                                    'single_product': product_variant_count == 1,
+                                }"/>
+                            <button type="object" string="Storage Capacities"
+                                name="action_view_storage_category_capacity"
+                                groups="stock.group_stock_storage_categories"
+                                attrs="{'invisible':[('type', '=', 'service')]}"
+                                class="oe_stat_button"
+                                icon="fa-cubes"/>
+                        </t>
                     </div>
 
                     <xpath expr="//label[@for='weight']" position="before">
-                        <field name="responsible_id" domain="[('share', '=', False)]" widget="many2one_avatar_user"/>
+                        <field name="responsible_id" domain="[('share', '=', False)]" widget="many2one_avatar_user" groups="stock.group_stock_user"/>
                     </xpath>
                 </data>
             </field>