From fc90b208c34dd77fc95e4996ffa252376a160f68 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Luis=20Gonz=C3=A1lez?= <lgonzalez@vauxoo.com>
Date: Sun, 18 Oct 2020 00:31:19 +0000
Subject: [PATCH] [IMP] sale_management: Non-deterministic elements in views
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

There are currently some elements in views that are not reachable on a
deterministic way when those views are inherited. That means, to reach
them, positional selectors need to be used (e.g. `last()`). That causes
inherited views to get broken when there are small changes in element
position.

A good example of this is [1]:

    <th class="text-right">Unit Price</th>

Which can't be filtered by:
- Class, because there are several `<th>` elements with the same class
- Text content, because when content is translated, selector will fail

To solve the above, this change provides IDs for several elements, to make
possible/easier to reach them on a safely manner.

[1] https://github.com/odoo/odoo/blob/54b40f1eb096/addons/sale_management/report/sale_report_templates.xml#L15

closes odoo/odoo#60388

X-original-commit: 746bacf680c74603f63f7b46304b8fb364e0d60e
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Signed-off-by: Luis González [Vauxoo] <luisg123v@users.noreply.github.com>
---
 .../report/sale_report_templates.xml             | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/addons/sale_management/report/sale_report_templates.xml b/addons/sale_management/report/sale_report_templates.xml
index 4979a49b8b4..0816394738c 100644
--- a/addons/sale_management/report/sale_report_templates.xml
+++ b/addons/sale_management/report/sale_report_templates.xml
@@ -4,28 +4,28 @@
     <xpath expr="//div[@name='signature']" position="after">
         <div t-if="doc.sale_order_option_ids and doc.state in ['draft', 'sent']">
             <t t-set="has_option_discount" t-value="any(option.discount != 0.0 for option in doc.sale_order_option_ids)" />
-            <h4>
+            <h4 name="h_optional_products">
                 <span>Options</span>
             </h4>
-            <table class="table table-sm">
+            <table name="table_optional_products" class="table table-sm">
                 <thead>
                     <tr>
-                        <th class="text-left">Description</th>
-                        <th t-if="has_option_discount" groups="product.group_discount_per_so_line" class="text-left">Disc.%</th>
-                        <th class="text-right">Unit Price</th>
+                        <th name="th_option_name" class="text-left">Description</th>
+                        <th t-if="has_option_discount" name="th_option_discount" groups="product.group_discount_per_so_line" class="text-left">Disc.%</th>
+                        <th name="th_option_price_unit" class="text-right">Unit Price</th>
                     </tr>
                 </thead>
                 <tbody class="sale_tbody">
                     <tr t-foreach="doc.sale_order_option_ids" t-as="option">
-                        <td>
+                        <td name="td_option_name">
                             <span t-field="option.name"/>
                         </td>
-                        <td t-if="has_option_discount" groups="product.group_discount_per_so_line">
+                        <td t-if="has_option_discount" name="td_option_discount" groups="product.group_discount_per_so_line">
                             <strong t-if="option.discount != 0.0" class="text-info">
                                 <t t-esc="((option.discount % 1) and '%s' or '%d') % option.discount"/>%
                             </strong>
                         </td>
-                        <td>
+                        <td name="td_option_price_unit">
                             <strong class="text-right">
                                 <div t-field="option.price_unit"
                                     t-options='{"widget": "monetary", "display_currency": doc.pricelist_id.currency_id}'