From fc348de003baf5040715145bf16ed9d4918b33e7 Mon Sep 17 00:00:00 2001
From: mir-odoo <mir@odoo.com>
Date: Tue, 22 Dec 2020 13:22:36 +0000
Subject: [PATCH] [IMP] various:  Do not allow create/open on country_id

Purpose of the task, is to prevent users from inadvertently
creation/opening countries from country_id fields.
Countries should be managed from their dedicated menu item.

so in this commit, we have set both no_open and no_create to True
so user should not update and create a country from the many2X fields.

closes odoo/odoo#63773

Taskid: 2241677
Related: odoo/enterprise#15464
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
---
 addons/account/views/account_account_tag_views.xml       | 2 +-
 addons/account/views/partner_view.xml                    | 2 +-
 addons/base_address_city/views/res_city_view.xml         | 2 +-
 addons/crm/views/crm_lead_views.xml                      | 4 ++--
 addons/crm/wizard/crm_lead_to_opportunity_mass_views.xml | 2 +-
 addons/crm/wizard/crm_lead_to_opportunity_views.xml      | 2 +-
 addons/crm_iap_lead_website/views/crm_reveal_views.xml   | 2 +-
 addons/delivery/views/delivery_view.xml                  | 2 +-
 addons/im_livechat/views/im_livechat_channel_views.xml   | 2 +-
 addons/link_tracker/views/link_tracker_views.xml         | 2 +-
 addons/mass_mailing/views/mailing_contact_views.xml      | 2 +-
 addons/payment/views/payment_views.xml                   | 2 +-
 odoo/addons/base/views/res_company_views.xml             | 2 +-
 odoo/addons/base/views/res_country_views.xml             | 4 ++--
 14 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/addons/account/views/account_account_tag_views.xml b/addons/account/views/account_account_tag_views.xml
index a459284ea77..732de46759c 100644
--- a/addons/account/views/account_account_tag_views.xml
+++ b/addons/account/views/account_account_tag_views.xml
@@ -14,7 +14,7 @@
                             <field name="name"/>
                             <field name="applicability"/>
                             <field name="tax_negate" attrs="{'invisible': [('applicability', '!=', 'taxes')]}"/>
-                            <field name="country_id" attrs="{'invisible': [('applicability', '!=', 'taxes')]}"/>
+                            <field name="country_id" options="{'no_open': True, 'no_create': True}" attrs="{'invisible': [('applicability', '!=', 'taxes')]}"/>
                             <field name="tax_report_line_ids" attrs="{'invisible': [('applicability', '!=', 'taxes')]}"/>
                         </group>
                     </sheet>
diff --git a/addons/account/views/partner_view.xml b/addons/account/views/partner_view.xml
index b232c4e96bf..4f9b6c9e1e6 100644
--- a/addons/account/views/partner_view.xml
+++ b/addons/account/views/partner_view.xml
@@ -20,7 +20,7 @@
                             <field name="states_count" invisible="1"/>
                             <field name="vat_required" attrs="{'invisible': [('auto_apply', '!=', True)]}"/>
                             <field name="country_group_id" attrs="{'invisible': [('auto_apply', '!=', True)]}"/>
-                            <field name="country_id" attrs="{'invisible': [('auto_apply', '!=', True)]}"/>
+                            <field name="country_id" attrs="{'invisible': [('auto_apply', '!=', True)]}" options="{'no_open': True, 'no_create': True}"/>
                             <field name="state_ids" widget="many2many_tags" domain="[('country_id', '=', country_id)]"
                                 attrs="{'invisible': ['|', '|', ('auto_apply', '!=', True), ('country_id', '=', False), ('states_count', '=', 0)]}"/>
                             <label for="zip_from" string="Zip Range"
diff --git a/addons/base_address_city/views/res_city_view.xml b/addons/base_address_city/views/res_city_view.xml
index 26e77766eb3..ce7a0385061 100644
--- a/addons/base_address_city/views/res_city_view.xml
+++ b/addons/base_address_city/views/res_city_view.xml
@@ -7,7 +7,7 @@
                 <tree string="City" editable="top">
                     <field name="name"/>
                     <field name="zipcode"/>
-                    <field name="country_id"/>
+                    <field name="country_id" options="{'no_open': True, 'no_create': True}"/>
                     <field name="state_id" context="{'default_country_id': country_id}"/>
                 </tree>
             </field>
diff --git a/addons/crm/views/crm_lead_views.xml b/addons/crm/views/crm_lead_views.xml
index c90ef03b4cd..630fef7950c 100644
--- a/addons/crm/views/crm_lead_views.xml
+++ b/addons/crm/views/crm_lead_views.xml
@@ -336,7 +336,7 @@
                     <field name="company_id" groups="base.group_multi_company" optional="show"/>
                     <field name="city" optional="show"/>
                     <field name="state_id" optional="hide"/>
-                    <field name="country_id" optional="show"/>
+                    <field name="country_id" optional="show" options="{'no_open': True, 'no_create': True}"/>
                     <field name="partner_id" invisible="1"/>
                     <field name="user_id" optional="show"  widget="many2one_avatar_user" domain="[('share', '=', False)]"/>
                     <field name="team_id" optional="show"/>
@@ -652,7 +652,7 @@
                     <field name="company_id" groups="base.group_multi_company" optional="show"/>
                     <field name="city" optional="hide"/>
                     <field name="state_id" optional="hide"/>
-                    <field name="country_id" optional="hide"/>
+                    <field name="country_id" optional="hide" options="{'no_open': True, 'no_create': True}"/>
                     <field name="user_id" widget="many2one_avatar_user" optional="show" domain="[('share', '=', False)]"/>
                     <field name="team_id" optional="show"/>
                     <field name="priority" optional="hide"/>
diff --git a/addons/crm/wizard/crm_lead_to_opportunity_mass_views.xml b/addons/crm/wizard/crm_lead_to_opportunity_mass_views.xml
index 8fc3e1a9029..e31aae71c0c 100644
--- a/addons/crm/wizard/crm_lead_to_opportunity_mass_views.xml
+++ b/addons/crm/wizard/crm_lead_to_opportunity_mass_views.xml
@@ -24,7 +24,7 @@
                             <field name="name"/>
                             <field name="type"/>
                             <field name="contact_name"/>
-                            <field name="country_id" invisible="context.get('invisible_country', True)"/>
+                            <field name="country_id" invisible="context.get('invisible_country', True)" options="{'no_open': True, 'no_create': True}"/>
                             <field name="email_from"/>
                             <field name="stage_id"/>
                             <field name="user_id"/>
diff --git a/addons/crm/wizard/crm_lead_to_opportunity_views.xml b/addons/crm/wizard/crm_lead_to_opportunity_views.xml
index 4534e4352cd..23e2ef5d8f6 100644
--- a/addons/crm/wizard/crm_lead_to_opportunity_views.xml
+++ b/addons/crm/wizard/crm_lead_to_opportunity_views.xml
@@ -19,7 +19,7 @@
                             <field name="name"/>
                             <field name="type"/>
                             <field name="contact_name"/>
-                            <field name="country_id" invisible="context.get('invisible_country', True)"/>
+                            <field name="country_id" invisible="context.get('invisible_country', True)" options="{'no_open': True, 'no_create': True}"/>
                             <field name="email_from"/>
                             <field name="stage_id"/>
                             <field name="user_id"/>
diff --git a/addons/crm_iap_lead_website/views/crm_reveal_views.xml b/addons/crm_iap_lead_website/views/crm_reveal_views.xml
index 4d7d30b10d2..43bef26d0f8 100644
--- a/addons/crm_iap_lead_website/views/crm_reveal_views.xml
+++ b/addons/crm_iap_lead_website/views/crm_reveal_views.xml
@@ -33,7 +33,7 @@
                                 <field name="active" widget="boolean_toggle"/>
                             </group>
                             <group string="Website Traffic Conditions">
-                                <field name="country_ids" widget="many2many_tags"/>
+                                <field name="country_ids" widget="many2many_tags" options="{'no_open': True, 'no_create': True}"/>
                                 <field name="website_id" options="{'no_open': True, 'no_create_edit': True}" groups="website.group_multi_website"/>
                                 <field name="state_ids" widget="many2many_tags" attrs="{'invisible': [('country_ids', '=', [])]}" domain="[('country_id', 'in', country_ids)]"/>
                                 <field name="regex_url" widget="website_urls" placeholder="e.g. /page"/>
diff --git a/addons/delivery/views/delivery_view.xml b/addons/delivery/views/delivery_view.xml
index bac707d6121..474ec2b683d 100644
--- a/addons/delivery/views/delivery_view.xml
+++ b/addons/delivery/views/delivery_view.xml
@@ -136,7 +136,7 @@
                                 </group>
                                 <group>
                                     <group name="country_details">
-                                        <field name="country_ids" widget="many2many_tags"/>
+                                        <field name="country_ids" widget="many2many_tags" options="{'no_open': True, 'no_create': True}"/>
                                         <field name="state_ids" widget="many2many_tags"/>
                                     </group>
                                     <group></group>
diff --git a/addons/im_livechat/views/im_livechat_channel_views.xml b/addons/im_livechat/views/im_livechat_channel_views.xml
index 8604a205a33..fba72c7724c 100644
--- a/addons/im_livechat/views/im_livechat_channel_views.xml
+++ b/addons/im_livechat/views/im_livechat_channel_views.xml
@@ -239,7 +239,7 @@
                             <div class="oe_inline" attrs="{'invisible': [('action', '!=', 'auto_popup')]}">
                                 <field name="auto_popup_timer" class="oe_inline"/> seconds
                             </div>
-                            <field name="country_ids" widget="many2many_tags"/>
+                            <field name="country_ids" widget="many2many_tags" options="{'no_open': True, 'no_create': True}"/>
                         </group>
                     </sheet>
                 </form>
diff --git a/addons/link_tracker/views/link_tracker_views.xml b/addons/link_tracker/views/link_tracker_views.xml
index 8999a5de34e..0637f41442e 100644
--- a/addons/link_tracker/views/link_tracker_views.xml
+++ b/addons/link_tracker/views/link_tracker_views.xml
@@ -120,7 +120,7 @@
                         <group>
                             <field name="link_id"/>
                             <field name="ip"/>
-                            <field name="country_id"/>
+                            <field name="country_id" options="{'no_open': True, 'no_create': True}"/>
                         </group>
                     </sheet>
                 </form>
diff --git a/addons/mass_mailing/views/mailing_contact_views.xml b/addons/mass_mailing/views/mailing_contact_views.xml
index a9b7d712bca..aa61a3370f7 100644
--- a/addons/mass_mailing/views/mailing_contact_views.xml
+++ b/addons/mass_mailing/views/mailing_contact_views.xml
@@ -177,7 +177,7 @@
                             </div>
                             <field name="title_id"/>
                             <field name="company_name"/>
-                            <field name="country_id"/>
+                            <field name="country_id" options="{'no_open': True, 'no_create': True}"/>
                         </group>
                         <group>
                             <field name="create_date" readonly="1"/>
diff --git a/addons/payment/views/payment_views.xml b/addons/payment/views/payment_views.xml
index 9925b8d1a86..735c069fe66 100644
--- a/addons/payment/views/payment_views.xml
+++ b/addons/payment/views/payment_views.xml
@@ -56,7 +56,7 @@
                                         <field name="qr_code" attrs="{'invisible': [('provider', '!=', 'transfer')]}"/>
                                     </group>
                                     <group string="Availability" name="availability">
-                                        <field name="country_ids" widget="many2many_tags" placeholder="Select countries. Leave empty to use everywhere."/>
+                                        <field name="country_ids" widget="many2many_tags" placeholder="Select countries. Leave empty to use everywhere." options="{'no_open': True, 'no_create': True}"/>
                                     </group>
                                     <group string="Payment Followup" name="payment_followup">
                                         <field name="journal_id" context="{'default_type': 'bank'}"
diff --git a/odoo/addons/base/views/res_company_views.xml b/odoo/addons/base/views/res_company_views.xml
index 5977b0ffb57..ca7b60fc302 100644
--- a/odoo/addons/base/views/res_company_views.xml
+++ b/odoo/addons/base/views/res_company_views.xml
@@ -26,7 +26,7 @@
                                         <field name="city" placeholder="City" class="o_address_city"/>
                                         <field name="state_id" class="o_address_state" placeholder="State" options='{"no_open": True}'/>
                                         <field name="zip" placeholder="ZIP" class="o_address_zip"/>
-                                        <field name="country_id" placeholder="Country" class="o_address_country" options='{"no_open": True}'/>
+                                        <field name="country_id" placeholder="Country" class="o_address_country" options='{"no_open": True, "no_create": True}'/>
                                     </div>
                                     <field name="vat"/>
                                     <field name="company_registry"/>
diff --git a/odoo/addons/base/views/res_country_views.xml b/odoo/addons/base/views/res_country_views.xml
index 00fd602556b..d6763d56c10 100644
--- a/odoo/addons/base/views/res_country_views.xml
+++ b/odoo/addons/base/views/res_country_views.xml
@@ -84,7 +84,7 @@
                             <h1><field name="name"/></h1>
                         </div>
                         <group name="country_group">
-                            <field name="country_ids" widget="many2many_tags"/>
+                            <field name="country_ids" widget="many2many_tags" options="{'no_open': True, 'no_create': True}"/>
                         </group>
                     </sheet>
                 </form>
@@ -106,7 +106,7 @@
                 <tree string="State" editable="bottom">
                     <field name="name"/>
                     <field name="code"/>
-                    <field name="country_id" options="{'no_create': True}"/>
+                    <field name="country_id" options="{'no_create': True, 'no_open': True}"/>
                 </tree>
             </field>
         </record>