From fb9da2acbb5b668dfc2236f01a6e2ca37e07b7a6 Mon Sep 17 00:00:00 2001
From: ilru-odoo <ilru@odoo.com>
Date: Wed, 31 Jan 2024 13:16:16 +0100
Subject: [PATCH] [FIX] website_sale: title on non done confirmation

**Issue Description**:
Users encounter a misleading confirmation page when a payment is canceled or fails in version 17.0 and higher of our website. Specifically, upon a payment error, users are directed to /payment/status with an error message. However, selecting the "Skip" button redirects them to a confirmation page titled "Thank you for your order", suggesting successful payment. This misleading information can lead to confusion, especially since it results in the card being cleared for public users despite non-receipt of payment.

**Steps to Reproduce**:
1. Navigate to the 'Shop' section of the website, add a product to the cart, and proceed to checkout.
2. Click the "Pay with demo".
3. Select "Canceled" as the Payment Status and then "Pay".
3. Click the "Skip" button during the payment process.
4. Observe redirection to a confirmation page with the title "Thank you for your order", implying successful transaction.

**Proposed Solution**:
This issue, present in versions 17.0 and later, is due to a modification in the <template id="confirmation">, where the "Thank you for your order" title is now displayed regardless of the payment state. To resolve this, we propose introducing a conditional check to display this title when the payment state is "pending" or "done", ensuring accurate representation of the transaction status.

opw-3688785

closes odoo/odoo#151304

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
---
 addons/website_sale/views/templates.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/addons/website_sale/views/templates.xml b/addons/website_sale/views/templates.xml
index f2753279c2f..dd15cf89db8 100644
--- a/addons/website_sale/views/templates.xml
+++ b/addons/website_sale/views/templates.xml
@@ -2347,11 +2347,11 @@
                 <div class="oe_structure" id="oe_structure_website_sale_confirmation_3"/>
             </t>
 
-            <div class="d-flex justify-content-between align-items-center">
+            <t t-set="tx_sudo" t-value="order.get_portal_last_transaction()"/>
+            <div t-if="tx_sudo.state in ['pending', 'done']" class="d-flex justify-content-between align-items-center">
                 <h3>Thank you for your order.</h3>
                 <a role="button" class="d-none d-md-inline-block btn btn-primary ms-auto" href="/shop/print" target="_blank" aria-label="Print" title="Print"><i class="fa fa-print me-2"></i>Print</a>
             </div>
-            <t t-set="tx_sudo" t-value="order.get_portal_last_transaction()"/>
             <t t-if="tx_sudo.state == 'done'">
                 <div class="mb-4">
                     <h5>