From faf5fa102212da5ab66426d5539ac5c68da4e5c8 Mon Sep 17 00:00:00 2001 From: std-odoo Date: Thu, 31 Aug 2023 13:11:57 +0200 Subject: [PATCH] [IMP] web: add tests related to the "group by y properties" feature Purpose ======= Add tests about the group by properties feature, the drag and drop and the behavior in the pivot view. Task-3032464 Part-of: odoo/odoo#103510 --- .../tests/views/kanban/kanban_view_tests.js | 141 ++++++++++++++++++ .../static/tests/views/pivot_view_tests.js | 120 +++++++++++++++ 2 files changed, 261 insertions(+) diff --git a/addons/web/static/tests/views/kanban/kanban_view_tests.js b/addons/web/static/tests/views/kanban/kanban_view_tests.js index c68e63b28a7..53a0ea71be1 100644 --- a/addons/web/static/tests/views/kanban/kanban_view_tests.js +++ b/addons/web/static/tests/views/kanban/kanban_view_tests.js @@ -209,6 +209,23 @@ QUnit.module("Views", (hooks) => { default: 1, }, salary: { string: "Monetary field", type: "monetary" }, + properties: { + string: "Properties", + type: "properties", + definition_record: "parent_id", + definition_record_field: "properties_definition", + name: "properties", + }, + parent_id: { + string: "Parent", + type: "many2one", + relation: "partner", + name: "parent_id", + }, + properties_definition: { + string: "Properties", + type: "properties_definition", + }, }, records: [ { @@ -223,6 +240,13 @@ QUnit.module("Views", (hooks) => { image: "R0lGODlhAQABAAD/ACwAAAAAAQABAAACAA==", salary: 1750, currency_id: 1, + properties_definition: [ + { + name: "my_char", + string: "My Char", + type: "char", + }, + ], }, { id: 2, @@ -235,6 +259,15 @@ QUnit.module("Views", (hooks) => { category_ids: [6], salary: 1500, currency_id: 1, + parent_id: 1, + properties: [ + { + name: "my_char", + string: "My Char", + type: "char", + value: "aaa", + }, + ], }, { id: 3, @@ -247,6 +280,15 @@ QUnit.module("Views", (hooks) => { category_ids: [7], salary: 2000, currency_id: 2, + parent_id: 1, + properties: [ + { + name: "my_char", + string: "My Char", + type: "char", + value: "bbb", + }, + ], }, { id: 4, @@ -259,6 +301,7 @@ QUnit.module("Views", (hooks) => { category_ids: [], salary: 2222, currency_id: 1, + parent_id: 2, }, ], }, @@ -13826,4 +13869,102 @@ QUnit.module("Views", (hooks) => { ); } ); + + QUnit.test("group by properties and drag and drop", async (assert) => { + assert.expect(10); + + await makeView({ + type: "kanban", + resModel: "partner", + serverData, + arch: ` + + + +
+ + +
+ + + `, + groupBy: ["properties.my_char"], + async mockRPC(route, args) { + if (route === "/web/dataset/call_kw/partner/web_read_group") { + return { + groups: [ + { + "properties.my_char": false, + __domain: [["properties.my_char", "=", false]], + "properties.my_char_count": 2, + }, + { + "properties.my_char": "aaa", + __domain: [["properties.my_char", "=", "aaa"]], + "properties.my_char_count": 1, + }, + { + "properties.my_char": "bbb", + __domain: [["properties.my_char", "=", "bbb"]], + "properties.my_char_count": 1, + }, + ], + length: 3, + }; + } else if (route === "/web/dataset/call_kw/partner/web_search_read") { + const value = args.kwargs.domain[0][2]; + return { + length: 1, + records: [ + { + id: value === "aaa" ? 2 : 3, + properties: [ + { + name: "my_char", + string: "My Char", + type: "char", + value: value, + }, + ], + }, + ], + }; + } else if (route === "/web/dataset/resequence") { + assert.step("resequence"); + } else if (route === "/web/dataset/call_kw/partner/web_save") { + assert.step("web_save"); + const expected = { + properties: [ + { + name: "my_char", + string: "My Char", + type: "char", + value: "bbb", + }, + ], + }; + assert.deepEqual(args.args[1], expected); + } else if (route === "/web/dataset/call_kw/partner/get_property_definition") { + assert.step("get_property_definition"); + return { + name: "my_char", + type: "char", + }; + } + }, + }); + + assert.verifySteps(["get_property_definition"]); + assert.containsN(target, ".o_kanban_group:nth-child(2) .o_kanban_record", 1); + assert.containsN(target, ".o_kanban_group:nth-child(3) .o_kanban_record", 1); + + await dragAndDrop( + ".o_kanban_group:nth-child(2) .o_kanban_record", + ".o_kanban_group:nth-child(3)" + ); + + assert.verifySteps(["web_save", "resequence"]); + assert.containsN(target, ".o_kanban_group:nth-child(2) .o_kanban_record", 0); + assert.containsN(target, ".o_kanban_group:nth-child(3) .o_kanban_record", 2); + }); }); diff --git a/addons/web/static/tests/views/pivot_view_tests.js b/addons/web/static/tests/views/pivot_view_tests.js index add9e8c1a66..e744a3fe4c9 100644 --- a/addons/web/static/tests/views/pivot_view_tests.js +++ b/addons/web/static/tests/views/pivot_view_tests.js @@ -125,6 +125,23 @@ QUnit.module("Views", (hooks) => { ], group_operator: "count_distinct", }, + properties: { + string: "Properties", + type: "properties", + definition_record: "parent_id", + definition_record_field: "properties_definition", + name: "properties", + }, + parent_id: { + string: "Parent", + type: "many2one", + relation: "partner", + name: "parent_id", + }, + properties_definition: { + string: "Properties", + type: "properties_definition", + }, }, records: [ { @@ -137,6 +154,13 @@ QUnit.module("Views", (hooks) => { computed_field: 19, company_type: "company", ref: "product,37", + properties_definition: [ + { + name: "my_char", + string: "My Char", + type: "char", + }, + ], }, { id: 2, @@ -148,6 +172,15 @@ QUnit.module("Views", (hooks) => { computed_field: 23, company_type: "individual", ref: "product,41", + parent_id: 1, + properties: [ + { + name: "my_char", + string: "My Char", + type: "char", + value: "aaa", + }, + ], }, { id: 3, @@ -159,6 +192,15 @@ QUnit.module("Views", (hooks) => { computed_field: 26, company_type: "company", ref: "customer,1", + parent_id: 1, + properties: [ + { + name: "my_char", + string: "My Char", + type: "char", + value: "bbb", + }, + ], }, { id: 4, @@ -5636,4 +5678,82 @@ QUnit.module("Views", (hooks) => { assert.containsNone(target, ".o_pivot_view table"); } ); + + QUnit.test("group by properties in pivot view", async function (assert) { + assert.expect(18); + + await makeView({ + type: "pivot", + resModel: "partner", + serverData, + arch: "", + searchViewArch: ` + + + + `, + mockRPC(route, args) { + if ( + route === "/web/dataset/call_kw/partner/web_search_read" && + args.kwargs.specification?.properties_definition + ) { + assert.step("fetch_definition"); + } else if ( + route === "/web/dataset/call_kw/partner/read_group" && + args.kwargs.groupby?.includes("properties.my_char") + ) { + assert.step("read_group"); + return [ + { + "properties.my_char": false, + __domain: [["properties.my_char", "=", false]], + __count: 2, + }, + { + "properties.my_char": "aaa", + __domain: [["properties.my_char", "=", "aaa"]], + __count: 1, + }, + { + "properties.my_char": "bbb", + __domain: [["properties.my_char", "=", "bbb"]], + __count: 1, + }, + ]; + } + }, + }); + + assert.strictEqual(target.querySelectorAll(".o_value").length, 1); + assert.strictEqual(target.querySelector(".o_value").innerText, "4"); + + await click(target, ".border-top-0 span"); + assert.verifySteps([]); + + const propertiesItem = target.querySelector(".o_accordion_toggle"); + assert.ok(propertiesItem); + assert.strictEqual(propertiesItem.innerText, "Properties"); + await click(propertiesItem); + + await nextTick(); + assert.verifySteps(["fetch_definition"]); + + await click(target, ".o_accordion_values .o_menu_item"); + + await nextTick(); + assert.verifySteps(["read_group"]); + + const cells = target.querySelectorAll(".o_value"); + assert.strictEqual(cells.length, 4); + assert.strictEqual(cells[0].innerText, "2"); + assert.strictEqual(cells[1].innerText, "1"); + assert.strictEqual(cells[2].innerText, "1"); + assert.strictEqual(cells[3].innerText, "4"); + + const columns = target.querySelectorAll(".o_pivot_header_cell_closed"); + assert.strictEqual(columns.length, 4); + assert.strictEqual(columns[0].innerText, "None"); + assert.strictEqual(columns[1].innerText, "aaa"); + assert.strictEqual(columns[2].innerText, "bbb"); + }); });