From ba6342174e4574c11aa273c9cdfa1e040d50f0b4 Mon Sep 17 00:00:00 2001 From: Raphael Collet Date: Tue, 2 Aug 2011 15:08:11 +0200 Subject: [PATCH 1/3] add group implications bzr revid: rco@openerp.com-20110802130811-pkdmw43ufifz0tpj --- addons/account/security/account_security.xml | 3 ++- .../security/account_payment_security.xml | 3 +++ addons/auction/security/auction_security.xml | 9 +++++---- addons/crm/security/crm_security.xml | 12 +++++++----- addons/event/security/event_security.xml | 9 +++++---- addons/hr/security/hr_security.xml | 9 +++++---- addons/idea/security/idea_security.xml | 17 +++++++++-------- addons/lunch/security/lunch_security.xml | 15 ++++++++------- .../marketing/security/marketing_security.xml | 5 +++-- addons/mrp/security/mrp_security.xml | 7 ++++--- .../security/point_of_sale_security.xml | 8 +++++--- addons/portal/security/portal_security.xml | 9 +++++---- addons/project/security/project_security.xml | 9 +++++---- .../purchase/security/purchase_security.xml | 9 +++++---- .../security/purchase_tender.xml | 9 +++++---- addons/sale/security/sale_security.xml | 11 +++++++---- addons/stock/security/stock_security.xml | 7 ++++--- .../security/subcription_security.xml | 15 ++++++++------- addons/survey/security/survey_security.xml | 19 ++++++++++--------- 19 files changed, 105 insertions(+), 80 deletions(-) diff --git a/addons/account/security/account_security.xml b/addons/account/security/account_security.xml index 8a84ad47fc6..5c4c9a0a525 100644 --- a/addons/account/security/account_security.xml +++ b/addons/account/security/account_security.xml @@ -4,12 +4,13 @@ Accounting / Invoicing & Payments - Accounting / Accountant + Accounting / Manager + diff --git a/addons/account_payment/security/account_payment_security.xml b/addons/account_payment/security/account_payment_security.xml index 872d9d02a92..4bae0c30ce6 100644 --- a/addons/account_payment/security/account_payment_security.xml +++ b/addons/account_payment/security/account_payment_security.xml @@ -5,6 +5,9 @@ Accounting / Payments + + + Payment Mode company rule diff --git a/addons/auction/security/auction_security.xml b/addons/auction/security/auction_security.xml index 1fc69bb314f..3caf93a2430 100644 --- a/addons/auction/security/auction_security.xml +++ b/addons/auction/security/auction_security.xml @@ -2,12 +2,13 @@ - - Auction / Manager - Auction / User + + Auction / Manager + + - \ No newline at end of file + diff --git a/addons/crm/security/crm_security.xml b/addons/crm/security/crm_security.xml index 78018a4031b..e063b9f41be 100644 --- a/addons/crm/security/crm_security.xml +++ b/addons/crm/security/crm_security.xml @@ -2,16 +2,18 @@ - - Sales / Manager + + Sales / User - All Leads - Sales / User + Sales / User - Own Leads Only + - - Sales / User - See All Leads + + Sales / Manager + diff --git a/addons/event/security/event_security.xml b/addons/event/security/event_security.xml index 648662911d2..c3c70c94d93 100644 --- a/addons/event/security/event_security.xml +++ b/addons/event/security/event_security.xml @@ -2,14 +2,15 @@ - - Marketing / Manager - - Marketing / User + + Marketing / Manager + + + Sales / Manager diff --git a/addons/hr/security/hr_security.xml b/addons/hr/security/hr_security.xml index aba7d4b45e1..aadadd224e9 100644 --- a/addons/hr/security/hr_security.xml +++ b/addons/hr/security/hr_security.xml @@ -2,12 +2,13 @@ - - Human Resources / Manager - - Human Resources / Officer + + Human Resources / Manager + + + diff --git a/addons/idea/security/idea_security.xml b/addons/idea/security/idea_security.xml index 4b060c51e6c..344cbc64292 100644 --- a/addons/idea/security/idea_security.xml +++ b/addons/idea/security/idea_security.xml @@ -1,14 +1,15 @@ - + - - Tools / Manager - - - Tools / User - + + Tools / User + + + Tools / Manager + + - + diff --git a/addons/lunch/security/lunch_security.xml b/addons/lunch/security/lunch_security.xml index e042ac0c594..e84cdb41c0d 100644 --- a/addons/lunch/security/lunch_security.xml +++ b/addons/lunch/security/lunch_security.xml @@ -2,12 +2,13 @@ - - Tools / Manager - - - Tools / User - - + + Tools / User + + + Tools / Manager + + + diff --git a/addons/marketing/security/marketing_security.xml b/addons/marketing/security/marketing_security.xml index 06cf40772f4..344e562eb67 100644 --- a/addons/marketing/security/marketing_security.xml +++ b/addons/marketing/security/marketing_security.xml @@ -4,10 +4,11 @@ Marketing / User - + Marketing / Manager + - + diff --git a/addons/mrp/security/mrp_security.xml b/addons/mrp/security/mrp_security.xml index 1cc4c5cea9b..94f79769268 100644 --- a/addons/mrp/security/mrp_security.xml +++ b/addons/mrp/security/mrp_security.xml @@ -2,12 +2,13 @@ - - Manufacturing / Manager - Manufacturing / User + + Manufacturing / Manager + + diff --git a/addons/point_of_sale/security/point_of_sale_security.xml b/addons/point_of_sale/security/point_of_sale_security.xml index 9a90b4d4b6f..14c9e96df9e 100644 --- a/addons/point_of_sale/security/point_of_sale_security.xml +++ b/addons/point_of_sale/security/point_of_sale_security.xml @@ -2,11 +2,13 @@ - - Point of Sale / Manager - Point of Sale / User + + Point of Sale / Manager + + + diff --git a/addons/portal/security/portal_security.xml b/addons/portal/security/portal_security.xml index 015a390cdae..4850cb7805b 100644 --- a/addons/portal/security/portal_security.xml +++ b/addons/portal/security/portal_security.xml @@ -1,13 +1,14 @@ - - Portal / Manager - Portal managers have access to the portal definitions, and can easily configure the users, access rights and menus of portal users. - Portal / Officer Portal officers can create new portal users with the portal wizard. + + Portal / Manager + Portal managers have access to the portal definitions, and can easily configure the users, access rights and menus of portal users. + + diff --git a/addons/project/security/project_security.xml b/addons/project/security/project_security.xml index b51a5a9c89a..62f74f51d1b 100644 --- a/addons/project/security/project_security.xml +++ b/addons/project/security/project_security.xml @@ -2,14 +2,15 @@ - - Project / Manager - - Project / User + + Project / Manager + + + Sales / User diff --git a/addons/purchase/security/purchase_security.xml b/addons/purchase/security/purchase_security.xml index e1149c91466..a67c675b089 100644 --- a/addons/purchase/security/purchase_security.xml +++ b/addons/purchase/security/purchase_security.xml @@ -2,11 +2,12 @@ - - Purchase / Manager - - Purchase / User + Purchases / User + + + Purchases / Manager + diff --git a/addons/purchase_requisition/security/purchase_tender.xml b/addons/purchase_requisition/security/purchase_tender.xml index 595b71008ef..af8a1330e2d 100644 --- a/addons/purchase_requisition/security/purchase_tender.xml +++ b/addons/purchase_requisition/security/purchase_tender.xml @@ -2,14 +2,15 @@ - - Purchase Requisition / Manager - - Purchase Requisition / User + + Purchase Requisition / Manager + + + Purchase Requisition multi-company diff --git a/addons/sale/security/sale_security.xml b/addons/sale/security/sale_security.xml index dc7e2ce3776..ebe5b884537 100644 --- a/addons/sale/security/sale_security.xml +++ b/addons/sale/security/sale_security.xml @@ -2,16 +2,19 @@ - - Sales / Manager + + Sales / User - All Leads + Sales / User - Own Leads Only + - - Sales / User - All Leads + + Sales / Manager + diff --git a/addons/stock/security/stock_security.xml b/addons/stock/security/stock_security.xml index 717486413c6..389d62e8ce0 100644 --- a/addons/stock/security/stock_security.xml +++ b/addons/stock/security/stock_security.xml @@ -2,12 +2,13 @@ - - Warehouse / Manager - Warehouse / User + + Warehouse / Manager + + diff --git a/addons/subscription/security/subcription_security.xml b/addons/subscription/security/subcription_security.xml index 70c648380d5..e84cdb41c0d 100644 --- a/addons/subscription/security/subcription_security.xml +++ b/addons/subscription/security/subcription_security.xml @@ -2,12 +2,13 @@ - - Tools / Manager - - - Tools / User - - + + Tools / User + + + Tools / Manager + + + diff --git a/addons/survey/security/survey_security.xml b/addons/survey/security/survey_security.xml index e76f5bce1f5..7b6c43ed2bc 100644 --- a/addons/survey/security/survey_security.xml +++ b/addons/survey/security/survey_security.xml @@ -1,14 +1,15 @@ - - Tools / Manager - - - Tools / User - - - Survey / User - + + Tools / User + + + Tools / Manager + + + + Survey / User + From 690f42073dae1f6310a8b7fa75776bfa67f9ba64 Mon Sep 17 00:00:00 2001 From: Raphael Collet Date: Tue, 2 Aug 2011 15:20:05 +0200 Subject: [PATCH 2/3] fixed implications between sales groups bzr revid: rco@openerp.com-20110802132005-9f30si9s6luo2qvk --- addons/crm/security/crm_security.xml | 12 ++++++------ addons/sale/security/sale_security.xml | 12 ++++++------ 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/addons/crm/security/crm_security.xml b/addons/crm/security/crm_security.xml index e063b9f41be..45b7ccb017e 100644 --- a/addons/crm/security/crm_security.xml +++ b/addons/crm/security/crm_security.xml @@ -2,18 +2,18 @@ - - Sales / User - All Leads - - Sales / User - Own Leads Only - + + + + Sales / User - All Leads + Sales / Manager - + diff --git a/addons/sale/security/sale_security.xml b/addons/sale/security/sale_security.xml index ebe5b884537..bed44a8d726 100644 --- a/addons/sale/security/sale_security.xml +++ b/addons/sale/security/sale_security.xml @@ -2,19 +2,19 @@ - - Sales / User - All Leads - - Sales / User - Own Leads Only - + + + + Sales / User - All Leads + Sales / Manager - + From 06ef024dfe05ea56dd701812cf4797d6de2ea53a Mon Sep 17 00:00:00 2001 From: Raphael Collet Date: Tue, 2 Aug 2011 15:50:30 +0200 Subject: [PATCH 3/3] [IMP] portal: remove other_group_ids, which is superseded by implied_ids bzr revid: rco@openerp.com-20110802135030-wh6nfwzfoy235baf --- addons/portal/portal.py | 25 +++++++++---------------- addons/portal/portal_view.xml | 23 ++++++++++------------- 2 files changed, 19 insertions(+), 29 deletions(-) diff --git a/addons/portal/portal.py b/addons/portal/portal.py index 78483d6a1f1..1c7f84c363a 100644 --- a/addons/portal/portal.py +++ b/addons/portal/portal.py @@ -37,10 +37,6 @@ class portal(osv.osv): 'group_id': fields.many2one('res.groups', required=True, ondelete='cascade', string='Group', help='The group extended by this portal'), - 'other_group_ids': fields.many2many('res.groups', - 'portal_group_rel', 'portal_id', 'group_id', - string='Other User Groups', - help="Those groups are assigned to the portal's users"), 'url': fields.char('URL', size=64, help="The url where portal users can connect to the server"), 'menu_action_id': fields.many2one('ir.actions.act_window', readonly=True, @@ -70,8 +66,8 @@ class portal(osv.osv): portal_id = super(portal, self).create(cr, uid, values, context) # assign menu action and widgets to users - if values.get('users') or values.get('other_group_ids') or values.get('menu_action_id'): - self._assign_menu_and_groups(cr, uid, [portal_id], context) + if values.get('users') or values.get('menu_action_id'): + self._assign_menu(cr, uid, [portal_id], context) if values.get('users') or values.get('widget_ids'): self._assign_widgets(cr, uid, [portal_id], context) @@ -83,8 +79,8 @@ class portal(osv.osv): super(portal, self).write(cr, uid, ids, values, context) # assign menu action and widgets to users - if values.get('users') or values.get('other_group_ids') or values.get('menu_action_id'): - self._assign_menu_and_groups(cr, uid, ids, context) + if values.get('users') or values.get('menu_action_id'): + self._assign_menu(cr, uid, ids, context) if values.get('users') or values.get('widget_ids'): self._assign_widgets(cr, uid, ids, context) @@ -117,18 +113,15 @@ class portal(osv.osv): return True - def _assign_menu_and_groups(self, cr, uid, ids, context=None): - """ assign portal menu and other groups to users of portals (ids) """ + def _assign_menu(self, cr, uid, ids, context=None): + """ assign portal menu to users of portals (ids) """ user_obj = self.pool.get('res.users') for p in self.browse(cr, uid, ids, context): - # user groups = portal group + other groups - group_ids = [p.group_id.id] + [g.id for g in p.other_group_ids] - user_values = {'groups_id': [(6, 0, group_ids)]} # user menu action = portal menu action if set in portal if p.menu_action_id: - user_values['menu_id'] = p.menu_action_id.id - user_ids = [u.id for u in p.users if u.id != 1] - user_obj.write(cr, uid, user_ids, user_values, context) + user_ids = [u.id for u in p.users if u.id != 1] + user_values = {'menu_id': p.menu_action_id.id} + user_obj.write(cr, uid, user_ids, user_values, context) def _assign_widgets(self, cr, uid, ids, context=None): """ assign portal widgets to users of portals (ids) """ diff --git a/addons/portal/portal_view.xml b/addons/portal/portal_view.xml index d43c6115ad6..a6a780fdf16 100644 --- a/addons/portal/portal_view.xml +++ b/addons/portal/portal_view.xml @@ -43,10 +43,19 @@ the portal's users. - + + + + + + + + + + @@ -56,18 +65,6 @@ the portal's users.