From fa0738dd7ecd9c5de983fa6404118d6a3478785e Mon Sep 17 00:00:00 2001
From: nounoubensebia <neb@odoo.com>
Date: Thu, 22 Apr 2021 15:01:26 +0000
Subject: [PATCH] [FIX] mail: display default name for followers for "other
 address" partner

Display the default name (the one displayed in the kanban view) for followers replacing
the False value for "other address" partners, this way the user won't get
confused, furthermore, this fix won't require the name to be mandatory for this
type of contacts.

Task-2514244

closes odoo/odoo#70445

X-original-commit: 338b84bd9d2d675af30ab19c6bb262d2f68546b9
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
---
 addons/mail/controllers/main.py                         | 1 +
 addons/mail/static/src/components/follower/follower.xml | 2 +-
 addons/mail/static/src/models/follower/follower.js      | 4 ++++
 3 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/addons/mail/controllers/main.py b/addons/mail/controllers/main.py
index 9f8c82e4173..05941ed0f7b 100644
--- a/addons/mail/controllers/main.py
+++ b/addons/mail/controllers/main.py
@@ -142,6 +142,7 @@ class MailController(http.Controller):
                 'id': follower.id,
                 'partner_id': follower.partner_id.id,
                 'name': follower.name,
+                'display_name': follower.display_name,
                 'email': follower.email,
                 'is_active': follower.is_active,
                 # When editing the followers, the "pencil" icon that leads to the edition of subtypes
diff --git a/addons/mail/static/src/components/follower/follower.xml b/addons/mail/static/src/components/follower/follower.xml
index c8abebcae95..f82722cf870 100644
--- a/addons/mail/static/src/components/follower/follower.xml
+++ b/addons/mail/static/src/components/follower/follower.xml
@@ -6,7 +6,7 @@
             <t t-if="follower">
                 <a class="o_Follower_details" t-att-class="{ 'o-inactive': !follower.isActive }" href="#" t-on-click="_onClickDetails">
                     <img class="o_Follower_avatar" t-att-src="follower.partner.avatarUrl" alt="Avatar"/>
-                    <span class="o_Follower_name" t-esc="follower.name"/>
+                    <span class="o_Follower_name" t-esc="follower.name or follower.displayName"/>
                 </a>
                 <t t-if="follower.isEditable">
                     <button class="btn btn-icon o_Follower_button o_Follower_editButton" title="Edit subscription" t-on-click="_onClickEdit">
diff --git a/addons/mail/static/src/models/follower/follower.js b/addons/mail/static/src/models/follower/follower.js
index 166922ca156..61fa983091c 100644
--- a/addons/mail/static/src/models/follower/follower.js
+++ b/addons/mail/static/src/models/follower/follower.js
@@ -33,6 +33,7 @@ function factory(dependencies) {
                     data2.partner = unlinkAll();
                 } else {
                     const partnerData = {
+                        display_name: data.display_name,
                         email: data.email,
                         id: data.partner_id,
                         name: data.name,
@@ -158,6 +159,9 @@ function factory(dependencies) {
     }
 
     Follower.fields = {
+        displayName: attr({
+            related: 'partner.display_name'
+        }),
         followedThread: many2one('mail.thread', {
             inverse: 'followers',
         }),