From f9e34d98f1df23897eda4b29de737c79a441d69b Mon Sep 17 00:00:00 2001 From: Romain Derie Date: Mon, 5 Nov 2018 16:45:49 +0000 Subject: [PATCH] [FIX] web_unsplash: do not fetch app_id if no Unsplash images As empty arrays are considered truthy, the call to `/web_unsplash/get_app_id` would always be performed even if no Unsplash images. closes odoo/odoo#28421 --- addons/web_unsplash/static/src/js/unsplash_beacon.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/web_unsplash/static/src/js/unsplash_beacon.js b/addons/web_unsplash/static/src/js/unsplash_beacon.js index d287a3dd80d..f8e74a3b759 100644 --- a/addons/web_unsplash/static/src/js/unsplash_beacon.js +++ b/addons/web_unsplash/static/src/js/unsplash_beacon.js @@ -10,7 +10,7 @@ base.ready().then(function () { // get image id from URL (`/unsplash/xYdf5feoI.jpg` -> `xYdf5feoI`) unsplash_images.push(img.src.split('/unsplash/')[1].split('.')[0]); }); - if (unsplash_images) { + if (unsplash_images.length) { ajax.jsonRpc('/web_unsplash/get_app_id', 'call').then(function (appID) { if (appID) { var unsplash_view_url = 'https://views.unsplash.com/v';