From f9ce42c763389573ed6a19bbb1a4a9784d82a1bb Mon Sep 17 00:00:00 2001 From: Goffin Simon Date: Thu, 24 May 2018 15:24:17 +0200 Subject: [PATCH] [FIX] sale_timesheet: ZeroDivisionError To avoid a division by zero. Courtesy of @tbe-odoo opw:1850023 --- addons/sale_timesheet/controllers/main.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/addons/sale_timesheet/controllers/main.py b/addons/sale_timesheet/controllers/main.py index f1c72039eb4..d4c82e5ed10 100644 --- a/addons/sale_timesheet/controllers/main.py +++ b/addons/sale_timesheet/controllers/main.py @@ -56,8 +56,8 @@ class SaleTimesheetController(http.Controller): dashboard_values['hours'][billable_type] = float_round(data.get('unit_amount'), precision_rounding=hour_rounding) dashboard_values['hours']['total'] += float_round(data.get('unit_amount'), precision_rounding=hour_rounding) # rates - dashboard_values['rates'][billable_type] = round(data.get('unit_amount') / dashboard_total_hours * 100, 2) - dashboard_values['rates']['total'] += round(data.get('unit_amount') / dashboard_total_hours * 100, 2) + dashboard_values['rates'][billable_type] = dashboard_total_hours and round(data.get('unit_amount') / dashboard_total_hours * 100, 2) or 0 + dashboard_values['rates']['total'] += dashboard_total_hours and round(data.get('unit_amount') / dashboard_total_hours * 100, 2) or 0 # money_amount so_lines = values['timesheet_lines'].mapped('so_line')