diff --git a/addons/mail/static/src/rtc/call_settings.js b/addons/mail/static/src/discuss/call_settings.js similarity index 98% rename from addons/mail/static/src/rtc/call_settings.js rename to addons/mail/static/src/discuss/call_settings.js index cd2ce485516..e1f7d7359af 100644 --- a/addons/mail/static/src/rtc/call_settings.js +++ b/addons/mail/static/src/discuss/call_settings.js @@ -1,13 +1,13 @@ /* @odoo-module */ -import { Component, onWillStart, useExternalListener, useState } from "@odoo/owl"; import { useRtc } from "@mail/rtc/rtc_hook"; -import { useService } from "@web/core/utils/hooks"; +import { Component, onWillStart, useExternalListener, useState } from "@odoo/owl"; import { browser } from "@web/core/browser/browser"; import { _t } from "@web/core/l10n/translation"; +import { useService } from "@web/core/utils/hooks"; export class CallSettings extends Component { - static template = "mail.CallSettings"; + static template = "discuss.CallSettings"; static props = ["thread", "className?"]; setup() { diff --git a/addons/mail/static/src/rtc/call_settings.xml b/addons/mail/static/src/discuss/call_settings.xml similarity index 98% rename from addons/mail/static/src/rtc/call_settings.xml rename to addons/mail/static/src/discuss/call_settings.xml index fb18b5533e6..db966371a4a 100644 --- a/addons/mail/static/src/rtc/call_settings.xml +++ b/addons/mail/static/src/discuss/call_settings.xml @@ -1,8 +1,8 @@ - -
+ +
Voice Settings
diff --git a/addons/mail/static/src/discuss/discuss_patch.js b/addons/mail/static/src/discuss/discuss_patch.js index 79d3b1efbfd..4ee83b4c6a3 100644 --- a/addons/mail/static/src/discuss/discuss_patch.js +++ b/addons/mail/static/src/discuss/discuss_patch.js @@ -1,5 +1,6 @@ /* @odoo-module */ +import { CallSettings } from "@mail/discuss/call_settings"; import { ChannelInvitation } from "@mail/discuss/channel_invitation"; import { ChannelMemberList } from "@mail/discuss/channel_member_list"; import { Discuss } from "@mail/discuss_app/discuss"; @@ -8,7 +9,7 @@ import { usePopover } from "@web/core/popover/popover_hook"; import { patch } from "@web/core/utils/patch"; patch(Discuss, "discuss", { - components: { ...Discuss.components, ChannelMemberList }, + components: { ...Discuss.components, CallSettings, ChannelMemberList }, }); patch(Discuss.prototype, "discuss", { @@ -37,4 +38,8 @@ patch(Discuss.prototype, "discuss", { ? this.MODES.NONE : this.MODES.MEMBER_LIST; }, + toggleSettings() { + this.state.activeMode = + this.state.activeMode === this.MODES.SETTINGS ? this.MODES.NONE : this.MODES.SETTINGS; + }, }); diff --git a/addons/mail/static/src/discuss/discuss_patch.scss b/addons/mail/static/src/discuss/discuss_patch.scss index 5883a08a05d..798f91a5ef5 100644 --- a/addons/mail/static/src/discuss/discuss_patch.scss +++ b/addons/mail/static/src/discuss/discuss_patch.scss @@ -1,3 +1,7 @@ +.o-mail-Discuss-callSettings { + width: 300px; +} + .o-mail-Discuss-channelMemberList { width: $o-mail-Discuss-inspector; } diff --git a/addons/mail/static/src/discuss/discuss_patch.xml b/addons/mail/static/src/discuss/discuss_patch.xml index f6def0b2144..ca044ae1c1f 100644 --- a/addons/mail/static/src/discuss/discuss_patch.xml +++ b/addons/mail/static/src/discuss/discuss_patch.xml @@ -8,9 +8,13 @@ + + diff --git a/addons/mail/static/src/discuss/web/chat_window_patch.js b/addons/mail/static/src/discuss/web/chat_window_patch.js index 7930751974c..9f46611fa8e 100644 --- a/addons/mail/static/src/discuss/web/chat_window_patch.js +++ b/addons/mail/static/src/discuss/web/chat_window_patch.js @@ -1,12 +1,13 @@ /* @odoo-module */ +import { CallSettings } from "@mail/discuss/call_settings"; import { ChannelInvitation } from "@mail/discuss/channel_invitation"; import { ChannelMemberList } from "@mail/discuss/channel_member_list"; import { ChatWindow } from "@mail/web/chat_window/chat_window"; import { patch } from "@web/core/utils/patch"; patch(ChatWindow, "discuss", { - components: { ...ChatWindow.components, ChannelInvitation, ChannelMemberList }, + components: { ...ChatWindow.components, CallSettings, ChannelInvitation, ChannelMemberList }, }); patch(ChatWindow.prototype, "discuss", { @@ -16,4 +17,7 @@ patch(ChatWindow.prototype, "discuss", { toggleMemberList() { this.state.activeMode = this.state.activeMode === "member-list" ? "" : "member-list"; }, + toggleSettings() { + this.state.activeMode = this.state.activeMode === "in-settings" ? "" : "in-settings"; + }, }); diff --git a/addons/mail/static/src/discuss/web/chat_window_patch.xml b/addons/mail/static/src/discuss/web/chat_window_patch.xml index b45cefc3826..8eed76d6875 100644 --- a/addons/mail/static/src/discuss/web/chat_window_patch.xml +++ b/addons/mail/static/src/discuss/web/chat_window_patch.xml @@ -6,12 +6,16 @@
- +
+
+ +
- + + diff --git a/addons/mail/static/src/discuss_app/discuss.js b/addons/mail/static/src/discuss_app/discuss.js index 50823632c75..41747329144 100644 --- a/addons/mail/static/src/discuss_app/discuss.js +++ b/addons/mail/static/src/discuss_app/discuss.js @@ -18,7 +18,6 @@ import { useState, useEffect, } from "@odoo/owl"; -import { CallSettings } from "../rtc/call_settings"; import { useService } from "@web/core/utils/hooks"; import { _t } from "@web/core/l10n/translation"; import { PinnedMessagesPanel } from "./pinned_messages_panel"; @@ -30,7 +29,6 @@ export class Discuss extends Component { ThreadIcon, Composer, Call, - CallSettings, PinnedMessagesPanel, }; static props = { @@ -109,11 +107,6 @@ export class Discuss extends Component { : this.MODES.PINNED_MESSAGES; } - toggleSettings() { - this.state.activeMode = - this.state.activeMode === this.MODES.SETTINGS ? this.MODES.NONE : this.MODES.SETTINGS; - } - async renameThread({ value: name }) { const newName = name.trim(); if ( diff --git a/addons/mail/static/src/discuss_app/discuss.scss b/addons/mail/static/src/discuss_app/discuss.scss index 31db3e2ead8..d77b31c6815 100644 --- a/addons/mail/static/src/discuss_app/discuss.scss +++ b/addons/mail/static/src/discuss_app/discuss.scss @@ -8,10 +8,6 @@ } } -.o-mail-Discuss-callSettings { - width: 300px; -} - .o-mail-Discuss-selfAvatar { height: $o-mail-Avatar-sizeSmall; width: $o-mail-Avatar-sizeSmall; diff --git a/addons/mail/static/src/discuss_app/discuss.xml b/addons/mail/static/src/discuss_app/discuss.xml index 3b21b708467..cfe2ed1cfab 100644 --- a/addons/mail/static/src/discuss_app/discuss.xml +++ b/addons/mail/static/src/discuss_app/discuss.xml @@ -34,9 +34,6 @@ -
Avatar
@@ -58,7 +55,6 @@
-
diff --git a/addons/mail/static/src/web/chat_window/chat_window.js b/addons/mail/static/src/web/chat_window/chat_window.js index eba68492fe4..181985b3f2c 100644 --- a/addons/mail/static/src/web/chat_window/chat_window.js +++ b/addons/mail/static/src/web/chat_window/chat_window.js @@ -9,7 +9,6 @@ import { useMessageEdition, useMessageHighlight, useMessageToReplyTo } from "@ma import { Component, useChildSubEnv, useRef, useState } from "@odoo/owl"; import { useService } from "@web/core/utils/hooks"; import { localization } from "@web/core/l10n/localization"; -import { CallSettings } from "@mail/rtc/call_settings"; import { ThreadIcon } from "@mail/discuss_app/thread_icon"; import { isEventHandled } from "@mail/utils/misc"; import { ChannelSelector } from "@mail/discuss_app/channel_selector"; @@ -28,7 +27,6 @@ export class ChatWindow extends Component { Thread, ChannelSelector, Composer, - CallSettings, ThreadIcon, PinnedMessagesPanel, }; @@ -128,10 +126,6 @@ export class ChatWindow extends Component { this.state.activeMode === "pinned-messages" ? "" : "pinned-messages"; } - toggleSettings() { - this.state.activeMode = this.state.activeMode === "in-settings" ? "" : "in-settings"; - } - expand() { if (this.thread.type === "chatter") { this.action.doAction({ diff --git a/addons/mail/static/src/web/chat_window/chat_window.xml b/addons/mail/static/src/web/chat_window/chat_window.xml index 7b2be0b4daa..37ea890ce4c 100644 --- a/addons/mail/static/src/web/chat_window/chat_window.xml +++ b/addons/mail/static/src/web/chat_window/chat_window.xml @@ -33,10 +33,7 @@
-
- -
-
+
@@ -47,7 +44,6 @@
- diff --git a/addons/mail/static/tests/call/call_settings_menu_tests.js b/addons/mail/static/tests/discuss/call_settings_menu_tests.js similarity index 96% rename from addons/mail/static/tests/call/call_settings_menu_tests.js rename to addons/mail/static/tests/discuss/call_settings_menu_tests.js index a79f0adc2a0..3a582fc8023 100644 --- a/addons/mail/static/tests/call/call_settings_menu_tests.js +++ b/addons/mail/static/tests/discuss/call_settings_menu_tests.js @@ -32,7 +32,7 @@ QUnit.test("Renders the call settings", async (assert) => { const { openDiscuss } = await start(); await openDiscuss(channelId); await click(".o-mail-Discuss-header .fa-gear"); - assert.containsOnce($, ".o-mail-CallSettings", "Should have a call settings menu"); + assert.containsOnce($, ".o-discuss-CallSettings", "Should have a call settings menu"); assert.containsOnce($, "label[aria-label='Input device']"); assert.containsOnce($, "option[value=mockAudioDeviceId]"); assert.containsNone($, "option[value=mockVideoDeviceId]"); @@ -106,6 +106,6 @@ QUnit.test( await click("button[title='Show Call Settings']"); await click("button:contains(Inbox)"); assert.containsNone($, "button[title='Hide Call Settings']"); - assert.containsNone($, ".o-mail-CallSettings"); + assert.containsNone($, ".o-discuss-CallSettings"); } ); diff --git a/addons/mail/static/tests/discuss/discuss_tests.js b/addons/mail/static/tests/discuss/discuss_tests.js index a85c6037204..07c34b6fac8 100644 --- a/addons/mail/static/tests/discuss/discuss_tests.js +++ b/addons/mail/static/tests/discuss/discuss_tests.js @@ -12,6 +12,6 @@ QUnit.test("Member list and settings menu are exclusive", async (assert) => { await click("button[title='Show Member List']"); assert.containsOnce($, ".o-discuss-ChannelMemberList"); await click("button[title='Show Call Settings']"); - assert.containsOnce($, ".o-mail-CallSettings"); + assert.containsOnce($, ".o-discuss-CallSettings"); assert.containsNone($, ".o-discuss-ChannelMemberList"); });