From f922f51910b6d01f7ccec1cbac45c92a588fec4a Mon Sep 17 00:00:00 2001 From: "Didier (did)" Date: Mon, 29 Aug 2022 11:48:50 +0000 Subject: [PATCH] [FIX] mail: avoid partner without name in suggestion MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit task-2884212 closes odoo/odoo#99432 X-original-commit: 385ba1d062abbc73ca3cdb9a27adb4b9cc7803be Signed-off-by: Sébastien Theys (seb) --- addons/mail/static/src/models/partner.js | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/addons/mail/static/src/models/partner.js b/addons/mail/static/src/models/partner.js index f44637db065..ad1649869cf 100644 --- a/addons/mail/static/src/models/partner.js +++ b/addons/mail/static/src/models/partner.js @@ -137,8 +137,8 @@ registerModel({ return 1; } } - const cleanedAName = cleanSearchTerm(a.nameOrDisplayName || ''); - const cleanedBName = cleanSearchTerm(b.nameOrDisplayName || ''); + const cleanedAName = cleanSearchTerm(a.name || ''); + const cleanedBName = cleanSearchTerm(b.name || ''); if (cleanedAName.startsWith(cleanedSearchTerm) && !cleanedBName.startsWith(cleanedSearchTerm)) { return -1; } @@ -242,8 +242,11 @@ registerModel({ // partners (livechat guests), public partners (technical) continue; } + if (!partner.name) { + continue; + } if ( - (partner.nameOrDisplayName && cleanSearchTerm(partner.nameOrDisplayName).includes(cleanedSearchTerm)) || + (cleanSearchTerm(partner.name).includes(cleanedSearchTerm)) || (partner.email && cleanSearchTerm(partner.email).includes(cleanedSearchTerm)) ) { if (partner.user) {