From f8e0c92bf4fd21eeb12cd4cc2a2f47f1304b23aa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thibault=20Delavall=C3=A9e?= Date: Thu, 13 Aug 2020 07:08:41 +0000 Subject: [PATCH] [FIX] website: add missing digest dependency Related to digest update in 13.4 (a595ebfca5ab7041224c661f404138612257bdda). QUERY COUNT IN BLOG Local installation of blog still makes those tests use 27 or 28 queries. On runbot it grows until 32. Due to dependency change, installation order changes. It may have an effect on query count in website loading some pages in blog. This is worth checking why queries are added. Digest module itself has nothing to do with website. It could either be a side effect of some computed field, either an installation order change adding more modules before installing blog, with side-effect of adding queries due to another module. As without this fix installing website is not possible, let us merge this one and investigate further soon. closes odoo/odoo#55835 Signed-off-by: Thibault Delavallee (tde) --- addons/website/__manifest__.py | 1 + addons/website_blog/tests/test_performance.py | 10 +++++----- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/addons/website/__manifest__.py b/addons/website/__manifest__.py index 656b89deb1b..f7ea43fdce8 100644 --- a/addons/website/__manifest__.py +++ b/addons/website/__manifest__.py @@ -10,6 +10,7 @@ 'version': '1.0', 'description': "", 'depends': [ + 'digest', 'web', 'web_editor', 'http_routing', diff --git a/addons/website_blog/tests/test_performance.py b/addons/website_blog/tests/test_performance.py index 876f5a4db39..4a472fd8236 100644 --- a/addons/website_blog/tests/test_performance.py +++ b/addons/website_blog/tests/test_performance.py @@ -7,7 +7,7 @@ import random class TestBlogPerformance(UtilPerf): def test_10_perf_sql_blog_standard_data(self): - self.assertEqual(self._get_url_hot_query('/blog'), 28) + self.assertEqual(self._get_url_hot_query('/blog'), 32) def test_20_perf_sql_blog_bigger_data_scaling(self): BlogPost = self.env['blog.post'] @@ -19,8 +19,8 @@ class TestBlogPerformance(UtilPerf): for blog_post in blog_posts: blog_post.tag_ids += blog_tags blog_tags = blog_tags[:-1] - self.assertEqual(self._get_url_hot_query('/blog'), 28) - self.assertEqual(self._get_url_hot_query(blog_post[0].website_url), 31) + self.assertEqual(self._get_url_hot_query('/blog'), 32) + self.assertEqual(self._get_url_hot_query(blog_post[0].website_url), 35) def test_30_perf_sql_blog_bigger_data_scaling(self): BlogPost = self.env['blog.post'] @@ -32,5 +32,5 @@ class TestBlogPerformance(UtilPerf): for blog_post in blog_posts: blog_post.write({'tag_ids': [[6, 0, random.choices(blog_tags.ids, k=random.randint(0, len(blog_tags)))]]}) - self.assertLessEqual(self._get_url_hot_query('/blog'), 28) - self.assertLessEqual(self._get_url_hot_query(blog_post[0].website_url), 31) + self.assertLessEqual(self._get_url_hot_query('/blog'), 32) + self.assertLessEqual(self._get_url_hot_query(blog_post[0].website_url), 35)