From f8071dc5211d73f6fea438112025050f8dd49176 Mon Sep 17 00:00:00 2001 From: "Eteil Djoumatchoua (etdj)" Date: Mon, 2 Jan 2023 15:26:51 +0000 Subject: [PATCH] [FIX] sms: fix traceback clicking on Send SMS button Steps: install calendar app. enable sms template of calendar. go to calendar event form view. try to send SMS. Issue: traceback clicking `Send SMS' of Send SMS wizard. Cause: trying to write on field even though field does not exist in model. Fix: check field exist in model before write on it. task-3084701 closes odoo/odoo#114824 X-original-commit: b773006055f0c29e56b2719621e2abd80af6b9e7 Signed-off-by: Thibault Delavallee (tde) --- addons/test_mail_sms/tests/test_sms_composer.py | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/addons/test_mail_sms/tests/test_sms_composer.py b/addons/test_mail_sms/tests/test_sms_composer.py index 2f999eb6912..ba4ed996b39 100644 --- a/addons/test_mail_sms/tests/test_sms_composer.py +++ b/addons/test_mail_sms/tests/test_sms_composer.py @@ -120,6 +120,19 @@ class TestSMSComposerComment(TestSMSCommon, TestSMSRecipients): self.assertSMSNotification([{'partner': self.test_record.customer_id, 'number': self.test_record.mobile_nbr}], 'Dear %s this is an SMS.' % self.test_record.display_name, messages) + def test_composer_comment_nofield(self): + """ Test the Send Message in SMS Composer when a Model does not contain any phone number related field """ + test_record = self.env['mail.test.sms.partner'].create({'name': 'Test'}) + sms_composer = self.env['sms.composer'].create({ + 'body': self._test_body, + 'recipient_single_number_itf': self.random_numbers_san[0], + 'res_id': test_record.id, + 'res_model': 'mail.test.sms.partner' + }) + with self.mockSMSGateway(): + sms_composer._action_send_sms() + self.assertSMSNotification([{'number': self.random_numbers_san[0]}], self._test_body) + def test_composer_default_recipient(self): self.test_record.write({ 'phone_nbr': '0123456789',