From f7eae25635f6966d88cdbfc057fef7ac01f12d3d Mon Sep 17 00:00:00 2001
From: Mustufa Rangwala <mra@mra-laptop>
Date: Fri, 22 Oct 2010 18:46:15 +0530
Subject: [PATCH] [FIX] sale_order_dates: remove return from for loop and
 cleaning

bzr revid: mra@mra-laptop-20101022131615-35i9ss38tud6bylp
---
 addons/sale_order_dates/sale_order_dates.py       | 13 ++++++-------
 addons/sale_order_dates/sale_order_dates_view.xml |  3 ++-
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/addons/sale_order_dates/sale_order_dates.py b/addons/sale_order_dates/sale_order_dates.py
index 011653abc01..2877ba0967d 100644
--- a/addons/sale_order_dates/sale_order_dates.py
+++ b/addons/sale_order_dates/sale_order_dates.py
@@ -26,9 +26,8 @@ from osv import fields, osv
 
 class sale_order_dates(osv.osv):
     _inherit = 'sale.order'
-    _name = 'sale.order'
 
-    def _get_effective_date(self, cr, uid, ids, name, arg, context={}):
+    def _get_effective_date(self, cr, uid, ids, name, arg, context=None):
         res = {}
         dates_list = []
         for order in self.browse(cr, uid, ids):
@@ -39,9 +38,9 @@ class sale_order_dates(osv.osv):
                 res[order.id] = min(dates_list)
             else:
                 res[order.id] = False
-            return res
+        return res
 
-    def _get_commitment_date(self, cr, uid, ids, name, arg, context={}):
+    def _get_commitment_date(self, cr, uid, ids, name, arg, context=None):
         res = {}
         dates_list = []
         for order in self.browse(cr, uid, ids):
@@ -52,12 +51,12 @@ class sale_order_dates(osv.osv):
                 dates_list.append(dt_s)
             if dates_list:
                 res[order.id] = min(dates_list)
-            return res
+        return res
 
     _columns = {
-        'commitment_date': fields.function(_get_commitment_date, method=True,store=True, type='date', string='Commitment Date', help="Date on which delivery of products is to be made"),
+        'commitment_date': fields.function(_get_commitment_date, method=True, store=True, type='date', string='Commitment Date', help="Date on which delivery of products is to be made"),
         'requested_date': fields.date('Requested Date', help="Date on which customer has requested for sales"),
-        'effective_date': fields.function(_get_effective_date, method=True, type='date', store=True,string='Effective Date',help="Date on which picking is created"),
+        'effective_date': fields.function(_get_effective_date, method=True, type='date', store=True, string='Effective Date',help="Date on which picking is created"),
     }
 
 sale_order_dates()
diff --git a/addons/sale_order_dates/sale_order_dates_view.xml b/addons/sale_order_dates/sale_order_dates_view.xml
index 5bb53fe52ce..c6544d5238f 100644
--- a/addons/sale_order_dates/sale_order_dates_view.xml
+++ b/addons/sale_order_dates/sale_order_dates_view.xml
@@ -17,5 +17,6 @@
                 </field>
             </field>
         </record>
+
     </data>
-</openerp>
+</openerp>
\ No newline at end of file