From f7d7c53cd51c402672a49f98ddebab2cce7cb6ad Mon Sep 17 00:00:00 2001 From: Jeremy Kersten Date: Fri, 27 Mar 2020 15:15:30 +0000 Subject: [PATCH] [IMP] base: server_attachment add max-age when unique is provided Similarly to method _binary_set_headers, when we serve an attachment (e.g. image) where an unique is present in URL we add a long time of cache. We considere that the hash will be changed if attachment is updated, so while we ask for same checksum, lets the browser return the cached response. closes odoo/odoo#48653 Signed-off-by: Christophe Simonis --- odoo/addons/base/models/ir_http.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/odoo/addons/base/models/ir_http.py b/odoo/addons/base/models/ir_http.py index ba771a95753..a03693e455f 100644 --- a/odoo/addons/base/models/ir_http.py +++ b/odoo/addons/base/models/ir_http.py @@ -162,7 +162,10 @@ class IrHttp(models.AbstractModel): response.last_modified = wdate response.set_etag(checksum) - response.make_conditional(request.httprequest) + response.make_conditional( + request.httprequest, + max_age=http.STATIC_CACHE_LONG if request.params.get('unique') else 0 + ) if response.status_code == 304: return response