From f752b9888920fd3b0c4936e641bdfc4f56d2a1f1 Mon Sep 17 00:00:00 2001
From: "Tiffany Chang (tic)" <tic@odoo.com>
Date: Thu, 23 Jun 2022 14:22:37 +0000
Subject: [PATCH] [IMP] mrp, stock{_account,_picking_batch}: update inventory
 menus

- reorder/rename/remove menu contents for "Inventory" and "Reporting",
  including:
 - removed "Forecasted Inventory" menuitem since this view is no longer
   considered useful (code for view to be removed in separate commit)
 - removed "Stock Moves" (moves report) menuitem
 - renamed "Product Move" (move lines report) menuitem => "Moves
   History", this will also be reflected in any "History" buttons that
   open this view from other views.
 - made "Inventory Report" menuitem visible only when applicable (i.e.
   multi-location or consignment is active/debug mpde)
 - made "Run Scheduler" menuitem only available in debug mode (
   main_flow_tour updated to skip scheduler click since general flow is
   expected to still the same/work)

Goal of renaming/ordering of menuitems is to clean them up and make them
more intuitive for users.

- "Run Scheduler" in mrp menus has also been made debug only viewable as
  well to mirror the inventory change.

"menu" part of b2b task: 2882539
ENT PR: odoo/enterprise#29974

Part-of: odoo/odoo#97109
---
 addons/mrp/views/stock_move_views.xml              |  1 +
 addons/stock/views/product_views.xml               |  1 -
 addons/stock/views/stock_move_line_views.xml       |  4 ++--
 addons/stock/views/stock_move_views.xml            |  2 --
 addons/stock/views/stock_orderpoint_views.xml      |  2 +-
 addons/stock/views/stock_picking_views.xml         |  2 +-
 addons/stock/views/stock_quant_views.xml           |  6 +++---
 .../stock/wizard/stock_scheduler_compute_views.xml |  2 +-
 .../views/stock_valuation_layer_views.xml          |  2 +-
 .../views/stock_picking_batch_views.xml            |  2 +-
 .../views/stock_picking_wave_views.xml             |  2 +-
 .../static/tests/tours/main_flow.js                | 14 --------------
 12 files changed, 12 insertions(+), 28 deletions(-)

diff --git a/addons/mrp/views/stock_move_views.xml b/addons/mrp/views/stock_move_views.xml
index ca508b99849..fd9691477f6 100644
--- a/addons/mrp/views/stock_move_views.xml
+++ b/addons/mrp/views/stock_move_views.xml
@@ -85,6 +85,7 @@
     <menuitem id="menu_procurement_compute_mrp"
         action="stock.action_procurement_compute"
         parent="mrp_planning_menu_root"
+        groups="base.group_no_one"
         sequence="135"/>
 
 </odoo>
diff --git a/addons/stock/views/product_views.xml b/addons/stock/views/product_views.xml
index 3f4cd347f6b..087da7de0d3 100644
--- a/addons/stock/views/product_views.xml
+++ b/addons/stock/views/product_views.xml
@@ -479,7 +479,6 @@
     <menuitem id="product_product_menu" name="Product Variants" action="stock_product_normal_action"
         parent="menu_stock_inventory_control" sequence="2" groups="product.group_product_variant"/>
     <menuitem id="menu_product_packagings" name="Product Packagings" parent="stock.menu_product_in_config_stock" action="product.action_packaging_view" groups="product.group_stock_packaging"/>
-    <menuitem id="menu_forecast_inventory" name="Forecasted Inventory" parent="stock.menu_warehouse_report" sequence="101" action="stock.report_stock_quantity_action"/>
 
     </data>
 </odoo>
diff --git a/addons/stock/views/stock_move_line_views.xml b/addons/stock/views/stock_move_line_views.xml
index 808ab9be078..ccf127020e4 100644
--- a/addons/stock/views/stock_move_line_views.xml
+++ b/addons/stock/views/stock_move_line_views.xml
@@ -172,7 +172,7 @@
     </record>
 
     <record id="stock_move_line_action" model="ir.actions.act_window">
-            <field name="name">Product Moves</field>
+            <field name="name">Moves History</field>
             <field name="res_model">stock.move.line</field>
             <field name="type">ir.actions.act_window</field>
             <field name="view_mode">tree,kanban,pivot,form</field>
@@ -191,5 +191,5 @@
     <menuitem
         action="stock_move_line_action"
         id="stock_move_line_menu"
-        parent="stock.menu_warehouse_report" sequence="150"/>
+        parent="stock.menu_warehouse_report" sequence="200"/>
 </odoo>
diff --git a/addons/stock/views/stock_move_views.xml b/addons/stock/views/stock_move_views.xml
index 38b489e7dd3..01d9da3b1fd 100644
--- a/addons/stock/views/stock_move_views.xml
+++ b/addons/stock/views/stock_move_views.xml
@@ -469,6 +469,4 @@
             </field>
         </record>
 
-        <menuitem action="stock_move_action" id="stock_move_menu" parent="stock.menu_warehouse_report" sequence="140" groups="base.group_no_one"/>
-
 </odoo>
diff --git a/addons/stock/views/stock_orderpoint_views.xml b/addons/stock/views/stock_orderpoint_views.xml
index 3d851d9dcc0..dbd5eb76676 100644
--- a/addons/stock/views/stock_orderpoint_views.xml
+++ b/addons/stock/views/stock_orderpoint_views.xml
@@ -227,7 +227,7 @@
     <menuitem
         id="menu_reordering_rules_replenish"
         action="action_replenishment"
-        name="Replenishment" parent="menu_stock_warehouse_mgmt" sequence="10"
+        name="Replenishment" parent="menu_stock_warehouse_mgmt" sequence="5"
         groups="stock.group_stock_manager"/>
     <menuitem
         id="menu_reordering_rules_config"
diff --git a/addons/stock/views/stock_picking_views.xml b/addons/stock/views/stock_picking_views.xml
index 5a2f2e18e5e..16403e30bad 100644
--- a/addons/stock/views/stock_picking_views.xml
+++ b/addons/stock/views/stock_picking_views.xml
@@ -585,7 +585,7 @@
             <field name="binding_view_types">list</field>
         </record>
 
-        <menuitem id="all_picking" name="Transfers" parent="menu_stock_warehouse_mgmt" sequence="5" action="action_picking_tree_all" groups="stock.group_stock_manager,stock.group_stock_user"/>
+        <menuitem id="all_picking" name="Transfers" parent="menu_stock_warehouse_mgmt" sequence="20" action="action_picking_tree_all" groups="stock.group_stock_manager,stock.group_stock_user"/>
 
         <record id="stock_picking_action_picking_type" model="ir.actions.act_window">
             <field name="name">All Transfers</field>
diff --git a/addons/stock/views/stock_quant_views.xml b/addons/stock/views/stock_quant_views.xml
index 56fac15d9a3..4df60b86800 100644
--- a/addons/stock/views/stock_quant_views.xml
+++ b/addons/stock/views/stock_quant_views.xml
@@ -394,9 +394,9 @@
         </field>
     </record>
 
-    <menuitem id="menu_action_inventory_tree" name="Inventory Adjustments" parent="menu_stock_warehouse_mgmt" sequence="30" action="action_view_inventory_tree" />
+    <menuitem id="menu_action_inventory_tree" name="Inventory Adjustments" parent="menu_stock_warehouse_mgmt" sequence="10" action="action_view_inventory_tree" />
     <menuitem id="menu_package" name="Packages" parent="menu_stock_inventory_control" action="action_package_view" groups="stock.group_tracking_lot" sequence="102"/>
     <menuitem id="menu_valuation" name="Inventory Report"
-              parent="stock.menu_warehouse_report" sequence="100"
-              action="action_view_quants"/>
+              parent="stock.menu_warehouse_report" sequence="150"
+              action="action_view_quants" groups="stock.group_stock_multi_locations,stock.group_tracking_owner"/>
 </odoo>
diff --git a/addons/stock/wizard/stock_scheduler_compute_views.xml b/addons/stock/wizard/stock_scheduler_compute_views.xml
index 41550d752c4..c12814dc647 100644
--- a/addons/stock/wizard/stock_scheduler_compute_views.xml
+++ b/addons/stock/wizard/stock_scheduler_compute_views.xml
@@ -23,7 +23,7 @@
         <field name="target">new</field>
     </record>
 
-    <menuitem action="action_procurement_compute" id="menu_procurement_compute" parent="menu_stock_warehouse_mgmt" sequence="135"/>
+    <menuitem action="action_procurement_compute" id="menu_procurement_compute" parent="menu_stock_warehouse_mgmt" sequence="135" groups="base.group_no_one"/>
 
 
 </odoo>
diff --git a/addons/stock_account/views/stock_valuation_layer_views.xml b/addons/stock_account/views/stock_valuation_layer_views.xml
index cb05c74bbbb..ee00ed796f1 100644
--- a/addons/stock_account/views/stock_valuation_layer_views.xml
+++ b/addons/stock_account/views/stock_valuation_layer_views.xml
@@ -102,7 +102,7 @@
         </field>
     </record>
 
-    <menuitem id="menu_valuation" name="Inventory Valuation" parent="stock.menu_warehouse_report" sequence="110" action="stock_valuation_layer_action"/>
+    <menuitem id="menu_valuation" name="Valuation" parent="stock.menu_warehouse_report" sequence="250" action="stock_valuation_layer_action" groups="base.group_no_one"/>
 
     <record id="stock_valuation_layer_picking" model="ir.ui.view">
         <field name="name">stock.valuation.layer.picking</field>
diff --git a/addons/stock_picking_batch/views/stock_picking_batch_views.xml b/addons/stock_picking_batch/views/stock_picking_batch_views.xml
index eb7f25bbdc3..916c9b5c360 100644
--- a/addons/stock_picking_batch/views/stock_picking_batch_views.xml
+++ b/addons/stock_picking_batch/views/stock_picking_batch_views.xml
@@ -261,7 +261,7 @@
           </p>
         </field>
     </record>
-    <menuitem action="stock_picking_batch_action" id="stock_picking_batch_menu" parent="stock.menu_stock_warehouse_mgmt" sequence="6"/>
+    <menuitem action="stock_picking_batch_action" id="stock_picking_batch_menu" parent="stock.menu_stock_warehouse_mgmt" sequence="21"/>
 
     <record id="vpicktree_inherit_stock_picking_batch" model="ir.ui.view">
         <field name="name">stock.picking.tree</field>
diff --git a/addons/stock_picking_batch/views/stock_picking_wave_views.xml b/addons/stock_picking_batch/views/stock_picking_wave_views.xml
index dff8eb550fa..7a01a01d774 100644
--- a/addons/stock_picking_batch/views/stock_picking_wave_views.xml
+++ b/addons/stock_picking_batch/views/stock_picking_wave_views.xml
@@ -64,6 +64,6 @@
         id="stock_picking_wave_menu"
         parent="stock.menu_stock_warehouse_mgmt"
         groups="stock.group_stock_picking_wave"
-        sequence="8"/>
+        sequence="23"/>
 
 </odoo>
diff --git a/odoo/addons/test_main_flows/static/tests/tours/main_flow.js b/odoo/addons/test_main_flows/static/tests/tours/main_flow.js
index 34dfa4a0c86..137f425b4c2 100644
--- a/odoo/addons/test_main_flows/static/tests/tours/main_flow.js
+++ b/odoo/addons/test_main_flows/static/tests/tours/main_flow.js
@@ -706,20 +706,6 @@ tour.stepUtils.openBuggerMenu("li.breadcrumb-item.active:contains('Inventory Ove
 },
 tour.stepUtils.openBuggerMenu("li.breadcrumb-item.active:contains('OP/')"),
 {
-// Run the schedulers
-    trigger: ".o_menu_sections button:contains('Operations')",
-    content: _t("Go to Run Schedulers"),
-    position: "bottom"
-}, {
-    trigger: ".o_menu_sections .dropdown-item[data-menu-xmlid='stock.menu_procurement_compute']",
-    content: _t("Click on schedulers"),
-    position: "bottom"
-}, {
-    trigger: ".modal-footer .btn-primary",
-    extra_trigger: ".modal-dialog",
-    content: _t("Run Schedulers"),
-    position: "bottom",
-}, {
 //Go to purchase:
     edition: "enterprise",
     trigger: '.o_menu_toggle',