From f648ab94eb6c55ae17ebdbc37f23f5faa39fddaf Mon Sep 17 00:00:00 2001
From: rso-odoo <rso@odoo.com>
Date: Wed, 22 Jan 2020 13:09:49 +0000
Subject: [PATCH] [IMP] stock, stock_account: locations views and filters

- add a filter "production locations" on stock location
- add an action returning the production stock locations
- display a link to this action in the product category views in stock
  account so users can easily set the correct accounts on these
  locations
- set valuation journal an account before the others in the product
  category form

Task-2161057

closes odoo/odoo#43762

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
---
 addons/stock/views/stock_location_views.xml  | 11 +++++++++++
 addons/stock_account/views/product_views.xml |  7 +++++--
 2 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/addons/stock/views/stock_location_views.xml b/addons/stock/views/stock_location_views.xml
index 6cb37b9a7e7..815aa7588a5 100644
--- a/addons/stock/views/stock_location_views.xml
+++ b/addons/stock/views/stock_location_views.xml
@@ -68,6 +68,7 @@
                 <field name="name" string="Stock Locations"/>
                 <filter name="in_location" string="Internal" domain="[('usage', '=', 'internal')]" help="Internal Locations"/>
                 <filter name="customer" string="Customer" domain="[('usage', '=', 'customer')]" help="Customer Locations"/>
+                <filter name="prod_inv_location" string="Production" domain="[('usage', 'in', ['inventory', 'production'])]" help="Production Locations"/>
                 <filter name="supplier" string="Vendor" domain="[('usage', '=', 'supplier')]" help="Vendor Locations"/>
                 <field name="location_id" string="Parent Location"/>
                 <separator/>
@@ -129,6 +130,16 @@
           </p>
         </field>
     </record>
+    <record id="action_prod_inv_location_form" model="ir.actions.act_window">
+        <field name="name">Locations</field>
+        <field name="res_model">stock.location</field>
+        <field name="type">ir.actions.act_window</field>
+        <field name="view_mode">tree,form</field>
+        <field name="view_id" ref="view_location_tree2"/>
+        <field name="search_view_id" ref="view_location_search"/>
+        <field name="context">{'search_default_prod_inv_location': 1}</field>
+    </record>
+
     <menuitem action="action_location_form" id="menu_action_location_form"
         parent="menu_warehouse_config" sequence="2" groups="stock.group_stock_multi_locations"/>
 
diff --git a/addons/stock_account/views/product_views.xml b/addons/stock_account/views/product_views.xml
index ecf06963350..633b4eff4f5 100644
--- a/addons/stock_account/views/product_views.xml
+++ b/addons/stock_account/views/product_views.xml
@@ -19,10 +19,13 @@
             <field name="arch" type="xml">
                 <group name="account_property" position="inside">
                     <group name="account_stock_property" string="Account Stock Properties" groups="account.group_account_readonly">
+                        <field name="property_stock_valuation_account_id" options="{'no_create': True}" attrs="{'required':[('property_valuation', '=', 'real_time')]}"/>
+                        <field name="property_stock_journal" attrs="{'required':[('property_valuation', '=', 'real_time')]}" />
                         <field name="property_stock_account_input_categ_id" attrs="{'required':[ ('property_valuation', '=', 'real_time')]}" />
                         <field name="property_stock_account_output_categ_id" attrs="{'required':[ ('property_valuation', '=', 'real_time')]}" />
-                        <field name="property_stock_valuation_account_id" options="{'no_create': True}" attrs="{'required':[ ('property_valuation', '=', 'real_time')]}"/>
-                        <field name="property_stock_journal" attrs="{'required':[ ('property_valuation', '=', 'real_time')]}" />
+                        <div colspan="2" class="alert alert-info mt16" role="status">
+                            <b>Set other input/output accounts on specific </b><button name="%(stock.action_prod_inv_location_form)d" role="button" type="action" class="btn-link" style="padding: 0;vertical-align: baseline;" string="locations"/>.
+                        </div>
                     </group>
                 </group>
                 <group name="account_property" position="before">