From f5f0752f88778519a58caee526ea9ab8d0e810bf Mon Sep 17 00:00:00 2001 From: fda-odoo Date: Thu, 18 Mar 2021 11:19:09 +0000 Subject: [PATCH] [FIX] snailmail: avoid timeout issue MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit _snailmail_print can be called on multiple letters, and this can lead to a timeout from IAP Service. However, letters are sent, credits are consumed, but letters aren't marked as sent. To avoid that, we force the sending to IAP service to be done letter by letter. closes odoo/odoo#68107 X-original-commit: 3d8ad1e68583fa1b354ff36f902ccb0405270bb2 Signed-off-by: Rémi Rahir (rar) --- addons/snailmail/models/snailmail_letter.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/addons/snailmail/models/snailmail_letter.py b/addons/snailmail/models/snailmail_letter.py index cdee59e1b15..a6c063bd56e 100644 --- a/addons/snailmail/models/snailmail_letter.py +++ b/addons/snailmail/models/snailmail_letter.py @@ -305,8 +305,9 @@ class SnailmailLetter(models.Model): invalid_address_letters = self - valid_address_letters invalid_address_letters._snailmail_print_invalid_address() if valid_address_letters and immediate: - valid_address_letters._snailmail_print_valid_address() - self.env.cr.commit() + for letter in valid_address_letters: + letter._snailmail_print_valid_address() + self.env.cr.commit() def _snailmail_print_invalid_address(self): error = 'MISSING_REQUIRED_FIELDS'