From f5eec1d53916e857dfcb82bff375e197ca78d3e2 Mon Sep 17 00:00:00 2001
From: "Anita (anko)" <anko@odoo.com>
Date: Fri, 18 Nov 2022 12:04:50 +0000
Subject: [PATCH] [FIX] sale,purchase,account: Duplicating document_tax_totals

If user would add addictional field in one of reports it could break other
reports as other models do not share all the same fields. Now modules inherit
template and create their version of field.

task-2858097

closes odoo/odoo#106140

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
---
 addons/account/views/report_invoice.xml             | 5 ++++-
 addons/purchase/report/purchase_order_templates.xml | 6 +++++-
 addons/purchase/views/portal_templates.xml          | 2 +-
 addons/sale/report/ir_actions_report_templates.xml  | 5 ++++-
 addons/sale/views/sale_portal_templates.xml         | 2 +-
 5 files changed, 15 insertions(+), 5 deletions(-)

diff --git a/addons/account/views/report_invoice.xml b/addons/account/views/report_invoice.xml
index 91e0a1371af..36354160da8 100644
--- a/addons/account/views/report_invoice.xml
+++ b/addons/account/views/report_invoice.xml
@@ -258,7 +258,7 @@
             </t>
         </template>
 
-        <template id="document_tax_totals">
+        <template id="document_tax_totals_template">
             <!--
                 Generic template to display tax totals in pdf reports.
                 Used by invoices, SO and PO.
@@ -299,6 +299,9 @@
             </tr>
         </template>
 
+         <!-- Allow edits (e.g. studio) without changing the often inherited base template -->
+        <template id="document_tax_totals" inherit_id="account.document_tax_totals_template" primary="True"></template>
+
         <template id="tax_groups_totals">
             <!--
                 Generic template to display a list of tax groups with the related amounts.
diff --git a/addons/purchase/report/purchase_order_templates.xml b/addons/purchase/report/purchase_order_templates.xml
index 21d75c89a5f..052c7dedefd 100644
--- a/addons/purchase/report/purchase_order_templates.xml
+++ b/addons/purchase/report/purchase_order_templates.xml
@@ -117,7 +117,7 @@
                 <div class="col-4">
                     <table class="table table-sm">
                         <t t-set="tax_totals" t-value="o.tax_totals"/>
-                        <t t-call="account.document_tax_totals"/>
+                        <t t-call="purchase.document_tax_totals"/>
                     </table>
                 </div>
             </div>
@@ -135,4 +135,8 @@
         </t>
     </t>
 </template>
+
+ <!-- Allow edits (e.g. studio) without changing the often inherited base template -->
+<template id="document_tax_totals" inherit_id="account.document_tax_totals_template" primary="True"></template>
+
 </odoo>
diff --git a/addons/purchase/views/portal_templates.xml b/addons/purchase/views/portal_templates.xml
index e294d82ea74..ef3404d2b61 100644
--- a/addons/purchase/views/portal_templates.xml
+++ b/addons/purchase/views/portal_templates.xml
@@ -374,7 +374,7 @@
   <template id="purchase_order_portal_content_totals_table">
       <table class="table table-sm">
           <t t-set="tax_totals" t-value="order.tax_totals"/>
-          <t t-call="account.document_tax_totals"/>
+          <t t-call="purchase.document_tax_totals"/>
       </table>
   </template>
 
diff --git a/addons/sale/report/ir_actions_report_templates.xml b/addons/sale/report/ir_actions_report_templates.xml
index 4b0a86070c8..32d59022fc9 100644
--- a/addons/sale/report/ir_actions_report_templates.xml
+++ b/addons/sale/report/ir_actions_report_templates.xml
@@ -148,7 +148,7 @@
                         <table class="table table-sm">
                             <!-- Tax totals -->
                             <t t-set="tax_totals" t-value="doc.tax_totals"/>
-                            <t t-call="account.document_tax_totals"/>
+                            <t t-call="sale.document_tax_totals"/>
                         </table>
                     </div>
                 </div>
@@ -200,4 +200,7 @@
     </t>
 </template>
 
+ <!-- Allow edits (e.g. studio) without changing the often inherited base template -->
+<template id="document_tax_totals" inherit_id="account.document_tax_totals_template" primary="True"></template>
+
 </odoo>
diff --git a/addons/sale/views/sale_portal_templates.xml b/addons/sale/views/sale_portal_templates.xml
index 0a5d587dbe7..0fd5c1df2f0 100644
--- a/addons/sale/views/sale_portal_templates.xml
+++ b/addons/sale/views/sale_portal_templates.xml
@@ -595,7 +595,7 @@
     <template id="sale_order_portal_content_totals_table">
         <table class="table table-sm">
             <t t-set="tax_totals" t-value="sale_order.tax_totals"/>
-            <t t-call="account.document_tax_totals"/>
+            <t t-call="sale.document_tax_totals"/>
         </table>
     </template>
 </odoo>