From f58fa65c2bb1f6ec65b3b9ed7227975ce2799e83 Mon Sep 17 00:00:00 2001 From: Goffin Simon Date: Wed, 17 Jul 2019 14:45:12 +0000 Subject: [PATCH] [FIX] hr_expense: Encoding negative amount in expense Before this commit: 15fa0c23d946daa6e87607fe6ffb9062458cc97f It was possible to encode negative amount for an hr.expense. Before the fix, it raised a Error saying: "Cannot create unbalanced journal entry." opw:2036620 closes odoo/odoo#34953 Signed-off-by: Simon Goffin (sig) --- addons/hr_expense/models/hr_expense.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/addons/hr_expense/models/hr_expense.py b/addons/hr_expense/models/hr_expense.py index 3f6f173c674..a8120989819 100644 --- a/addons/hr_expense/models/hr_expense.py +++ b/addons/hr_expense/models/hr_expense.py @@ -312,8 +312,8 @@ class HrExpense(models.Model): 'currency_id': expense.currency_id.id if different_currency else False, } move_line_values.append(move_line_src) - total_amount -= move_line_src['debit'] - total_amount_currency -= move_line_src['amount_currency'] or move_line_src['debit'] + total_amount += -move_line_src['debit'] or move_line_src['credit'] + total_amount_currency += -move_line_src['amount_currency'] if move_line_src['currency_id'] else (-move_line_src['debit'] or move_line_src['credit']) # taxes move lines for tax in taxes['taxes']: