From f53ad8a4fd6f1b98625dd659e429177beae7ae80 Mon Sep 17 00:00:00 2001 From: Xavier Morel Date: Mon, 4 Feb 2019 09:17:41 +0000 Subject: [PATCH] [FIX] search_filters: broke a thing in f1a85ba As part of fixing the JS docs (docstrings & references & ...), the various search filters were de-namespaced (aka ExtendedSearchProposition.Integer = ... -> var Integer = ...). This had the side-effect of making a `new Date` refer to the extended search Date field instead of the global Date object, which went unnoticed because *that* had been wrapped in a moment() call, and moment() apparently doesn't mind being given garbage, but it would also create an "unbound" and thus never destroyed widget. Remove the `new Date`, calling moment directly has pretty much the same effect, moment objects created from date objects just have an extra field (a cache for the date object I guess). closes odoo/odoo#30791 --- addons/web/static/src/js/chrome/search_filters.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/web/static/src/js/chrome/search_filters.js b/addons/web/static/src/js/chrome/search_filters.js index 4628578f9fe..05de554da2f 100644 --- a/addons/web/static/src/js/chrome/search_filters.js +++ b/addons/web/static/src/js/chrome/search_filters.js @@ -238,7 +238,7 @@ var DateTime = Field.extend({ _create_new_widget: function (name) { this[name] = new (this._get_widget_class())(this); return this[name].appendTo(this.$el).then((function () { - this[name].setValue(moment(new Date())); + this[name].setValue(moment()); }).bind(this)); }, _get_widget_class: function () {