From f4f0a82b84185ba6e21db090fbf8804bde3fae46 Mon Sep 17 00:00:00 2001 From: vishal padhiyar Date: Mon, 19 Jun 2023 12:32:06 +0000 Subject: [PATCH] [FIX] web_{editor}: add missing args in position callback Before this commit: When attempting to open a dynamic placeholder in email marketing, a traceback occurs. After this commit: Now the dynamic placeholder works properly. Task-3373356 closes odoo/odoo#129415 X-original-commit: bb9fb402a135baf7e7b9da9bbb40888f5323ded9 Signed-off-by: David Monjoie (dmo) --- addons/web/static/src/views/fields/dynamic_placeholder_hook.js | 2 +- addons/web_editor/static/src/js/backend/html_field.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/addons/web/static/src/views/fields/dynamic_placeholder_hook.js b/addons/web/static/src/views/fields/dynamic_placeholder_hook.js index fbdccfcf35e..8ac59bddfa2 100644 --- a/addons/web/static/src/views/fields/dynamic_placeholder_hook.js +++ b/addons/web/static/src/views/fields/dynamic_placeholder_hook.js @@ -13,7 +13,7 @@ export function useDynamicPlaceholder(elementRef) { let positionCallback; const popover = usePopover(DynamicPlaceholderPopover, { onclose: () => closeCallback?.(), - onPositioned: () => positionCallback?.(), + onPositioned: (popper, position) => positionCallback?.(popper, position), }); const notification = useService("notification"); diff --git a/addons/web_editor/static/src/js/backend/html_field.js b/addons/web_editor/static/src/js/backend/html_field.js index 1d730f198c6..7c4ada205b9 100644 --- a/addons/web_editor/static/src/js/backend/html_field.js +++ b/addons/web_editor/static/src/js/backend/html_field.js @@ -343,7 +343,7 @@ export class HtmlField extends Component { // Ensure the focus is in the editable document // before inserting the element. this.wysiwyg.focus(); - let dynamicPlaceholder = "object." + chain.join('.'); + let dynamicPlaceholder = "object." + chain; dynamicPlaceholder += defaultValue && defaultValue !== '' ? ` or '''${defaultValue}'''` : ''; const t = document.createElement('T'); t.setAttribute('t-out', dynamicPlaceholder);