From f458ffe5f683a2183502db2b8062a73a9669ed9c Mon Sep 17 00:00:00 2001 From: Goffin Simon Date: Thu, 22 Oct 2020 11:13:49 +0000 Subject: [PATCH] [FIX] website_sale_wishlist: Product with sale_ok = False in wishlist MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Steps to reproduce the bug: - Let's consider a sellable product P published on the shop - Let's consider a portal user PU adding P in his wishlist W - Set P with sale_ok = False (meaning unsellable) - With PU try to see W Bug: A 430 error was raised because the product P was not sellable opw:2362184 closes odoo/odoo#60540 X-original-commit: 8646b0049808036422fec200163a8a4ff1d0df43 Signed-off-by: Jérémy Kersten (jke) Signed-off-by: Simon Goffin (sig) --- addons/website_sale_wishlist/models/product_wishlist.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/website_sale_wishlist/models/product_wishlist.py b/addons/website_sale_wishlist/models/product_wishlist.py index 9439b5261d7..8c34a703f85 100644 --- a/addons/website_sale_wishlist/models/product_wishlist.py +++ b/addons/website_sale_wishlist/models/product_wishlist.py @@ -33,7 +33,7 @@ class ProductWishlist(models.Model): else: wish = self.search([("partner_id", "=", self.env.user.partner_id.id), ('website_id', '=', request.website.id)]) - return wish.filtered(lambda x: x.sudo().product_id.product_tmpl_id.website_published) + return wish.filtered(lambda x: x.sudo().product_id.product_tmpl_id.website_published and x.sudo().product_id.product_tmpl_id.sale_ok) @api.model def _add_to_wishlist(self, pricelist_id, currency_id, website_id, price, product_id, partner_id=False):