From f4373cd034ba3f704ab57f04f2c237bb518c937e Mon Sep 17 00:00:00 2001
From: Vincent Larcin <vila@odoo.com>
Date: Fri, 1 Oct 2021 12:36:17 +0000
Subject: [PATCH] [IMP] project: indicate private tasks in multiple views

This commit will indicate 'fa-lock private' for the 'Project' field for private tasks in the following views: list, calendar popover, kanban, activity.

Previously, this field was left blank.

Task-2657697

Closes #77870
---
 .../src/js/widgets/project_private_task.js    | 25 +++++++++++++++++++
 .../static/src/xml/project_templates.xml      |  3 +++
 addons/project/views/project_views.xml        | 10 +++++---
 3 files changed, 34 insertions(+), 4 deletions(-)
 create mode 100644 addons/project/static/src/js/widgets/project_private_task.js

diff --git a/addons/project/static/src/js/widgets/project_private_task.js b/addons/project/static/src/js/widgets/project_private_task.js
new file mode 100644
index 00000000000..6c079bca83c
--- /dev/null
+++ b/addons/project/static/src/js/widgets/project_private_task.js
@@ -0,0 +1,25 @@
+/** @odoo-module alias=project.project_private_task **/
+"use strict";
+
+import field_registry from 'web.field_registry';
+import { FieldMany2One } from 'web.relational_fields';
+import core from 'web.core';
+
+const QWeb = core.qweb;
+
+const ProjectPrivateTask = FieldMany2One.extend({
+    /**
+     * @override
+     * @private
+     */
+    _renderReadonly: function() {
+        this._super.apply(this, arguments);
+        if (!this.m2o_value) {
+            this.$el.empty();
+            this.$el.append(QWeb.render('project.task.PrivateProjectName'));
+            this.$el.addClass('o_debounce_disabled');
+        }
+    },
+});
+
+field_registry.add('project_private_task', ProjectPrivateTask);
diff --git a/addons/project/static/src/xml/project_templates.xml b/addons/project/static/src/xml/project_templates.xml
index 1369eefb859..936ac518c27 100644
--- a/addons/project/static/src/xml/project_templates.xml
+++ b/addons/project/static/src/xml/project_templates.xml
@@ -135,5 +135,8 @@
             </span>
         </div>
     </t>
+    <t t-name="project.task.PrivateProjectName">
+        <span class="font-italic text-muted"><i class="fa fa-lock"></i> Private</span>
+    </t>
 
 </templates>
diff --git a/addons/project/views/project_views.xml b/addons/project/views/project_views.xml
index e053a1b6d41..86acea86a1b 100644
--- a/addons/project/views/project_views.xml
+++ b/addons/project/views/project_views.xml
@@ -1099,7 +1099,7 @@
                                         </t>
                                         <t t-else="">
                                             <br/>
-                                            <span class="fa fa-lock text-muted"/><span class="text-muted"> Private</span>
+                                            <span class="font-italic text-muted"><i class="fa fa-lock"></i> Private</span>
                                         </t> 
                                         <br />
                                         <t t-if="record.partner_id.value">
@@ -1171,7 +1171,7 @@
                     <field name="priority" widget="priority" optional="show" nolabel="1"/>
                     <field name="name" widget="name_with_subtask_count"/>
                     <field name="child_text" invisible="1"/>
-                    <field name="project_id" optional="show" readonly="1"/>
+                    <field name="project_id" widget="project_private_task" optional="show" readonly="1"/>
                     <field name="partner_id" optional="hide"/>
                     <field name="parent_id" optional="hide" attrs="{'invisible': [('allow_subtasks', '=', False)]}" groups="base.group_no_one"/>
                     <field name="user_ids" optional="show" widget="many2many_avatar_user"/>
@@ -1209,7 +1209,7 @@
             <field name="arch" type="xml">
                 <calendar date_start="date_deadline" string="Tasks" mode="month" color="user_ids" event_limit="5"
                           hide_time="true" js_class="project_calendar" event_open_popup="true" quick_add="false">
-                    <field name="project_id" filters="1"/>
+                    <field name="project_id" widget="project_private_task" filters="1"/>
                     <field name="user_ids" widget="many2many_avatar_user"/>
                     <field name="partner_id" attrs="{'invisible': [('partner_id', '=', False)]}"/>
                     <field name="priority" widget="priority"/>
@@ -1257,6 +1257,7 @@
             <field name="arch" type="xml">
                 <activity string="Project Tasks" js_class="project_activity">
                     <field name="user_ids"/>
+                    <field name="project_id"/>
                     <templates>
                         <div class="justify-content-between" t-name="activity-box">
                             <field name="user_ids" widget="many2many_avatar_user"/>
@@ -1265,7 +1266,8 @@
                                     <field name="name" display="full"/>
                                 </span>
                                 <span t-att-title="record.project_id.value">
-                                    <field name="project_id" muted="1" display="full" invisible="context.get('default_project_id', False)"/>
+                                    <field t-if="record.project_id.value" name="project_id" muted="1" display="full"/>
+                                    <span t-else="" class="font-italic text-muted"><i class="fa fa-lock"></i> Private</span>
                                 </span>
                             </div>
                         </div>