From f3ef7001cf35da72a6c35d958b3360fc9b2dd26d Mon Sep 17 00:00:00 2001 From: Denis Ledoux Date: Tue, 22 Dec 2015 16:12:56 +0100 Subject: [PATCH] [FIX] account: prevent recomputation of related field `internal_type` When creating a new `account.account`, or writing on an existing one, changing the `type`, the source of the related field `internal_type`, `user_type_id.type`, was re-written (re-stored) because the field was not read-only. In addition, the re-store of the value of this field triggered the re-store of the related field `internal_type` on all other `account.account` records using this `internal_type`, which leaded to: - Performance issues - Potential access rights issues, if this leaded to write operations on records to which the user does not have the access (multi-company rules, among others) Forcing the field as read-only allow to not pass the value of this `internal_type` from the web client to the server when creating or editing an `account.account`. Besides, the field is required in the view, to correctly trigger the according onchange method: ``` @api.onchange('internal_type') def onchange_internal_type(self): ``` opw-660292 Closes #10143 --- addons/account/views/account_view.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/account/views/account_view.xml b/addons/account/views/account_view.xml index df32b4b3d69..581b7200058 100644 --- a/addons/account/views/account_view.xml +++ b/addons/account/views/account_view.xml @@ -20,7 +20,7 @@ - +