From f3722bbfe410fd113daaa45d419435764be4b28c Mon Sep 17 00:00:00 2001
From: Xavier Morel <xmo@openerp.com>
Date: Tue, 9 Nov 2010 14:08:47 +0100
Subject: [PATCH] [IMP] base: make ir_values.get._result_get more readable and
 slightly faster.

On a test set of ~20 fields, using a precomputed set instead of a spot-computed tuple for 'in' testing yields ~30% speed improvement, and replacing the manual removal of elements by a listcomp filtering yields ~30% more.

Tests were also performed using sets and set.difference, while it yields better performances than manual element removal it is still worse than listcomp, especially when taking in account the re-serialization to a list

bzr revid: xmo@openerp.com-20101109130847-p1xfmk3zhhivebj1
---
 bin/addons/base/ir/ir_values.py | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/bin/addons/base/ir/ir_values.py b/bin/addons/base/ir/ir_values.py
index abc6aa5d928..f600f53ec79 100644
--- a/bin/addons/base/ir/ir_values.py
+++ b/bin/addons/base/ir/ir_values.py
@@ -24,6 +24,11 @@ from osv.orm import except_orm
 import pickle
 from tools.translate import _
 
+EXCLUDED_FIELDS = set((
+    'report_sxw_content', 'report_rml_content', 'report_sxw', 'report_rml',
+    'report_sxw_content_data', 'report_rml_content_data', 'search_view',
+    'search_view_id'))
+
 class ir_values(osv.osv):
     _name = 'ir.values'
 
@@ -192,17 +197,13 @@ class ir_values(osv.osv):
             keys.append(x[1])
             if x[3]:
                 model,id = x[2].split(',')
-                fields = self.pool.get(model).fields_get_keys(cr, uid)
-                pos = 0
                 # FIXME: It might be a good idea to opt-in that kind of stuff
                 # FIXME: instead of arbitrarily removing random fields
-                while pos<len(fields):
-                    if fields[pos] in ('report_sxw_content', 'report_rml_content',
-                        'report_sxw', 'report_rml', 'report_sxw_content_data',
-                        'report_rml_content_data', 'search_view', 'search_view_id'):
-                        del fields[pos]
-                    else:
-                        pos+=1
+                fields = [
+                    field
+                    for field in self.pool.get(model).fields_get_keys(cr, uid)
+                    if field not in EXCLUDED_FIELDS]
+
                 try:
                     datas = self.pool.get(model).read(cr, uid, [int(id)], fields, context)
                 except except_orm, e: