From f31ce5dc5ea2b999be525f58c9d7cf115a03d66a Mon Sep 17 00:00:00 2001 From: qsm-odoo Date: Mon, 15 Oct 2018 14:04:35 +0000 Subject: [PATCH] [FIX] web_editor: snippet options were not working if not pure text Some snippet options uses an image or icon as description instead of text (like the gradient option in some themes). Those were not working anymore as the user click was considered on the image/icon instead of the option itself. closes odoo/odoo#27807 --- .../web_editor/static/src/js/editor/snippets.options.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/addons/web_editor/static/src/js/editor/snippets.options.js b/addons/web_editor/static/src/js/editor/snippets.options.js index 59ea0d8447b..47a2ed33e7e 100644 --- a/addons/web_editor/static/src/js/editor/snippets.options.js +++ b/addons/web_editor/static/src/js/editor/snippets.options.js @@ -303,8 +303,8 @@ var SnippetOption = Widget.extend({ * @param {Event} ev */ _onLinkEnter: function (ev) { - var $opt = $(ev.target); - if (!$opt.hasClass('dropdown-item')) { + var $opt = $(ev.target).closest('.dropdown-item'); + if (!$opt.length) { return; } @@ -331,8 +331,8 @@ var SnippetOption = Widget.extend({ * @param {Event} ev */ _onLinkClick: function (ev) { - var $opt = $(ev.target); - if (!$opt.hasClass('dropdown-item') || !$opt.is(':hasData')) { + var $opt = $(ev.target).closest('.dropdown-item'); + if (!$opt.length || !$opt.is(':hasData')) { return; }