diff --git a/addons/hr_expense/models/hr_expense_sheet.py b/addons/hr_expense/models/hr_expense_sheet.py index 865615cc59a..f40c960d9a3 100644 --- a/addons/hr_expense/models/hr_expense_sheet.py +++ b/addons/hr_expense/models/hr_expense_sheet.py @@ -392,6 +392,11 @@ class HrExpenseSheet(models.Model): sheet.is_editable = False continue + if is_hr_admin: + # Administrator-level users are not restricted + sheet.is_editable = True + continue + employee = sheet.employee_id is_own_sheet = employee.user_id == self.env.user @@ -407,11 +412,6 @@ class HrExpenseSheet(models.Model): # If Approver-level or designated manager, can edit other people sheet sheet.is_editable = True continue - - if is_hr_admin and sheet.state in {'draft', 'submit', 'approve'}: - # Administrator-level users are not restricted - sheet.is_editable = True - continue sheet.is_editable = False @api.constrains('expense_line_ids')