diff --git a/odoo/models.py b/odoo/models.py index bedf7fec10e..ab958f62644 100644 --- a/odoo/models.py +++ b/odoo/models.py @@ -5105,6 +5105,19 @@ class BaseModel(MetaModel('DummyModel', (object,), {'_register': False})): if subnames else record[name] ) + def has_changed(self, name): + """ Return whether a field on record has changed. """ + record = self[''] + subnames = self[''][name] + if not subnames: + return self[name] != record[name] + else: + return len(self[name]) != len(record[name]) or any( + line_snapshot.has_changed(subname) + for line_snapshot in self[name] + for subname in subnames + ) + def diff(self, other): """ Return the values in ``self`` that differ from ``other``. Requires record cache invalidation for correct output! @@ -5182,25 +5195,24 @@ class BaseModel(MetaModel('DummyModel', (object,), {'_register': False})): result = {} - # process names in order (or the keys of values if no name given) - while todo: - name = todo.pop(0) - if name in done: - continue - done.add(name) - - with env.do_in_onchange(): + # process names in order + with env.do_in_onchange(): + while todo: # apply field-specific onchange methods - if field_onchange.get(name): - record._onchange_eval(name, field_onchange[name], result) + for name in todo: + if field_onchange.get(name): + record._onchange_eval(name, field_onchange[name], result) + done.add(name) - # make a snapshot (this forces evaluation of computed fields) - snapshot1 = Snapshot(record, nametree) + # determine which fields to process for the next pass + todo = [ + name + for name in nametree + if name not in done and snapshot0.has_changed(name) + ] - # determine which fields have been modified - for name in nametree: - if snapshot1[name] != snapshot0[name]: - todo.append(name) + # make the snapshot with the final values of record + snapshot1 = Snapshot(record, nametree) # determine values that have changed by comparing snapshots self.invalidate_cache()