From f100decbf42b9701f6affc8293db5d7c6835086d Mon Sep 17 00:00:00 2001 From: "Thomas Lefebvre (thle)" Date: Thu, 22 Dec 2022 12:47:06 +0000 Subject: [PATCH] [FIX] web: set loadIrFilters to true Steps to reproduce: - install "sale_management" module; - create a quotation; - add a product; - click on "Search More..."; - create a favorite filter; - leave and return to the Dialog window. Issue: No previously saved filter appears. Cause: The `loadIrFilters` parameter has a default value equal to `false`. Solution: Set the value of the `loadIrFilters` parameter to `true`. opw-3105096 closes odoo/odoo#108946 X-original-commit: 7b60ee37e31d92d79108bd4e472553a452c2b0be Signed-off-by: Jorge Pinna Puissant (jpp) Signed-off-by: Lefebvre Thomas (thle) --- .../static/src/views/view_dialogs/select_create_dialog.js | 1 + .../tests/views/view_dialogs/select_create_dialog_tests.js | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/addons/web/static/src/views/view_dialogs/select_create_dialog.js b/addons/web/static/src/views/view_dialogs/select_create_dialog.js index 43e973164d4..0b20948349c 100644 --- a/addons/web/static/src/views/view_dialogs/select_create_dialog.js +++ b/addons/web/static/src/views/view_dialogs/select_create_dialog.js @@ -30,6 +30,7 @@ export class SelectCreateDialog extends Component { get viewProps() { const type = this.env.isSmall ? "kanban" : "list"; const props = { + loadIrFilters: true, ...this.baseViewProps, context: this.props.context, domain: this.props.domain, diff --git a/addons/web/static/tests/views/view_dialogs/select_create_dialog_tests.js b/addons/web/static/tests/views/view_dialogs/select_create_dialog_tests.js index f287bda4e5c..d0d292b94a8 100644 --- a/addons/web/static/tests/views/view_dialogs/select_create_dialog_tests.js +++ b/addons/web/static/tests/views/view_dialogs/select_create_dialog_tests.js @@ -342,7 +342,7 @@ QUnit.module("ViewDialogs", (hooks) => { }); QUnit.test("SelectCreateDialog: save current search", async function (assert) { - assert.expect(4); + assert.expect(5); serverData.views = { "partner,false,list": ` @@ -385,6 +385,9 @@ QUnit.module("ViewDialogs", (hooks) => { ); return 7; // fake serverSideId } + if (args.method === "get_views") { + assert.equal(args.kwargs.options.load_filters, true, "Missing load_filters option"); + } }; patchWithCleanup(browser, { setTimeout: (fn) => fn() }); const webClient = await createWebClient({ serverData, mockRPC });