From f0db37b2776ffa40b517843046736bfccaedfcc3 Mon Sep 17 00:00:00 2001 From: Toufik Ben Jaa Date: Tue, 19 Mar 2019 15:43:46 +0000 Subject: [PATCH] [FIX] hr_holidays: allow to create leaves with no validation - The creation of leaves using "no validation" are not possible if the `SUPERUSER` is not in the "Holidays / Team Leader" because the validation is made using `sudo`. OPW-1951316 closes odoo/odoo#31952 Signed-off-by: Toufik Benjaa (tbe) --- addons/hr_holidays/models/hr_leave.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/addons/hr_holidays/models/hr_leave.py b/addons/hr_holidays/models/hr_leave.py index cded512698d..042a1de8888 100644 --- a/addons/hr_holidays/models/hr_leave.py +++ b/addons/hr_holidays/models/hr_leave.py @@ -9,7 +9,7 @@ import math from datetime import datetime, time from pytz import timezone, UTC -from odoo import api, fields, models +from odoo import api, fields, models, SUPERUSER_ID from odoo.addons.resource.models.resource import float_to_time, HOURS_PER_DAY from odoo.exceptions import AccessError, UserError, ValidationError from odoo.tools import float_compare @@ -730,6 +730,9 @@ class HolidaysRequest(models.Model): def _check_approval_update(self, state): """ Check if target state is achievable. """ + if self.env.user.id == SUPERUSER_ID: + return + current_employee = self.env['hr.employee'].search([('user_id', '=', self.env.uid)], limit=1) is_team_leader = self.env.user.has_group('hr_holidays.group_hr_holidays_team_leader') is_officer = self.env.user.has_group('hr_holidays.group_hr_holidays_user')