From f0abe5b0edd28bcbc5c6aaf73c033100f26d5ee9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thibault=20Delavall=C3=A9e?= <tde@odoo.com>
Date: Mon, 10 Apr 2017 13:53:29 +0200
Subject: [PATCH] [IMP] payment_transfer: hide unnecessary fields for transfer
 provider

Indeed as transfer transactions are always pending and independant of
any callback, it is not necessary to see credentials, auto confirmation
settings and error / cancel / done messages.
---
 addons/payment/views/payment_views.xml        | 14 ++++++++---
 addons/payment_transfer/__manifest__.py       |  1 +
 .../payment_transfer/views/payment_views.xml  | 25 +++++++++++++++++++
 3 files changed, 37 insertions(+), 3 deletions(-)
 create mode 100644 addons/payment_transfer/views/payment_views.xml

diff --git a/addons/payment/views/payment_views.xml b/addons/payment/views/payment_views.xml
index 7c8550aa886..bf703e89ece 100644
--- a/addons/payment/views/payment_views.xml
+++ b/addons/payment/views/payment_views.xml
@@ -30,13 +30,21 @@
                         <field name="module_id" invisible="1"/>
                         <field name="module_state" invisible="1"/>
                         <div class="oe_button_box" name="button_box" attrs="{'invisible': ['&amp;', ('module_id', '!=', False), ('module_state', '!=', 'installed')]}">
-                            <button attrs="{'invisible': [('environment', '=', 'test')]}" class="oe_stat_button" name="toggle_environment_value" type="object" icon="fa-play">
+                            <!-- transfer referenced here due to view inheritance issue in current master (post-saas-16) -->
+                            <button name="toggle_environment_value"
+                                    attrs="{'invisible': ['|', ('environment', '=', 'test'), ('provider', '=', 'transfer')]}"
+                                    class="oe_stat_button"
+                                    type="object" icon="fa-play">
                                 <div class="o_stat_info o_field_widget">
                                     <span  class="text-success">Production</span>
                                     <span class="o_stat_text">Environment</span>
                                 </div>
                             </button>
-                            <button attrs="{'invisible': [('environment', '=', 'prod')]}" class="oe_stat_button" name="toggle_environment_value" type="object" icon="fa-stop">
+                            <!-- transfer referenced here due to view inheritance issue in current master (post-saas-16) -->
+                            <button name="toggle_environment_value"
+                                    attrs="{'invisible': ['|', ('environment', '=', 'prod'), ('provider', '=', 'transfer')]}"
+                                    class="oe_stat_button"
+                                    type="object" icon="fa-stop">
                                 <div class="o_stat_info o_field_widget">
                                     <span class="o_warning_text">Test</span>
                                     <span class="o_stat_text">Environment</span>
@@ -63,7 +71,7 @@
                             </group>
                         </group>
                         <notebook attrs="{'invisible': ['&amp;', ('module_id', '!=', False), ('module_state', '!=', 'installed')]}">
-                            <page string="Credentials">
+                            <page string="Credentials" name="acquirer_credentials">
                                 <group name="acquirer">
                                 </group>
                             </page>
diff --git a/addons/payment_transfer/__manifest__.py b/addons/payment_transfer/__manifest__.py
index d26949df288..9f8704467dc 100644
--- a/addons/payment_transfer/__manifest__.py
+++ b/addons/payment_transfer/__manifest__.py
@@ -8,6 +8,7 @@
     'description': """Transfer Payment Acquirer""",
     'depends': ['payment'],
     'data': [
+        'views/payment_views.xml',
         'views/payment_transfer_templates.xml',
         'data/payment_acquirer_data.xml',
     ],
diff --git a/addons/payment_transfer/views/payment_views.xml b/addons/payment_transfer/views/payment_views.xml
new file mode 100644
index 00000000000..127ab7b1238
--- /dev/null
+++ b/addons/payment_transfer/views/payment_views.xml
@@ -0,0 +1,25 @@
+<?xml version="1.0" encoding="utf-8"?>
+<odoo>
+    <record id="payment_acquirer_view_form_inherit_transfer" model="ir.ui.view">
+        <field name="name">payment.acquirer.view.form.inherit.transfer</field>
+        <field name="model">payment.acquirer</field>
+        <field name="inherit_id" ref="payment.acquirer_form"/>
+        <field name="arch" type="xml">
+            <page name="acquirer_credentials" position="attributes">
+                <attribute name="attrs">{'invisible': [('provider', '=', 'transfer')]}</attribute>
+            </page>
+            <field name="done_msg" position="attributes">
+                <attribute name="attrs">{'invisible': [('provider', '=', 'transfer')]}</attribute>
+            </field>
+            <field name="cancel_msg" position="attributes">
+                <attribute name="attrs">{'invisible': [('provider', '=', 'transfer')]}</attribute>
+            </field>
+            <field name="error_msg" position="attributes">
+                <attribute name="attrs">{'invisible': [('provider', '=', 'transfer')]}</attribute>
+            </field>
+            <field name="auto_confirm" position="attributes">
+                <attribute name="attrs">{'invisible': [('provider', '=', 'transfer')]}</attribute>
+            </field>
+        </field>
+    </record>
+</odoo>